Skip to content

Commit a06c6ad

Browse files
committed
updates
1 parent 6a98bd5 commit a06c6ad

File tree

5 files changed

+5
-19
lines changed

5 files changed

+5
-19
lines changed

packages/types/src/codebase-index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ export type CodebaseIndexModels = z.infer<typeof codebaseIndexModelsSchema>
6868
export const codebaseIndexProviderSchema = z.object({
6969
codeIndexOpenAiKey: z.string().optional(),
7070
codeIndexQdrantApiKey: z.string().optional(),
71-
codebaseIndexValkeyUsername: z.string().optional(),
7271
codeIndexValkeyPassword: z.string().optional(),
7372
codebaseIndexValkeyUseSsl: z.boolean().optional(),
7473
codebaseIndexOpenAiCompatibleBaseUrl: z.string().optional(),

src/i18n/locales/ko/embeddings.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/services/code-index/config-manager.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export class CodeIndexConfigManager {
101101
this.valkeyPort = codebaseIndexValkeyPort ?? 6379
102102
this.valkeyPassword = valkeyPassword
103103
this.valkeyUsername = codebaseIndexValkeyUsername
104-
this.valkeyUseSsl = codebaseIndexValkeyUseSsl || false
105104
this.valkeyUseSsl = codebaseIndexValkeyUseSsl ?? false
106105
this.searchMinScore = codebaseIndexSearchMinScore
107106
this.searchMaxResults = codebaseIndexSearchMaxResults
@@ -273,8 +272,7 @@ export class CodeIndexConfigManager {
273272
return isConfigured
274273
} else if (this.embedderProvider === "vercel-ai-gateway") {
275274
const apiKey = this.vercelAiGatewayOptions?.apiKey
276-
const qdrantUrl = this.qdrantUrl
277-
const isConfigured = !!(apiKey && qdrantUrl)
275+
const isConfigured = !!(apiKey && dbUrlPresent)
278276
return isConfigured
279277
}
280278
return false // Should not happen if embedderProvider is always set correctly
@@ -412,10 +410,6 @@ export class CodeIndexConfigManager {
412410
return true
413411
}
414412

415-
if (prevValkeyUseSsl !== currentValkeyUseSsl) {
416-
return true
417-
}
418-
419413
if (prevValkeyPassword !== currentValkeyPassword) {
420414
return true
421415
}
@@ -428,10 +422,6 @@ export class CodeIndexConfigManager {
428422
return true
429423
}
430424

431-
if (currentSearchProvider != prevSearchProvider) {
432-
return true
433-
}
434-
435425
// Vector dimension changes (still important for compatibility)
436426
if (this._hasVectorDimensionChanged(prevProvider, prev?.modelId)) {
437427
return true

src/services/code-index/vector-store/valkey-search-client.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,7 @@ export class ValkeySearchVectorStore implements IVectorStore {
5959
this.client.on("error", (error: Error) => {
6060
console.error("[ValkeySearch] Connection error:", error.message)
6161
this.isInitializing = false
62-
throw new Error(
63-
t("embeddings:vectorStore.vectorError", {
64-
errorMessage: error.message,
65-
}),
66-
)
62+
this.destroy()
6763
})
6864

6965
this.client.on("ready", () => {
@@ -73,6 +69,7 @@ export class ValkeySearchVectorStore implements IVectorStore {
7369

7470
this.client.on("end", () => {
7571
console.log("[ValkeySearch] Connection closed")
72+
this.isInitializing = false
7673
this.destroy()
7774
})
7875

webview-ui/src/i18n/locales/ca/settings.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)