Skip to content

Commit a07f94f

Browse files
committed
fix: Move sliders to newline in settings to avoid horizontal scroll at normal(20-25%) window size
1 parent 4026a87 commit a07f94f

File tree

1 file changed

+65
-54
lines changed

1 file changed

+65
-54
lines changed

webview-ui/src/components/settings/SettingsView.tsx

Lines changed: 65 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,20 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
139139
}
140140
}
141141

142+
const sliderLabelStyle = {
143+
minWidth: "45px",
144+
textAlign: "right" as const,
145+
lineHeight: "20px",
146+
paddingBottom: "2px",
147+
}
148+
149+
const sliderStyle = {
150+
flexGrow: 1,
151+
maxWidth: "80%",
152+
accentColor: "var(--vscode-button-background)",
153+
height: "2px",
154+
}
155+
142156
return (
143157
<div
144158
style={{
@@ -480,22 +494,22 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
480494
</div>
481495

482496
<div style={{ marginBottom: 15 }}>
483-
<div style={{ display: "flex", alignItems: "center", gap: "5px" }}>
484-
<span style={{ fontWeight: "500", minWidth: "100px" }}>Screenshot quality</span>
485-
<input
486-
type="range"
487-
min="1"
488-
max="100"
489-
step="1"
490-
value={screenshotQuality ?? 75}
491-
onChange={(e) => setScreenshotQuality(parseInt(e.target.value))}
492-
style={{
493-
flexGrow: 1,
494-
accentColor: "var(--vscode-button-background)",
495-
height: "2px",
496-
}}
497-
/>
498-
<span style={{ minWidth: "35px", textAlign: "left" }}>{screenshotQuality ?? 75}%</span>
497+
<div style={{ display: "flex", flexDirection: "column", gap: "5px" }}>
498+
<span style={{ fontWeight: "500" }}>Screenshot quality</span>
499+
<div style={{ display: "flex", alignItems: "center", gap: "5px" }}>
500+
<input
501+
type="range"
502+
min="1"
503+
max="100"
504+
step="1"
505+
value={screenshotQuality ?? 75}
506+
onChange={(e) => setScreenshotQuality(parseInt(e.target.value))}
507+
style={{
508+
...sliderStyle,
509+
}}
510+
/>
511+
<span style={{ ...sliderLabelStyle }}>{screenshotQuality ?? 75}%</span>
512+
</div>
499513
</div>
500514
<p
501515
style={{
@@ -558,24 +572,20 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
558572
<div style={{ marginBottom: 40 }}>
559573
<h3 style={{ color: "var(--vscode-foreground)", margin: "0 0 15px 0" }}>Advanced Settings</h3>
560574
<div style={{ marginBottom: 15 }}>
561-
<div style={{ display: "flex", alignItems: "center", gap: "5px" }}>
562-
<span style={{ fontWeight: "500", minWidth: "150px" }}>Terminal output limit</span>
563-
<input
564-
type="range"
565-
min="100"
566-
max="5000"
567-
step="100"
568-
value={terminalOutputLineLimit ?? 500}
569-
onChange={(e) => setTerminalOutputLineLimit(parseInt(e.target.value))}
570-
style={{
571-
flexGrow: 1,
572-
accentColor: "var(--vscode-button-background)",
573-
height: "2px",
574-
}}
575-
/>
576-
<span style={{ minWidth: "45px", textAlign: "left" }}>
577-
{terminalOutputLineLimit ?? 500}
578-
</span>
575+
<div style={{ display: "flex", flexDirection: "column", gap: "5px" }}>
576+
<span style={{ fontWeight: "500" }}>Terminal output limit</span>
577+
<div style={{ display: "flex", alignItems: "center", gap: "5px" }}>
578+
<input
579+
type="range"
580+
min="100"
581+
max="5000"
582+
step="100"
583+
value={terminalOutputLineLimit ?? 500}
584+
onChange={(e) => setTerminalOutputLineLimit(parseInt(e.target.value))}
585+
style={{ ...sliderStyle }}
586+
/>
587+
<span style={{ ...sliderLabelStyle }}>{terminalOutputLineLimit ?? 500}</span>
588+
</div>
579589
</div>
580590
<p style={{ fontSize: "12px", marginTop: "5px", color: "var(--vscode-descriptionForeground)" }}>
581591
Maximum number of lines to include in terminal output when executing commands. When exceeded
@@ -613,26 +623,27 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
613623
enabled={experiments[EXPERIMENT_IDS.DIFF_STRATEGY] ?? false}
614624
onChange={(enabled) => setExperimentEnabled(EXPERIMENT_IDS.DIFF_STRATEGY, enabled)}
615625
/>
616-
<div style={{ display: "flex", alignItems: "center", gap: "5px", marginTop: "15px" }}>
617-
<span style={{ fontWeight: "500", minWidth: "100px" }}>Match precision</span>
618-
<input
619-
type="range"
620-
min="0.8"
621-
max="1"
622-
step="0.005"
623-
value={fuzzyMatchThreshold ?? 1.0}
624-
onChange={(e) => {
625-
setFuzzyMatchThreshold(parseFloat(e.target.value))
626-
}}
627-
style={{
628-
flexGrow: 1,
629-
accentColor: "var(--vscode-button-background)",
630-
height: "2px",
631-
}}
632-
/>
633-
<span style={{ minWidth: "35px", textAlign: "left" }}>
634-
{Math.round((fuzzyMatchThreshold || 1) * 100)}%
635-
</span>
626+
<div
627+
style={{ display: "flex", flexDirection: "column", gap: "5px", marginTop: "15px" }}>
628+
<span style={{ fontWeight: "500" }}>Match precision</span>
629+
<div style={{ display: "flex", alignItems: "center", gap: "5px" }}>
630+
<input
631+
type="range"
632+
min="0.8"
633+
max="1"
634+
step="0.005"
635+
value={fuzzyMatchThreshold ?? 1.0}
636+
onChange={(e) => {
637+
setFuzzyMatchThreshold(parseFloat(e.target.value))
638+
}}
639+
style={{
640+
...sliderStyle,
641+
}}
642+
/>
643+
<span style={{ ...sliderLabelStyle }}>
644+
{Math.round((fuzzyMatchThreshold || 1) * 100)}%
645+
</span>
646+
</div>
636647
</div>
637648
<p
638649
style={{

0 commit comments

Comments
 (0)