fix: add input validation for codebaseIndexEmbedderModelDimension and fix test expectations

- Added validation in config-manager.ts to ensure codebaseIndexEmbedderModelDimension is a valid positive number
- Fixed error message formatting in service-factory.ts to include bold/underline formatting for 'OpenAI-Compatible'
- Updated tests to use config.modelDimension instead of openAiCompatibleOptions.modelDimension
- Added check for vectorSize <= 0 in addition to undefined check

Author: daniel-lxs

src/services/code-index/__tests__/service-factory.spec.ts

@@ -406,8 +406,10 @@ describe("CodeIndexServiceFactory", () => {
 			const testConfig = {
 				embedderProvider: "openai-compatible",
 				modelId: testModelId,
+				modelDimension: manualDimension,
 				openAiCompatibleOptions: {
-					modelDimension: manualDimension,
+					baseUrl: "https://api.example.com/v1",
+					apiKey: "test-api-key",
 				},
 				qdrantUrl: "http://localhost:6333",
 				qdrantApiKey: "test-key",
@@ -463,8 +465,10 @@ describe("CodeIndexServiceFactory", () => {
 			const testConfig = {
 				embedderProvider: "openai-compatible",
 				modelId: testModelId,
+				modelDimension: 0, // Invalid dimension
 				openAiCompatibleOptions: {
-					modelDimension: 0, // Invalid dimension
+					baseUrl: "https://api.example.com/v1",
+					apiKey: "test-api-key",
 				},
 				qdrantUrl: "http://localhost:6333",
 				qdrantApiKey: "test-key",
@@ -474,7 +478,7 @@ describe("CodeIndexServiceFactory", () => {
 
 			// Act & Assert
 			expect(() => factory.createVectorStore()).toThrow(
-				"Could not determine vector dimension for model 'custom-model' with provider 'openai-compatible'. Please ensure the 'Embedding Dimension' is correctly set in the OpenAI-Compatible provider settings.",
+				"Could not determine vector dimension for model 'custom-model' with provider 'openai-compatible'. Please ensure the 'Embedding Dimension' is correctly set in the \x1b[1m\x1b[4mOpenAI-Compatible\x1b[0m provider settings.",
 			)
 		})
 
@@ -496,7 +500,7 @@ describe("CodeIndexServiceFactory", () => {
 
 			// Act & Assert
 			expect(() => factory.createVectorStore()).toThrow(
-				"Could not determine vector dimension for model 'unknown-model' with provider 'openai-compatible'. Please ensure the 'Embedding Dimension' is correctly set in the OpenAI-Compatible provider settings.",
+				"Could not determine vector dimension for model 'unknown-model' with provider 'openai-compatible'. Please ensure the 'Embedding Dimension' is correctly set in the \x1b[1m\x1b[4mOpenAI-Compatible\x1b[0m provider settings.",
 			)
 		})
 

src/services/code-index/config-manager.ts

@@ -74,7 +74,23 @@ export class CodeIndexConfigManager {
 		this.qdrantApiKey = qdrantApiKey ?? ""
 		this.searchMinScore = codebaseIndexSearchMinScore
 		this.searchMaxResults = codebaseIndexSearchMaxResults
-		this.modelDimension = codebaseIndexConfig.codebaseIndexEmbedderModelDimension as number | undefined
+
+		// Validate and set model dimension
+		const rawDimension = codebaseIndexConfig.codebaseIndexEmbedderModelDimension
+		if (rawDimension !== undefined && rawDimension !== null) {
+			const dimension = Number(rawDimension)
+			if (!isNaN(dimension) && dimension > 0) {
+				this.modelDimension = dimension
+			} else {
+				console.warn(
+					`Invalid codebaseIndexEmbedderModelDimension value: ${rawDimension}. Must be a positive number.`,
+				)
+				this.modelDimension = undefined
+			}
+		} else {
+			this.modelDimension = undefined
+		}
+
 		this.openAiOptions = { openAiNativeApiKey: openAiKey }
 
 		// Set embedder provider with support for openai-compatible

src/services/code-index/service-factory.ts

@@ -107,10 +107,10 @@ export class CodeIndexServiceFactory {
 			vectorSize = getModelDimension(provider, modelId)
 		}
 
-		if (vectorSize === undefined) {
+		if (vectorSize === undefined || vectorSize <= 0) {
 			let errorMessage = `Could not determine vector dimension for model '${modelId}' with provider '${provider}'. `
 			if (provider === "openai-compatible") {
-				errorMessage += `Please ensure the 'Embedding Dimension' is correctly set in the provider settings.`
+				errorMessage += `Please ensure the 'Embedding Dimension' is correctly set in the \x1b[1m\x1b[4mOpenAI-Compatible\x1b[0m provider settings.`
 			} else {
 				errorMessage += `Check model profiles or configuration.`
 			}