PR feedback

Author: mrubens

src/__mocks__/services/ripgrep/index.ts

@@ -43,6 +43,6 @@ export const regexSearchFiles = jest
  * @param maxLength - Optional maximum length (can be undefined)
  * @returns The original line or empty string if undefined
  */
-export const truncateLine = jest.fn().mockImplementation((line: string, maxLength?: number): string => {
+export const truncateLine = jest.fn().mockImplementation((line?: string, maxLength?: number): string => {
 	return line || ""
 })

src/services/glob/list-files.ts

@@ -341,6 +341,13 @@ async function execRipgrep(rgPath: string, args: string[], limit: number): Promi
 		let output = ""
 		let results: string[] = []
 
+		// Set timeout to avoid hanging
+		const timeoutId = setTimeout(() => {
+			rgProcess.kill()
+			console.warn("ripgrep timed out, returning partial results")
+			resolve(results.slice(0, limit))
+		}, 10_000)
+
 		// Process stdout data as it comes in
 		rgProcess.stdout.on("data", (data) => {
 			output += data.toString()
@@ -349,6 +356,7 @@ async function execRipgrep(rgPath: string, args: string[], limit: number): Promi
 			// Kill the process if we've reached the limit
 			if (results.length >= limit) {
 				rgProcess.kill()
+				clearTimeout(timeoutId) // Clear the timeout when we kill the process due to reaching the limit
 			}
 		})
 
@@ -357,13 +365,6 @@ async function execRipgrep(rgPath: string, args: string[], limit: number): Promi
 			console.error(`ripgrep stderr: ${data}`)
 		})
 
-		// Set timeout to avoid hanging
-		const timeoutId = setTimeout(() => {
-			rgProcess.kill()
-			console.warn("ripgrep timed out, returning partial results")
-			resolve(results.slice(0, limit))
-		}, 10_000)
-
 		// Handle process completion
 		rgProcess.on("close", (code) => {
 			// Clear the timeout to avoid memory leaks