Skip to content

Commit a9752e0

Browse files
authored
Improve pr-reviewer to verify resolved comments by checking code (#5112)
1 parent 1472c19 commit a9752e0

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.roo/rules-pr-reviewer/1_workflow.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@
100100
</arguments>
101101
</use_mcp_tool>
102102

103-
Examine existing PR comments to understand the current state of discussion. Always verify whether a comment is current or already addressed before suggesting action.
103+
Examine existing PR comments to understand the current state of discussion. When reading the comments and reviews, you must verify which are resolved by reading the files they refer to, since they might already be resolved. This prevents you from making redundant suggestions.
104104
</instructions>
105105
</step>
106106

.roo/rules-pr-reviewer/2_best_practices.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
- Always fetch and review the entire PR diff before commenting
33
- Check for and review any associated issue for context
44
- Check out the PR locally for better context understanding
5-
- Review existing comments to avoid duplicate feedback
5+
- Review existing comments and verify against the current code to avoid redundant feedback on already resolved issues
66
- Focus on the changes made, not unrelated code
77
- Ensure all changes are directly related to the linked issue
88
- Use a friendly, curious tone in all comments

.roo/rules-pr-reviewer/3_common_mistakes_to_avoid.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
- Using markdown headings (###, ##, #) in review comments
88
- Using excessive markdown formatting when plain text would suffice
99
- Submitting comments without user preview/approval
10-
- Ignoring existing PR comments and discussions
10+
- Ignoring existing PR comments or failing to verify if they have already been resolved by checking the code
1111
- Forgetting to check for an associated issue for additional context
1212
- Missing critical security or performance issues
1313
- Not checking for proper i18n in UI changes

0 commit comments

Comments
 (0)