Skip to content

Commit aa54516

Browse files
committed
fix: convert inline styles to Tailwind classes and expand i18n error titles
- Converted inline style objects to Tailwind classes in ChatRow.tsx for subtask_result, newTask, and finishTask sections - Added more common error titles to i18n tools.json for better centralization - Maintains consistency with project guidelines for using Tailwind CSS
1 parent 95913bd commit aa54516

File tree

2 files changed

+20
-71
lines changed

2 files changed

+20
-71
lines changed

src/i18n/locales/en/tools.json

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,16 @@
2525
"operationFailed": "Operation Failed",
2626
"resourceNotFound": "Resource Not Found",
2727
"configurationError": "Configuration Error",
28-
"authenticationFailed": "Authentication Failed"
28+
"authenticationFailed": "Authentication Failed",
29+
"invalidLineNumber": "Invalid Line Number",
30+
"fileAlreadyExists": "File Already Exists",
31+
"directoryNotFound": "Directory Not Found",
32+
"invalidPath": "Invalid Path",
33+
"readError": "Read Error",
34+
"writeError": "Write Error",
35+
"syntaxError": "Syntax Error",
36+
"validationError": "Validation Error",
37+
"timeoutError": "Timeout Error",
38+
"connectionError": "Connection Error"
2939
}
3040
}

webview-ui/src/components/chat/ChatRow.tsx

Lines changed: 9 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -768,31 +768,12 @@ export const ChatRowContent = ({
768768
/>
769769
</span>
770770
</div>
771-
<div
772-
style={{
773-
marginTop: "4px",
774-
backgroundColor: "var(--vscode-badge-background)",
775-
border: "1px solid var(--vscode-badge-background)",
776-
borderRadius: "4px 4px 0 0",
777-
overflow: "hidden",
778-
marginBottom: "2px",
779-
}}>
780-
<div
781-
style={{
782-
padding: "9px 10px 9px 14px",
783-
backgroundColor: "var(--vscode-badge-background)",
784-
borderBottom: "1px solid var(--vscode-editorGroup-border)",
785-
fontWeight: "bold",
786-
fontSize: "var(--vscode-font-size)",
787-
color: "var(--vscode-badge-foreground)",
788-
display: "flex",
789-
alignItems: "center",
790-
gap: "6px",
791-
}}>
771+
<div className="mt-1 bg-vscode-badge-background border border-vscode-badge-background rounded-t overflow-hidden mb-0.5">
772+
<div className="py-[9px] px-[10px] pl-[14px] bg-vscode-badge-background border-b border-vscode-editorGroup-border font-bold text-[length:var(--vscode-font-size)] text-vscode-badge-foreground flex items-center gap-1.5">
792773
<span className="codicon codicon-arrow-right"></span>
793774
{t("chat:subtasks.newTaskContent")}
794775
</div>
795-
<div style={{ padding: "12px 16px", backgroundColor: "var(--vscode-editor-background)" }}>
776+
<div className="p-3 px-4 bg-vscode-editor-background">
796777
<MarkdownBlock markdown={tool.content} />
797778
</div>
798779
</div>
@@ -805,31 +786,12 @@ export const ChatRowContent = ({
805786
{toolIcon("check-all")}
806787
<span style={{ fontWeight: "bold" }}>{t("chat:subtasks.wantsToFinish")}</span>
807788
</div>
808-
<div
809-
style={{
810-
marginTop: "4px",
811-
backgroundColor: "var(--vscode-editor-background)",
812-
border: "1px solid var(--vscode-badge-background)",
813-
borderRadius: "4px",
814-
overflow: "hidden",
815-
marginBottom: "8px",
816-
}}>
817-
<div
818-
style={{
819-
padding: "9px 10px 9px 14px",
820-
backgroundColor: "var(--vscode-badge-background)",
821-
borderBottom: "1px solid var(--vscode-editorGroup-border)",
822-
fontWeight: "bold",
823-
fontSize: "var(--vscode-font-size)",
824-
color: "var(--vscode-badge-foreground)",
825-
display: "flex",
826-
alignItems: "center",
827-
gap: "6px",
828-
}}>
789+
<div className="mt-1 bg-vscode-editor-background border border-vscode-badge-background rounded overflow-hidden mb-2">
790+
<div className="py-[9px] px-[10px] pl-[14px] bg-vscode-badge-background border-b border-vscode-editorGroup-border font-bold text-[length:var(--vscode-font-size)] text-vscode-badge-foreground flex items-center gap-1.5">
829791
<span className="codicon codicon-check"></span>
830792
{t("chat:subtasks.completionContent")}
831793
</div>
832-
<div style={{ padding: "12px 16px", backgroundColor: "var(--vscode-editor-background)" }}>
794+
<div className="p-3 px-4 bg-vscode-editor-background">
833795
<MarkdownBlock markdown={t("chat:subtasks.completionInstructions")} />
834796
</div>
835797
</div>
@@ -856,35 +818,12 @@ export const ChatRowContent = ({
856818
case "subtask_result":
857819
return (
858820
<div>
859-
<div
860-
style={{
861-
marginTop: "0px",
862-
backgroundColor: "var(--vscode-badge-background)",
863-
border: "1px solid var(--vscode-badge-background)",
864-
borderRadius: "0 0 4px 4px",
865-
overflow: "hidden",
866-
marginBottom: "8px",
867-
}}>
868-
<div
869-
style={{
870-
padding: "9px 10px 9px 14px",
871-
backgroundColor: "var(--vscode-badge-background)",
872-
borderBottom: "1px solid var(--vscode-editorGroup-border)",
873-
fontWeight: "bold",
874-
fontSize: "var(--vscode-font-size)",
875-
color: "var(--vscode-badge-foreground)",
876-
display: "flex",
877-
alignItems: "center",
878-
gap: "6px",
879-
}}>
821+
<div className="mt-0 bg-vscode-badge-background border border-vscode-badge-background rounded-b overflow-hidden mb-2">
822+
<div className="py-[9px] px-[10px] pl-[14px] bg-vscode-badge-background border-b border-vscode-editorGroup-border font-bold text-[length:var(--vscode-font-size)] text-vscode-badge-foreground flex items-center gap-1.5">
880823
<span className="codicon codicon-arrow-left"></span>
881824
{t("chat:subtasks.resultContent")}
882825
</div>
883-
<div
884-
style={{
885-
padding: "12px 16px",
886-
backgroundColor: "var(--vscode-editor-background)",
887-
}}>
826+
<div className="p-3 px-4 bg-vscode-editor-background">
888827
<MarkdownBlock markdown={message.text} />
889828
</div>
890829
</div>

0 commit comments

Comments
 (0)