refactor: consolidate validation logic into Zod schema

- Remove redundant manual validation checks (lines 375-425)
- Simplify validateSettings() to rely solely on Zod schema
- Handle SECRET_PLACEHOLDER values as valid (backend secrets exist)
- Reduce code by ~80 lines while maintaining same functionality
- Single source of truth for validation rules

Author: daniel-lxs

webview-ui/src/components/chat/CodeIndexPopover.tsx

@@ -334,93 +334,27 @@ export const CodeIndexPopover: React.FC<CodeIndexPopoverProps> = ({
 	const validateSettings = (): boolean => {
 		const schema = createValidationSchema(currentSettings.codebaseIndexEmbedderProvider, t)
 
-		// Prepare data for validation, excluding placeholder values
+		// Prepare data for validation
 		const dataToValidate: any = {}
 		for (const [key, value] of Object.entries(currentSettings)) {
-			// Skip secret fields that still have placeholder value
+			// For secret fields with placeholder values, treat them as valid (they exist in backend)
 			if (value === SECRET_PLACEHOLDER) {
-				continue
-			}
-			dataToValidate[key] = value
-		}
-
-		try {
-			// Create a partial schema that only validates fields that are present
-			const partialSchema = schema.partial()
-
-			// For required fields that have placeholder values, we need to check if they exist in the backend
-			const requiredFieldsWithPlaceholder: Record<string, boolean> = {}
-
-			// Check which secret fields have placeholder values but should be considered valid
-			if (currentSettings.codeIndexOpenAiKey === SECRET_PLACEHOLDER) {
-				requiredFieldsWithPlaceholder.codeIndexOpenAiKey = true
-			}
-			if (currentSettings.codebaseIndexOpenAiCompatibleApiKey === SECRET_PLACEHOLDER) {
-				requiredFieldsWithPlaceholder.codebaseIndexOpenAiCompatibleApiKey = true
-			}
-			if (currentSettings.codebaseIndexGeminiApiKey === SECRET_PLACEHOLDER) {
-				requiredFieldsWithPlaceholder.codebaseIndexGeminiApiKey = true
-			}
-
-			// Validate the data we have
-			partialSchema.parse(dataToValidate)
-
-			// Additional validation for required fields based on provider
-			const provider = currentSettings.codebaseIndexEmbedderProvider
-			const errors: Record<string, string> = {}
-
-			// Check provider-specific required fields
-			if (provider === "openai") {
-				if (!dataToValidate.codeIndexOpenAiKey && !requiredFieldsWithPlaceholder.codeIndexOpenAiKey) {
-					errors.codeIndexOpenAiKey = t("settings:codeIndex.validation.openaiApiKeyRequired")
-				}
-				if (!dataToValidate.codebaseIndexEmbedderModelId) {
-					errors.codebaseIndexEmbedderModelId = t("settings:codeIndex.validation.modelSelectionRequired")
-				}
-			} else if (provider === "ollama") {
-				if (!dataToValidate.codebaseIndexEmbedderBaseUrl) {
-					errors.codebaseIndexEmbedderBaseUrl = t("settings:codeIndex.validation.ollamaBaseUrlRequired")
-				}
-				if (!dataToValidate.codebaseIndexEmbedderModelId) {
-					errors.codebaseIndexEmbedderModelId = t("settings:codeIndex.validation.modelIdRequired")
-				}
-			} else if (provider === "openai-compatible") {
-				if (
-					!dataToValidate.codebaseIndexOpenAiCompatibleApiKey &&
-					!requiredFieldsWithPlaceholder.codebaseIndexOpenAiCompatibleApiKey
-				) {
-					errors.codebaseIndexOpenAiCompatibleApiKey = t("settings:codeIndex.validation.apiKeyRequired")
-				}
-				if (!dataToValidate.codebaseIndexEmbedderModelId) {
-					errors.codebaseIndexEmbedderModelId = t("settings:codeIndex.validation.modelIdRequired")
-				}
-				if (!dataToValidate.codebaseIndexEmbedderModelDimension) {
-					errors.codebaseIndexEmbedderModelDimension = t(
-						"settings:codeIndex.validation.modelDimensionRequired",
-					)
-				}
-			} else if (provider === "gemini") {
+				// Add a dummy value that will pass validation for these fields
 				if (
-					!dataToValidate.codebaseIndexGeminiApiKey &&
-					!requiredFieldsWithPlaceholder.codebaseIndexGeminiApiKey
+					key === "codeIndexOpenAiKey" ||
+					key === "codebaseIndexOpenAiCompatibleApiKey" ||
+					key === "codebaseIndexGeminiApiKey"
 				) {
-					errors.codebaseIndexGeminiApiKey = t("settings:codeIndex.validation.geminiApiKeyRequired")
-				}
-				if (!dataToValidate.codebaseIndexEmbedderModelId) {
-					errors.codebaseIndexEmbedderModelId = t("settings:codeIndex.validation.modelSelectionRequired")
+					dataToValidate[key] = "placeholder-valid"
 				}
+			} else {
+				dataToValidate[key] = value
 			}
+		}
 
-			// Always check base required fields
-			if (!dataToValidate.codebaseIndexQdrantUrl) {
-				errors.codebaseIndexQdrantUrl = t("settings:codeIndex.validation.qdrantUrlRequired")
-			}
-
-			if (Object.keys(errors).length > 0) {
-				setFormErrors(errors)
-				return false
-			}
-
+		try {
+			// Validate using the schema
+			schema.parse(dataToValidate)
 			setFormErrors({})
 			return true
 		} catch (error) {