revert mcp changes

Author: seedlord

src/services/mcp/McpHub.ts

@@ -960,26 +960,20 @@ export class McpHub {
 
 			// Update the connection object
 			if (connection) {
-				const wasDisabled = connection.server.disabled
-				connection.server.disabled = disabled
-
-				// When the server is activated, reload the configuration
-				if (wasDisabled && !disabled) {
-					await this.initializeMcpServers(serverSource)
-				}
+				try {
+					connection.server.disabled = disabled
 
-				// Only refresh capabilities if connected
-				if (connection.server.status === "connected") {
-					try {
+					// Only refresh capabilities if connected
+					if (connection.server.status === "connected") {
 						connection.server.tools = await this.fetchToolsList(serverName, serverSource)
 						connection.server.resources = await this.fetchResourcesList(serverName, serverSource)
 						connection.server.resourceTemplates = await this.fetchResourceTemplatesList(
 							serverName,
 							serverSource,
 						)
-					} catch (error) {
-						console.error(`Failed to refresh capabilities for ${serverName}:`, error)
 					}
+				} catch (error) {
+					console.error(`Failed to refresh capabilities for ${serverName}:`, error)
 				}
 			}
 
@@ -1312,33 +1306,4 @@ export class McpHub {
 		}
 		this.disposables.forEach((d) => d.dispose())
 	}
-
-	/**
-	 * Enables or disables all global MCP servers at once.
-	 * When activated, the configuration is reloaded.
-	 * @param disabled true = disable all, false = enable all
-	 */
-	public async toggleAllServersDisabled(disabled: boolean): Promise<void> {
-		// Collect all global server names
-		const globalConnections = this.connections.filter(
-			(conn) => conn.server.source === "global" || !conn.server.source,
-		)
-		const serverNames = globalConnections.map((conn) => conn.server.name)
-
-		// Set the Disabled flag for all servers
-		for (const name of serverNames) {
-			await this.updateServerConfig(name, { disabled }, "global")
-			const conn = this.findConnection(name, "global")
-			if (conn) {
-				conn.server.disabled = disabled
-			}
-		}
-
-		// If activated, reload configuration
-		if (!disabled) {
-			await this.initializeMcpServers("global")
-		}
-
-		await this.notifyWebviewOfServerChanges()
-	}
 }

src/services/mcp/__tests__/McpHub.test.ts

@@ -560,77 +560,5 @@ describe("McpHub", () => {
 				)
 			})
 		})
-		describe("toggleServerDisabled (Configuration reload)", () => {
-			it("should reload configuration when enabling a server (calls initializeMcpServers)", async () => {
-				const mockConfig: any = {
-					mcpServers: {
-						"test-server": {
-							type: "stdio",
-							command: "node",
-							args: ["test.js"],
-							disabled: true,
-						},
-					},
-				}
-
-				;(fs.readFile as jest.Mock).mockResolvedValueOnce(JSON.stringify(mockConfig))
-
-				mcpHub.connections = [
-					{
-						server: {
-							name: "test-server",
-							config: JSON.stringify(mockConfig.mcpServers["test-server"]),
-							status: "connected",
-							disabled: true,
-						},
-						client: { request: jest.fn() },
-						transport: { close: jest.fn() },
-					} as any,
-				]
-
-				const spy = jest.spyOn(mcpHub as any, "initializeMcpServers").mockResolvedValue(undefined)
-
-				await mcpHub.toggleServerDisabled("test-server", false)
-				// Expectation: initializeMcpServers was called
-				expect(spy).toHaveBeenCalledWith("global")
-				spy.mockRestore()
-			})
-		})
-		describe("toggleAllServersDisabled (global enable/disable)", () => {
-			it("should reload configuration when globally enabling all servers (calls initializeMcpServers)", async () => {
-				// Two global servers, both disabled
-				mcpHub.connections = [
-					{
-						server: {
-							name: "server1",
-							config: JSON.stringify({ type: "stdio", command: "node", args: ["a.js"], disabled: true }),
-							status: "disconnected",
-							disabled: true,
-							source: "global",
-						},
-						client: { request: jest.fn() },
-						transport: { close: jest.fn() },
-					} as any,
-					{
-						server: {
-							name: "server2",
-							config: JSON.stringify({ type: "stdio", command: "node", args: ["b.js"], disabled: true }),
-							status: "disconnected",
-							disabled: true,
-							source: "global",
-						},
-						client: { request: jest.fn() },
-						transport: { close: jest.fn() },
-					} as any,
-				]
-
-				const spy = jest.spyOn(mcpHub as any, "initializeMcpServers").mockResolvedValue(undefined)
-
-				await mcpHub.toggleAllServersDisabled(false) // activate global
-
-				expect(spy).toHaveBeenCalledWith("global")
-				spy.mockRestore()
-			})
-		})
 	})
 })