Skip to content

Commit ada601d

Browse files
committed
fix: convert inline styles to Tailwind classes and expand i18n error titles
- Converted inline style objects to Tailwind classes in ChatRow.tsx for subtask_result, newTask, and finishTask sections - Added more common error titles to i18n tools.json for better centralization - Maintains consistency with project guidelines for using Tailwind CSS
1 parent 9cad0f8 commit ada601d

File tree

2 files changed

+20
-71
lines changed

2 files changed

+20
-71
lines changed

src/i18n/locales/en/tools.json

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,16 @@
2525
"operationFailed": "Operation Failed",
2626
"resourceNotFound": "Resource Not Found",
2727
"configurationError": "Configuration Error",
28-
"authenticationFailed": "Authentication Failed"
28+
"authenticationFailed": "Authentication Failed",
29+
"invalidLineNumber": "Invalid Line Number",
30+
"fileAlreadyExists": "File Already Exists",
31+
"directoryNotFound": "Directory Not Found",
32+
"invalidPath": "Invalid Path",
33+
"readError": "Read Error",
34+
"writeError": "Write Error",
35+
"syntaxError": "Syntax Error",
36+
"validationError": "Validation Error",
37+
"timeoutError": "Timeout Error",
38+
"connectionError": "Connection Error"
2939
}
3040
}

webview-ui/src/components/chat/ChatRow.tsx

Lines changed: 9 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -714,31 +714,12 @@ export const ChatRowContent = ({
714714
/>
715715
</span>
716716
</div>
717-
<div
718-
style={{
719-
marginTop: "4px",
720-
backgroundColor: "var(--vscode-badge-background)",
721-
border: "1px solid var(--vscode-badge-background)",
722-
borderRadius: "4px 4px 0 0",
723-
overflow: "hidden",
724-
marginBottom: "2px",
725-
}}>
726-
<div
727-
style={{
728-
padding: "9px 10px 9px 14px",
729-
backgroundColor: "var(--vscode-badge-background)",
730-
borderBottom: "1px solid var(--vscode-editorGroup-border)",
731-
fontWeight: "bold",
732-
fontSize: "var(--vscode-font-size)",
733-
color: "var(--vscode-badge-foreground)",
734-
display: "flex",
735-
alignItems: "center",
736-
gap: "6px",
737-
}}>
717+
<div className="mt-1 bg-vscode-badge-background border border-vscode-badge-background rounded-t overflow-hidden mb-0.5">
718+
<div className="py-[9px] px-[10px] pl-[14px] bg-vscode-badge-background border-b border-vscode-editorGroup-border font-bold text-[length:var(--vscode-font-size)] text-vscode-badge-foreground flex items-center gap-1.5">
738719
<span className="codicon codicon-arrow-right"></span>
739720
{t("chat:subtasks.newTaskContent")}
740721
</div>
741-
<div style={{ padding: "12px 16px", backgroundColor: "var(--vscode-editor-background)" }}>
722+
<div className="p-3 px-4 bg-vscode-editor-background">
742723
<MarkdownBlock markdown={tool.content} />
743724
</div>
744725
</div>
@@ -751,31 +732,12 @@ export const ChatRowContent = ({
751732
{toolIcon("check-all")}
752733
<span style={{ fontWeight: "bold" }}>{t("chat:subtasks.wantsToFinish")}</span>
753734
</div>
754-
<div
755-
style={{
756-
marginTop: "4px",
757-
backgroundColor: "var(--vscode-editor-background)",
758-
border: "1px solid var(--vscode-badge-background)",
759-
borderRadius: "4px",
760-
overflow: "hidden",
761-
marginBottom: "8px",
762-
}}>
763-
<div
764-
style={{
765-
padding: "9px 10px 9px 14px",
766-
backgroundColor: "var(--vscode-badge-background)",
767-
borderBottom: "1px solid var(--vscode-editorGroup-border)",
768-
fontWeight: "bold",
769-
fontSize: "var(--vscode-font-size)",
770-
color: "var(--vscode-badge-foreground)",
771-
display: "flex",
772-
alignItems: "center",
773-
gap: "6px",
774-
}}>
735+
<div className="mt-1 bg-vscode-editor-background border border-vscode-badge-background rounded overflow-hidden mb-2">
736+
<div className="py-[9px] px-[10px] pl-[14px] bg-vscode-badge-background border-b border-vscode-editorGroup-border font-bold text-[length:var(--vscode-font-size)] text-vscode-badge-foreground flex items-center gap-1.5">
775737
<span className="codicon codicon-check"></span>
776738
{t("chat:subtasks.completionContent")}
777739
</div>
778-
<div style={{ padding: "12px 16px", backgroundColor: "var(--vscode-editor-background)" }}>
740+
<div className="p-3 px-4 bg-vscode-editor-background">
779741
<MarkdownBlock markdown={t("chat:subtasks.completionInstructions")} />
780742
</div>
781743
</div>
@@ -904,35 +866,12 @@ export const ChatRowContent = ({
904866
case "subtask_result":
905867
return (
906868
<div>
907-
<div
908-
style={{
909-
marginTop: "0px",
910-
backgroundColor: "var(--vscode-badge-background)",
911-
border: "1px solid var(--vscode-badge-background)",
912-
borderRadius: "0 0 4px 4px",
913-
overflow: "hidden",
914-
marginBottom: "8px",
915-
}}>
916-
<div
917-
style={{
918-
padding: "9px 10px 9px 14px",
919-
backgroundColor: "var(--vscode-badge-background)",
920-
borderBottom: "1px solid var(--vscode-editorGroup-border)",
921-
fontWeight: "bold",
922-
fontSize: "var(--vscode-font-size)",
923-
color: "var(--vscode-badge-foreground)",
924-
display: "flex",
925-
alignItems: "center",
926-
gap: "6px",
927-
}}>
869+
<div className="mt-0 bg-vscode-badge-background border border-vscode-badge-background rounded-b overflow-hidden mb-2">
870+
<div className="py-[9px] px-[10px] pl-[14px] bg-vscode-badge-background border-b border-vscode-editorGroup-border font-bold text-[length:var(--vscode-font-size)] text-vscode-badge-foreground flex items-center gap-1.5">
928871
<span className="codicon codicon-arrow-left"></span>
929872
{t("chat:subtasks.resultContent")}
930873
</div>
931-
<div
932-
style={{
933-
padding: "12px 16px",
934-
backgroundColor: "var(--vscode-editor-background)",
935-
}}>
874+
<div className="p-3 px-4 bg-vscode-editor-background">
936875
<MarkdownBlock markdown={message.text} />
937876
</div>
938877
</div>

0 commit comments

Comments
 (0)