webview-ui: remove redundant CDATA replacements; improve unified diff header detection; reuse extractUnifiedDiff for new-file rendering

Author: hannesrudolph

webview-ui/src/components/chat/ChatRow.tsx

@@ -175,24 +175,6 @@ function computeDiffStats(diff?: string): { added: number; removed: number } | n
 	return null
 }
 
-/**
- * Converts new file content to unified diff format (all lines as additions)
- */
-function convertNewFileToUnifiedDiff(content: string, filePath?: string): string {
-	const fileName = filePath || "file"
-	const lines = content.split("\n")
-
-	let diff = `--- /dev/null\n`
-	diff += `+++ ${fileName}\n`
-	diff += `@@ -0,0 +1,${lines.length} @@\n`
-
-	for (const line of lines) {
-		diff += `+${line}\n`
-	}
-
-	return diff
-}
-
 export const ChatRowContent = ({
 	message,
 	lastModifiedMessage,
@@ -638,7 +620,7 @@ export const ChatRowContent = ({
 						<div className="pl-6">
 							<CodeAccordian
 								path={tool.path}
-								code={convertNewFileToUnifiedDiff(tool.content || "", tool.path)}
+								code={cleanDiffContent ?? ""}
 								language="diff"
 								isLoading={message.partial}
 								isExpanded={isExpanded}

webview-ui/src/utils/diffUtils.ts

@@ -40,7 +40,7 @@ export function extractUnifiedDiff(params: {
 /** Detects unified diff by presence of headers/hunks */
 function isUnifiedDiff(s: string): boolean {
 	const hasHunk = /(^|\n)@@\s+-[0-9,]+\s+\+[0-9,]+\s+@@/.test(s)
-	const hasHeaders = /(^|\n)---\s|\n\+\+\+\s/.test(s)
+	const hasHeaders = /(^|\n)---\s|(^|\n)\+\+\+\s/.test(s)
 	return hasHunk || hasHeaders
 }
 
@@ -55,12 +55,9 @@ function isSearchReplace(s: string): boolean {
 function stripCData(s: string): string {
 	return (
 		s
-			// Remove HTML-encoded and raw CDATA open
+			// Remove HTML-encoded and raw CDATA open/close (case-insensitive covers both)
 			.replace(/<!\[CDATA\[/gi, "")
-			.replace(/<!\[CDATA\[/g, "")
-			// Remove HTML-encoded and raw CDATA close
 			.replace(/\]\]>/gi, "")
-			.replace(/\]\]>/g, "")
 	)
 }