fix: show user-friendly error message for XML parsing failures

daniel-lxs · daniel-lxs · commit afa777e455ba · 2025-07-04T08:31:42.000-05:00
- Keep detailed XML structure instructions only for LLM via pushToolResult
- Show simple error message to user via cline.say
- Aligns with established error handling pattern in codebase
diff --git a/src/core/tools/multiApplyDiffTool.ts b/src/core/tools/multiApplyDiffTool.ts
@@ -161,7 +161,7 @@ Expected structure:
 Original error: ${errorMessage}`
 			cline.consecutiveMistakeCount++
 			cline.recordToolError("apply_diff")
-			await cline.say("diff_error", detailedError)
+			await cline.say("diff_error", `Failed to parse apply_diff XML: ${errorMessage}`)
 			pushToolResult(detailedError)
 			return
 		}

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ Expected structure:`
`161`	`161`	Original error: ${errorMessage}`
`162`	`162`	`cline.consecutiveMistakeCount++`
`163`	`163`	`cline.recordToolError("apply_diff")`
`164`		`- await cline.say("diff_error", detailedError)`
	`164`	+ await cline.say("diff_error", `Failed to parse apply_diff XML: ${errorMessage}`)
`165`	`165`	`pushToolResult(detailedError)`
`166`	`166`	`return`
`167`	`167`	`}`