fix: revert unrelated test changes while preserving Go diagnostics functionality

- Reverted massive test data expansion in ClineProvider.spec.ts that added
  unrelated properties like terminal settings, API configs, and UI settings
- Kept only the essential diagnosticsEnabled property for Go diagnostics feature
- Restored original test structure and property organization
- Reverted unrelated comment change in writeToFileTool.spec.ts
- Preserved all core Go diagnostics functionality in other files

This focuses the PR on its intended purpose: adding configurable diagnostic
delay settings for Go development without unnecessary test complexity.

Author: roomote

.roo/temp/pr-5863/analysis.md

@@ -0,0 +1,50 @@
+# PR #5863 Analysis: Unrelated Changes in ClineProvider.spec.ts
+
+## Overview
+PR #5863 is intended to add configurable diagnostic delay settings for Go diagnostics. However, the changes to `src/core/webview/__tests__/ClineProvider.spec.ts` contain significant unrelated modifications that should be reverted.
+
+## Intended Changes (Related to Go Diagnostics)
+The PR should only add:
+1. `diagnosticsEnabled` setting support
+2. `DEFAULT_WRITE_DELAY_MS` constant usage
+3. Basic test updates to support the new diagnostic settings
+
+## Unrelated Changes Found in ClineProvider.spec.ts
+
+### 1. Massive Test Data Expansion (Lines 501-582)
+**UNRELATED**: The test adds extensive mock state properties that are not related to diagnostics:
+- `alwaysAllowWriteProtected`, `alwaysAllowModeSwitch`, `alwaysAllowSubtasks`, `alwaysAllowUpdateTodoList`
+- `allowedCommands`, `deniedCommands`, `allowedMaxRequests`
+- `soundVolume`, `ttsSpeed`, `screenshotQuality`
+- `maxReadFileLine`, `maxConcurrentFileReads`
+- Multiple terminal-related settings
+- `language`, `currentApiConfigName`, `listApiConfigMeta`, `pinnedApiConfigs`
+- `autoApprovalEnabled`, `alwaysApproveResubmit`
+- `customModePrompts`, `customSupportPrompts`, `modeApiConfigs`
+- `enhancementApiConfigId`, `condensingApiConfigId`, `customCondensingPrompt`
+- `codebaseIndexModels`
+
+### 2. Property Reorganization (Lines 501-582)
+**UNRELATED**: The test reorganizes existing properties and moves `codebaseIndexConfig` from its original position to the end, which is not related to diagnostics functionality.
+
+### 3. Comment Changes (Line 384 in writeToFileTool.spec.ts)
+**UNRELATED**: Minor comment change from "Manually set the property..." to "Set the userEdits property..." is not related to diagnostics.
+
+## Related Changes (Should be Kept)
+1. Import of `DEFAULT_WRITE_DELAY_MS` (line 17)
+2. Addition of `diagnosticsEnabled: true` in the mock state (line 549)
+3. Basic test structure updates to support diagnostic settings
+
+## Recommended Actions
+1. Revert the massive test data expansion in lines 501-582
+2. Keep only the minimal changes needed for diagnostics support:
+   - Import `DEFAULT_WRITE_DELAY_MS`
+   - Add `diagnosticsEnabled: true` to existing mock state
+   - Keep existing property order and structure
+3. Revert the unrelated comment change in writeToFileTool.spec.ts
+4. Preserve the core Go diagnostics functionality changes in other files
+
+## Impact Assessment
+- **Risk**: High - The unrelated changes significantly expand test complexity and add properties unrelated to the PR's purpose
+- **Maintenance**: These changes make the test harder to maintain and understand
+- **Focus**: The changes dilute the PR's focus on Go diagnostics improvements