Skip to content

Commit b9e2fd1

Browse files
authored
Revert "fix: sanitize reasoning_details IDs to remove invalid characters" (#9846)
1 parent c719117 commit b9e2fd1

File tree

4 files changed

+8
-85
lines changed

4 files changed

+8
-85
lines changed

src/api/providers/openrouter.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import { BaseProvider } from "./base-provider"
2929
import type { ApiHandlerCreateMessageMetadata, SingleCompletionHandler } from "../index"
3030
import { handleOpenAIError } from "./utils/openai-error-handler"
3131
import { generateImageWithProvider, ImageGenerationResult } from "./utils/image-generation"
32-
import { sanitizeReasoningDetailId } from "./utils/sanitize-reasoning-id"
3332

3433
// Add custom interface for OpenRouter params.
3534
type OpenRouterChatCompletionParams = OpenAI.Chat.ChatCompletionCreateParams & {
@@ -287,18 +286,18 @@ export class OpenRouterHandler extends BaseProvider implements SingleCompletionH
287286
if (detail.data !== undefined) {
288287
existing.data = (existing.data || "") + detail.data
289288
}
290-
// Update other fields if provided - sanitize ID to remove invalid characters
291-
if (detail.id !== undefined) existing.id = sanitizeReasoningDetailId(detail.id)
289+
// Update other fields if provided
290+
if (detail.id !== undefined) existing.id = detail.id
292291
if (detail.format !== undefined) existing.format = detail.format
293292
if (detail.signature !== undefined) existing.signature = detail.signature
294293
} else {
295-
// Start new reasoning detail accumulation - sanitize ID to remove invalid characters
294+
// Start new reasoning detail accumulation
296295
reasoningDetailsAccumulator.set(key, {
297296
type: detail.type,
298297
text: detail.text,
299298
summary: detail.summary,
300299
data: detail.data,
301-
id: sanitizeReasoningDetailId(detail.id),
300+
id: detail.id,
302301
format: detail.format,
303302
signature: detail.signature,
304303
index,

src/api/providers/roo.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import { MODEL_DEFAULTS } from "../providers/fetchers/roo"
1919
import { handleOpenAIError } from "./utils/openai-error-handler"
2020
import { generateImageWithProvider, generateImageWithImagesApi, ImageGenerationResult } from "./utils/image-generation"
2121
import { t } from "../../i18n"
22-
import { sanitizeReasoningDetailId } from "./utils/sanitize-reasoning-id"
2322

2423
// Extend OpenAI's CompletionUsage to include Roo specific fields
2524
interface RooUsage extends OpenAI.CompletionUsage {
@@ -194,18 +193,18 @@ export class RooHandler extends BaseOpenAiCompatibleProvider<string> {
194193
if (detail.data !== undefined) {
195194
existing.data = (existing.data || "") + detail.data
196195
}
197-
// Update other fields if provided - sanitize ID to remove invalid characters
198-
if (detail.id !== undefined) existing.id = sanitizeReasoningDetailId(detail.id)
196+
// Update other fields if provided
197+
if (detail.id !== undefined) existing.id = detail.id
199198
if (detail.format !== undefined) existing.format = detail.format
200199
if (detail.signature !== undefined) existing.signature = detail.signature
201200
} else {
202-
// Start new reasoning detail accumulation - sanitize ID to remove invalid characters
201+
// Start new reasoning detail accumulation
203202
reasoningDetailsAccumulator.set(key, {
204203
type: detail.type,
205204
text: detail.text,
206205
summary: detail.summary,
207206
data: detail.data,
208-
id: sanitizeReasoningDetailId(detail.id),
207+
id: detail.id,
209208
format: detail.format,
210209
signature: detail.signature,
211210
index,

src/api/providers/utils/__tests__/sanitize-reasoning-id.spec.ts

Lines changed: 0 additions & 59 deletions
This file was deleted.

src/api/providers/utils/sanitize-reasoning-id.ts

Lines changed: 0 additions & 16 deletions
This file was deleted.

0 commit comments

Comments
 (0)