Skip to content

Commit bbd77f2

Browse files
committed
fix: add allowAttemptCompletion to AutoApproveSettings types and test
1 parent 19dfac6 commit bbd77f2

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

webview-ui/src/components/settings/AutoApproveSettings.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ type AutoApproveSettingsProps = HTMLAttributes<HTMLDivElement> & {
3030
alwaysAllowExecute?: boolean
3131
alwaysAllowFollowupQuestions?: boolean
3232
alwaysAllowUpdateTodoList?: boolean
33+
allowAttemptCompletion?: boolean
3334
followupAutoApproveTimeoutMs?: number
3435
allowedCommands?: string[]
3536
allowedMaxRequests?: number | undefined
@@ -55,6 +56,7 @@ type AutoApproveSettingsProps = HTMLAttributes<HTMLDivElement> & {
5556
| "allowedMaxCost"
5657
| "deniedCommands"
5758
| "alwaysAllowUpdateTodoList"
59+
| "allowAttemptCompletion"
5860
>
5961
}
6062

@@ -74,6 +76,7 @@ export const AutoApproveSettings = ({
7476
alwaysAllowFollowupQuestions,
7577
followupAutoApproveTimeoutMs = 60000,
7678
alwaysAllowUpdateTodoList,
79+
allowAttemptCompletion,
7780
allowedCommands,
7881
allowedMaxRequests,
7982
allowedMaxCost,
@@ -166,6 +169,7 @@ export const AutoApproveSettings = ({
166169
alwaysAllowExecute={alwaysAllowExecute}
167170
alwaysAllowFollowupQuestions={alwaysAllowFollowupQuestions}
168171
alwaysAllowUpdateTodoList={alwaysAllowUpdateTodoList}
172+
allowAttemptCompletion={allowAttemptCompletion}
169173
onToggle={(key, value) => setCachedStateField(key, value)}
170174
/>
171175

webview-ui/src/components/settings/__tests__/AutoApproveToggle.spec.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ describe("AutoApproveToggle", () => {
2727
alwaysAllowExecute: true,
2828
alwaysAllowFollowupQuestions: false,
2929
alwaysAllowUpdateTodoList: true,
30+
allowAttemptCompletion: false,
3031
onToggle: mockOnToggle,
3132
}
3233

0 commit comments

Comments
 (0)