feat: move newTaskRequireTodos from experimental to VSCode settings

- Added newTaskRequireTodos as a VSCode configuration property in src/package.json
- Added description in src/package.nls.json
- Updated newTaskTool.ts to read from VSCode configuration instead of experiments
- Removed NEW_TASK_REQUIRE_TODOS from experimental settings in src/shared/experiments.ts
- Removed newTaskRequireTodos from packages/types/src/experiment.ts
- Updated tests to use VSCode configuration mocking instead of experiments
- Removed references from experiments test file
- Maintains backward compatibility (defaults to false)

Author: Merge Resolver

packages/types/src/experiment.ts

@@ -11,7 +11,6 @@ export const experimentIds = [
 	"multiFileApplyDiff",
 	"preventFocusDisruption",
 	"assistantMessageParser",
-	"newTaskRequireTodos",
 ] as const
 
 export const experimentIdsSchema = z.enum(experimentIds)
@@ -27,7 +26,6 @@ export const experimentsSchema = z.object({
 	multiFileApplyDiff: z.boolean().optional(),
 	preventFocusDisruption: z.boolean().optional(),
 	assistantMessageParser: z.boolean().optional(),
-	newTaskRequireTodos: z.boolean().optional(),
 })
 
 export type Experiments = z.infer<typeof experimentsSchema>

src/core/tools/__tests__/newTaskTool.spec.ts

@@ -2,21 +2,21 @@
 
 import type { AskApproval, HandleError } from "../../../shared/tools"
 
+// Mock vscode module
+vi.mock("vscode", () => ({
+	workspace: {
+		getConfiguration: vi.fn(() => ({
+			get: vi.fn(),
+		})),
+	},
+}))
+
 // Mock other modules first - these are hoisted to the top
 vi.mock("../../../shared/modes", () => ({
 	getModeBySlug: vi.fn(),
 	defaultModeSlug: "ask",
 }))
 
-vi.mock("../../../shared/experiments", () => ({
-	experiments: {
-		isEnabled: vi.fn(),
-	},
-	EXPERIMENT_IDS: {
-		NEW_TASK_REQUIRE_TODOS: "newTaskRequireTodos",
-	},
-}))
-
 vi.mock("../../prompts/responses", () => ({
 	formatResponse: {
 		toolError: vi.fn((msg: string) => `Tool Error: ${msg}`),
@@ -87,7 +87,7 @@ const mockCline = {
 import { newTaskTool } from "../newTaskTool"
 import type { ToolUse } from "../../../shared/tools"
 import { getModeBySlug } from "../../../shared/modes"
-import { experiments } from "../../../shared/experiments"
+import * as vscode from "vscode"
 
 describe("newTaskTool", () => {
 	beforeEach(() => {
@@ -102,8 +102,11 @@ describe("newTaskTool", () => {
 		}) // Default valid mode
 		mockCline.consecutiveMistakeCount = 0
 		mockCline.isPaused = false
-		// Default: experimental setting is disabled
-		vi.mocked(experiments.isEnabled).mockReturnValue(false)
+		// Default: VSCode setting is disabled
+		const mockGet = vi.fn().mockReturnValue(false)
+		vi.mocked(vscode.workspace.getConfiguration).mockReturnValue({
+			get: mockGet,
+		} as any)
 	})
 
 	it("should correctly un-escape \\\\@ to \\@ in the message passed to the new task", async () => {
@@ -407,10 +410,13 @@ describe("newTaskTool", () => {
 		)
 	})
 
-	describe("experimental setting: newTaskRequireTodos", () => {
-		it("should NOT require todos when experimental setting is disabled (default)", async () => {
-			// Ensure experimental setting is disabled
-			vi.mocked(experiments.isEnabled).mockReturnValue(false)
+	describe("VSCode setting: newTaskRequireTodos", () => {
+		it("should NOT require todos when VSCode setting is disabled (default)", async () => {
+			// Ensure VSCode setting is disabled
+			const mockGet = vi.fn().mockReturnValue(false)
+			vi.mocked(vscode.workspace.getConfiguration).mockReturnValue({
+				get: mockGet,
+			} as any)
 
 			const block: ToolUse = {
 				type: "tool_use",
@@ -451,9 +457,12 @@ describe("newTaskTool", () => {
 			expect(mockPushToolResult).toHaveBeenCalledWith(expect.stringContaining("Successfully created new task"))
 		})
 
-		it("should REQUIRE todos when experimental setting is enabled", async () => {
-			// Enable experimental setting
-			vi.mocked(experiments.isEnabled).mockReturnValue(true)
+		it("should REQUIRE todos when VSCode setting is enabled", async () => {
+			// Enable VSCode setting
+			const mockGet = vi.fn().mockReturnValue(true)
+			vi.mocked(vscode.workspace.getConfiguration).mockReturnValue({
+				get: mockGet,
+			} as any)
 
 			const block: ToolUse = {
 				type: "tool_use",
@@ -487,9 +496,12 @@ describe("newTaskTool", () => {
 			)
 		})
 
-		it("should work with todos when experimental setting is enabled", async () => {
-			// Enable experimental setting
-			vi.mocked(experiments.isEnabled).mockReturnValue(true)
+		it("should work with todos when VSCode setting is enabled", async () => {
+			// Enable VSCode setting
+			const mockGet = vi.fn().mockReturnValue(true)
+			vi.mocked(vscode.workspace.getConfiguration).mockReturnValue({
+				get: mockGet,
+			} as any)
 
 			const block: ToolUse = {
 				type: "tool_use",
@@ -532,9 +544,12 @@ describe("newTaskTool", () => {
 			expect(mockPushToolResult).toHaveBeenCalledWith(expect.stringContaining("Successfully created new task"))
 		})
 
-		it("should work with empty todos string when experimental setting is enabled", async () => {
-			// Enable experimental setting
-			vi.mocked(experiments.isEnabled).mockReturnValue(true)
+		it("should work with empty todos string when VSCode setting is enabled", async () => {
+			// Enable VSCode setting
+			const mockGet = vi.fn().mockReturnValue(true)
+			vi.mocked(vscode.workspace.getConfiguration).mockReturnValue({
+				get: mockGet,
+			} as any)
 
 			const block: ToolUse = {
 				type: "tool_use",
@@ -574,7 +589,13 @@ describe("newTaskTool", () => {
 			expect(mockPushToolResult).toHaveBeenCalledWith(expect.stringContaining("Successfully created new task"))
 		})
 
-		it("should check experimental setting with correct experiment ID", async () => {
+		it("should check VSCode setting with correct configuration key", async () => {
+			const mockGet = vi.fn().mockReturnValue(false)
+			const mockGetConfiguration = vi.fn().mockReturnValue({
+				get: mockGet,
+			} as any)
+			vi.mocked(vscode.workspace.getConfiguration).mockImplementation(mockGetConfiguration)
+
 			const block: ToolUse = {
 				type: "tool_use",
 				name: "new_task",
@@ -594,8 +615,9 @@ describe("newTaskTool", () => {
 				mockRemoveClosingTag,
 			)
 
-			// Verify that experiments.isEnabled was called with correct experiment ID
-			expect(experiments.isEnabled).toHaveBeenCalledWith(expect.any(Object), "newTaskRequireTodos")
+			// Verify that VSCode configuration was accessed correctly
+			expect(mockGetConfiguration).toHaveBeenCalledWith("roo-cline")
+			expect(mockGet).toHaveBeenCalledWith("newTaskRequireTodos", false)
 		})
 	})
 

src/core/tools/newTaskTool.ts

@@ -1,4 +1,5 @@
 import delay from "delay"
+import * as vscode from "vscode"
 
 import { RooCodeEventName, TodoItem } from "@roo-code/types"
 
@@ -8,7 +9,6 @@ import { defaultModeSlug, getModeBySlug } from "../../shared/modes"
 import { formatResponse } from "../prompts/responses"
 import { t } from "../../i18n"
 import { parseMarkdownChecklist } from "./updateTodoListTool"
-import { experiments as Experiments, EXPERIMENT_IDS } from "../../shared/experiments"
 
 export async function newTaskTool(
 	cline: Task,
@@ -49,16 +49,18 @@ export async function newTaskTool(
 				return
 			}
 
-			// Get the experimental setting for requiring todos
+			// Get the VSCode setting for requiring todos
 			const provider = cline.providerRef.deref()
 			if (!provider) {
 				pushToolResult(formatResponse.toolError("Provider reference lost"))
 				return
 			}
 			const state = await provider.getState()
-			const requireTodos = Experiments.isEnabled(state?.experiments ?? {}, EXPERIMENT_IDS.NEW_TASK_REQUIRE_TODOS)
+			const requireTodos = vscode.workspace
+				.getConfiguration("roo-cline")
+				.get<boolean>("newTaskRequireTodos", false)
 
-			// Check if todos are required based on experimental setting
+			// Check if todos are required based on VSCode setting
 			// Note: undefined means not provided, empty string is valid
 			if (requireTodos && todos === undefined) {
 				cline.consecutiveMistakeCount++

src/package.json

@@ -398,6 +398,11 @@
 					"minimum": 0,
 					"maximum": 3600,
 					"description": "%settings.apiRequestTimeout.description%"
+				},
+				"roo-cline.newTaskRequireTodos": {
+					"type": "boolean",
+					"default": false,
+					"description": "%settings.newTaskRequireTodos.description%"
 				}
 			}
 		}

src/package.nls.json

@@ -39,5 +39,6 @@
 	"settings.enableCodeActions.description": "Enable Roo Code quick fixes",
 	"settings.autoImportSettingsPath.description": "Path to a RooCode configuration file to automatically import on extension startup. Supports absolute paths and paths relative to the home directory (e.g. '~/Documents/roo-code-settings.json'). Leave empty to disable auto-import.",
 	"settings.useAgentRules.description": "Enable loading of AGENTS.md files for agent-specific rules (see https://agent-rules.org/)",
-	"settings.apiRequestTimeout.description": "Maximum time in seconds to wait for API responses (0 = no timeout, 1-3600s, default: 600s). Higher values are recommended for local providers like LM Studio and Ollama that may need more processing time."
+	"settings.apiRequestTimeout.description": "Maximum time in seconds to wait for API responses (0 = no timeout, 1-3600s, default: 600s). Higher values are recommended for local providers like LM Studio and Ollama that may need more processing time.",
+	"settings.newTaskRequireTodos.description": "Require todos parameter when creating new tasks with the new_task tool"
 }

src/shared/__tests__/experiments.spec.ts

@@ -30,7 +30,6 @@ describe("experiments", () => {
 				multiFileApplyDiff: false,
 				preventFocusDisruption: false,
 				assistantMessageParser: false,
-				newTaskRequireTodos: false,
 			}
 			expect(Experiments.isEnabled(experiments, EXPERIMENT_IDS.POWER_STEERING)).toBe(false)
 		})
@@ -41,7 +40,6 @@ describe("experiments", () => {
 				multiFileApplyDiff: false,
 				preventFocusDisruption: false,
 				assistantMessageParser: false,
-				newTaskRequireTodos: false,
 			}
 			expect(Experiments.isEnabled(experiments, EXPERIMENT_IDS.POWER_STEERING)).toBe(true)
 		})
@@ -52,7 +50,6 @@ describe("experiments", () => {
 				multiFileApplyDiff: false,
 				preventFocusDisruption: false,
 				assistantMessageParser: false,
-				newTaskRequireTodos: false,
 			}
 			expect(Experiments.isEnabled(experiments, EXPERIMENT_IDS.POWER_STEERING)).toBe(false)
 		})

src/shared/experiments.ts

@@ -5,7 +5,6 @@ export const EXPERIMENT_IDS = {
 	POWER_STEERING: "powerSteering",
 	PREVENT_FOCUS_DISRUPTION: "preventFocusDisruption",
 	ASSISTANT_MESSAGE_PARSER: "assistantMessageParser",
-	NEW_TASK_REQUIRE_TODOS: "newTaskRequireTodos",
 } as const satisfies Record<string, ExperimentId>
 
 type _AssertExperimentIds = AssertEqual<Equals<ExperimentId, Values<typeof EXPERIMENT_IDS>>>
@@ -21,7 +20,6 @@ export const experimentConfigsMap: Record<ExperimentKey, ExperimentConfig> = {
 	POWER_STEERING: { enabled: false },
 	PREVENT_FOCUS_DISRUPTION: { enabled: false },
 	ASSISTANT_MESSAGE_PARSER: { enabled: false },
-	NEW_TASK_REQUIRE_TODOS: { enabled: false },
 }
 
 export const experimentDefault = Object.fromEntries(