Remove insert_content tool

Author: samhvw8

evals/packages/types/src/roo-code-defaults.ts

@@ -57,7 +57,6 @@ export const rooCodeDefaults: RooCodeSettings = {
 	fuzzyMatchThreshold: 1.0,
 	experiments: {
 		search_and_replace: false,
-		insert_content: false,
 		powerSteering: false,
 		append_to_file: false,
 	},

evals/packages/types/src/roo-code.ts

@@ -271,7 +271,7 @@ export type CustomSupportPrompts = z.infer<typeof customSupportPromptsSchema>
  * ExperimentId
  */
 
-export const experimentIds = ["search_and_replace", "insert_content", "powerSteering", "append_to_file"] as const
+export const experimentIds = ["search_and_replace", "powerSteering", "append_to_file"] as const
 
 export const experimentIdsSchema = z.enum(experimentIds)
 
@@ -283,7 +283,6 @@ export type ExperimentId = z.infer<typeof experimentIdsSchema>
 
 const experimentsSchema = z.object({
 	search_and_replace: z.boolean(),
-	insert_content: z.boolean(),
 	powerSteering: z.boolean(),
 	append_to_file: z.boolean(),
 })

src/core/Cline.ts

@@ -67,7 +67,6 @@ import { listFilesTool } from "./tools/listFilesTool"
 import { readFileTool } from "./tools/readFileTool"
 import { writeToFileTool } from "./tools/writeToFileTool"
 import { applyDiffTool } from "./tools/applyDiffTool"
-import { insertContentTool } from "./tools/insertContentTool"
 import { searchAndReplaceTool } from "./tools/searchAndReplaceTool"
 import { listCodeDefinitionNamesTool } from "./tools/listCodeDefinitionNamesTool"
 import { searchFilesTool } from "./tools/searchFilesTool"
@@ -1414,8 +1413,6 @@ export class Cline extends EventEmitter<ClineEvents> {
 							return `[${block.name} for '${block.params.regex}'${
 								block.params.file_pattern ? ` in '${block.params.file_pattern}'` : ""
 							}]`
-						case "insert_content":
-							return `[${block.name} for '${block.params.path}']`
 						case "search_and_replace":
 							return `[${block.name} for '${block.params.path}']`
 						case "list_files":
@@ -1440,6 +1437,8 @@ export class Cline extends EventEmitter<ClineEvents> {
 							const modeName = getModeBySlug(mode, customModes)?.name ?? mode
 							return `[${block.name} in ${modeName} mode: '${message}']`
 						}
+						default:
+							return `[${block.name}]`
 					}
 				}
 
@@ -1597,9 +1596,6 @@ export class Cline extends EventEmitter<ClineEvents> {
 					case "apply_diff":
 						await applyDiffTool(this, block, askApproval, handleError, pushToolResult, removeClosingTag)
 						break
-					case "insert_content":
-						await insertContentTool(this, block, askApproval, handleError, pushToolResult, removeClosingTag)
-						break
 					case "search_and_replace":
 						await searchAndReplaceTool(
 							this,

src/core/diff/insert-groups.ts

@@ -172,7 +172,6 @@ describe("SYSTEM_PROMPT", () => {
 		// Reset experiments before each test to ensure they're disabled by default
 		experiments = {
 			[EXPERIMENT_IDS.SEARCH_AND_REPLACE]: false,
-			[EXPERIMENT_IDS.INSERT_BLOCK]: false,
 		}
 	})
 
@@ -483,7 +482,6 @@ describe("SYSTEM_PROMPT", () => {
 			// Set experiments to explicitly disable experimental tools
 			const experimentsConfig = {
 				[EXPERIMENT_IDS.SEARCH_AND_REPLACE]: false,
-				[EXPERIMENT_IDS.INSERT_BLOCK]: false,
 			}
 
 			// Reset experiments
@@ -509,15 +507,13 @@ describe("SYSTEM_PROMPT", () => {
 			const toolSections = prompt.split("\n## ").slice(1)
 			const toolNames = toolSections.map((section) => section.split("\n")[0].trim())
 			expect(toolNames).not.toContain("search_and_replace")
-			expect(toolNames).not.toContain("insert_content")
 			expect(prompt).toMatchSnapshot()
 		})
 
 		it("should enable experimental tools when explicitly enabled", async () => {
 			// Set experiments for testing experimental features
 			const experimentsEnabled = {
 				[EXPERIMENT_IDS.SEARCH_AND_REPLACE]: true,
-				[EXPERIMENT_IDS.INSERT_BLOCK]: true,
 			}
 
 			// Reset default experiments
@@ -542,53 +538,14 @@ describe("SYSTEM_PROMPT", () => {
 			// Get all tool sections
 			const toolSections = prompt.split("## ").slice(1) // Split by section headers and remove first non-tool part
 			const toolNames = toolSections.map((section) => section.split("\n")[0].trim())
-
-			// Verify experimental tools are included in the prompt when enabled
 			expect(toolNames).toContain("search_and_replace")
-			expect(toolNames).toContain("insert_content")
-			expect(prompt).toMatchSnapshot()
-		})
-
-		it("should selectively enable experimental tools", async () => {
-			// Set experiments for testing selective enabling
-			const experimentsSelective = {
-				[EXPERIMENT_IDS.SEARCH_AND_REPLACE]: true,
-				[EXPERIMENT_IDS.INSERT_BLOCK]: false,
-			}
 
-			// Reset default experiments
-			experiments = undefined
-
-			const prompt = await SYSTEM_PROMPT(
-				mockContext,
-				"/test/path",
-				false, // supportsComputerUse
-				undefined, // mcpHub
-				undefined, // diffStrategy
-				undefined, // browserViewportSize
-				defaultModeSlug, // mode
-				undefined, // customModePrompts
-				undefined, // customModes
-				undefined, // globalCustomInstructions
-				undefined, // diffEnabled
-				experimentsSelective, // Use the selective experiments
-				true, // enableMcpServerCreation
-			)
-
-			// Get all tool sections
-			const toolSections = prompt.split("## ").slice(1) // Split by section headers and remove first non-tool part
-			const toolNames = toolSections.map((section) => section.split("\n")[0].trim())
-
-			// Verify only enabled experimental tools are included
-			expect(toolNames).toContain("search_and_replace")
-			expect(toolNames).not.toContain("insert_content")
 			expect(prompt).toMatchSnapshot()
 		})
 
 		it("should list all available editing tools in base instruction", async () => {
 			const experiments = {
 				[EXPERIMENT_IDS.SEARCH_AND_REPLACE]: true,
-				[EXPERIMENT_IDS.INSERT_BLOCK]: true,
 			}
 
 			const prompt = await SYSTEM_PROMPT(
@@ -610,13 +567,11 @@ describe("SYSTEM_PROMPT", () => {
 			// Verify base instruction lists all available tools
 			expect(prompt).toContain("apply_diff (for replacing lines in existing files)")
 			expect(prompt).toContain("write_to_file (for creating new files or complete file rewrites)")
-			expect(prompt).toContain("insert_content (for adding lines to existing files)")
 			expect(prompt).toContain("search_and_replace (for finding and replacing individual pieces of text)")
 		})
 		it("should provide detailed instructions for each enabled tool", async () => {
 			const experiments = {
 				[EXPERIMENT_IDS.SEARCH_AND_REPLACE]: true,
-				[EXPERIMENT_IDS.INSERT_BLOCK]: true,
 			}
 
 			const prompt = await SYSTEM_PROMPT(
@@ -639,7 +594,6 @@ describe("SYSTEM_PROMPT", () => {
 			expect(prompt).toContain(
 				"You should always prefer using other editing tools over write_to_file when making changes to existing files since write_to_file is much slower and cannot handle large files.",
 			)
-			expect(prompt).toContain("The insert_content tool adds lines of text to files")
 			expect(prompt).toContain("The search_and_replace tool finds and replaces text or regex in files")
 		})
 	})

src/core/prompts/__tests__/__snapshots__/system.test.ts.snap

@@ -16,9 +16,6 @@ function getEditingInstructions(diffStrategy?: DiffStrategy, experiments?: Recor
 
 	availableTools.push("append_to_file (for appending content to the end of files)")
 
-	if (experiments?.["insert_content"]) {
-		availableTools.push("insert_content (for adding lines to existing files)")
-	}
 	if (experiments?.["search_and_replace"]) {
 		availableTools.push("search_and_replace (for finding and replacing individual pieces of text)")
 	}
@@ -30,14 +27,6 @@ function getEditingInstructions(diffStrategy?: DiffStrategy, experiments?: Recor
 			"- The append_to_file tool adds content to the end of files, such as appending new log entries or adding new data records. This tool will always add the content at the end of the file.",
 		)
 	}
-
-	// Additional details for experimental features
-	if (experiments?.["insert_content"]) {
-		instructions.push(
-			"- The insert_content tool adds lines of text to files, such as adding a new function to a JavaScript file or inserting a new route in a Python file. This tool will insert it at the specified line location. It can support multiple operations at once.",
-		)
-	}
-
 	if (experiments?.["search_and_replace"]) {
 		instructions.push(
 			"- The search_and_replace tool finds and replaces text or regex in files. This tool allows you to search for a specific regex pattern or text and replace it with another value. Be cautious when using this tool to ensure you are replacing the correct text. It can support multiple operations at once.",

src/core/prompts/__tests__/system.test.ts

@@ -12,7 +12,6 @@ import { getWriteToFileDescription } from "./write-to-file"
 import { getAppendToFileDescription } from "./append-to-file"
 import { getSearchFilesDescription } from "./search-files"
 import { getListFilesDescription } from "./list-files"
-import { getInsertContentDescription } from "./insert-content"
 import { getSearchAndReplaceDescription } from "./search-and-replace"
 import { getListCodeDefinitionNamesDescription } from "./list-code-definition-names"
 import { getBrowserActionDescription } from "./browser-action"
@@ -40,7 +39,6 @@ const toolDescriptionMap: Record<string, (args: ToolArgs) => string | undefined>
 	access_mcp_resource: (args) => getAccessMcpResourceDescription(args),
 	switch_mode: () => getSwitchModeDescription(),
 	new_task: (args) => getNewTaskDescription(args),
-	insert_content: (args) => getInsertContentDescription(args),
 	search_and_replace: (args) => getSearchAndReplaceDescription(args),
 	apply_diff: (args) =>
 		args.diffStrategy ? args.diffStrategy.getToolDescription({ cwd: args.cwd, toolOptions: args.toolOptions }) : "",
@@ -124,6 +122,5 @@ export {
 	getUseMcpToolDescription,
 	getAccessMcpResourceDescription,
 	getSwitchModeDescription,
-	getInsertContentDescription,
 	getSearchAndReplaceDescription,
 }