Skip to content

Commit c50668a

Browse files
committed
fix: resolve CI failures for PR #6609
- Add missing translations for "comingSoon", "optional", and "autoApprove.enabled" in all locales - Remove unused src/services/code-index/rerankers/index.ts file to fix knip error - Fix Windows path separator issues in tests by using path.normalize()
1 parent 6fe86f0 commit c50668a

34 files changed

+88
-44
lines changed

src/services/code-index/__tests__/search-service.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// npx vitest services/code-index/__tests__/search-service.spec.ts
22

33
import { describe, it, expect, beforeEach, vi, Mock } from "vitest"
4+
import * as path from "path"
45
import { CodeIndexSearchService } from "../search-service"
56
import { CodeIndexConfigManager } from "../config-manager"
67
import { CodeIndexStateManager } from "../state-manager"
@@ -235,7 +236,7 @@ describe("CodeIndexSearchService", () => {
235236
// Verify vector store search was called with normalized prefix
236237
expect(mockVectorStore.search).toHaveBeenCalledWith(
237238
testEmbedding,
238-
"src/auth", // normalized
239+
path.normalize("src/auth"), // normalized to OS-specific format
239240
0.5,
240241
20,
241242
)

src/services/code-index/rerankers/index.ts

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/tests/services/code-index/search-service-reranking.test.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"
2+
import * as path from "path"
23
import { CodeIndexSearchService } from "../../../services/code-index/search-service"
34
import { CodeIndexConfigManager } from "../../../services/code-index/config-manager"
45
import { CodeIndexStateManager } from "../../../services/code-index/state-manager"
@@ -298,7 +299,12 @@ describe("CodeIndexSearchService - Reranking Integration", () => {
298299

299300
await searchService.searchIndex("test query", directoryPrefix)
300301

301-
expect(mockVectorStore.search).toHaveBeenCalledWith(expect.any(Array), directoryPrefix, 0.3, 100)
302+
expect(mockVectorStore.search).toHaveBeenCalledWith(
303+
expect.any(Array),
304+
path.normalize(directoryPrefix), // normalized to OS-specific format
305+
0.3,
306+
100,
307+
)
302308
})
303309
})
304310

webview-ui/src/i18n/locales/ca/common.json

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/de/common.json

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/es/common.json

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/fr/common.json

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/fr/settings.json

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/hi/common.json

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/hi/settings.json

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)