fix: Remove premature fallback in vercel-ai-gateway model validation

daniel-lxs · daniel-lxs · commit c693f1c92228 · 2025-11-05T12:06:15.000-05:00
- Pass raw apiConfiguration.vercelAiGatewayModelId to getValidatedModelId()
- Remove ?? defaultModelId fallback that bypassed validation logic
- Now consistent with all other dynamic providers (openrouter, requesty, etc)
- Ensures helper function properly validates undefined cases
diff --git a/webview-ui/src/components/ui/hooks/useSelectedModel.ts b/webview-ui/src/components/ui/hooks/useSelectedModel.ts
@@ -358,7 +358,7 @@ function getSelectedModel({
 		}
 		case "vercel-ai-gateway": {
 			const id = getValidatedModelId(
-				apiConfiguration.vercelAiGatewayModelId ?? defaultModelId,
+				apiConfiguration.vercelAiGatewayModelId,
 				routerModels["vercel-ai-gateway"],
 				defaultModelId,
 			)

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,7 @@ function getSelectedModel({`
`358`	`358`	`}`
`359`	`359`	`case "vercel-ai-gateway": {`
`360`	`360`	`const id = getValidatedModelId(`
`361`		`- apiConfiguration.vercelAiGatewayModelId ?? defaultModelId,`
	`361`	`+ apiConfiguration.vercelAiGatewayModelId,`
`362`	`362`	`routerModels["vercel-ai-gateway"],`
`363`	`363`	`defaultModelId,`
`364`	`364`	`)`