Add default task names for empty tasks (#5071)

Co-authored-by: kiwina <[email protected]>

Author: 2 people

src/core/task-persistence/taskMetadata.ts

@@ -8,6 +8,7 @@ import { combineCommandSequences } from "../../shared/combineCommandSequences"
 import { getApiMetrics } from "../../shared/getApiMetrics"
 import { findLastIndex } from "../../shared/array"
 import { getTaskDirectoryPath } from "../../utils/storage"
+import { t } from "../../i18n"
 
 const taskSizeCache = new NodeCache({ stdTTL: 30, checkperiod: 5 * 60 })
 
@@ -27,29 +28,63 @@ export async function taskMetadata({
 	workspace,
 }: TaskMetadataOptions) {
 	const taskDir = await getTaskDirectoryPath(globalStoragePath, taskId)
-	const taskMessage = messages[0] // First message is always the task say.
 
-	const lastRelevantMessage =
-		messages[findLastIndex(messages, (m) => !(m.ask === "resume_task" || m.ask === "resume_completed_task"))]
+	// Determine message availability upfront
+	const hasMessages = messages && messages.length > 0
 
-	let taskDirSize = taskSizeCache.get<number>(taskDir)
+	// Pre-calculate all values based on availability
+	let timestamp: number
+	let tokenUsage: ReturnType<typeof getApiMetrics>
+	let taskDirSize: number
+	let taskMessage: ClineMessage | undefined
 
-	if (taskDirSize === undefined) {
-		try {
-			taskDirSize = await getFolderSize.loose(taskDir)
-			taskSizeCache.set<number>(taskDir, taskDirSize)
-		} catch (error) {
-			taskDirSize = 0
+	if (!hasMessages) {
+		// Handle no messages case
+		timestamp = Date.now()
+		tokenUsage = {
+			totalTokensIn: 0,
+			totalTokensOut: 0,
+			totalCacheWrites: 0,
+			totalCacheReads: 0,
+			totalCost: 0,
+			contextTokens: 0,
 		}
-	}
+		taskDirSize = 0
+	} else {
+		// Handle messages case
+		taskMessage = messages[0] // First message is always the task say.
+
+		const lastRelevantMessage =
+			messages[findLastIndex(messages, (m) => !(m.ask === "resume_task" || m.ask === "resume_completed_task"))] ||
+			taskMessage
+
+		timestamp = lastRelevantMessage.ts
+
+		tokenUsage = getApiMetrics(combineApiRequests(combineCommandSequences(messages.slice(1))))
 
-	const tokenUsage = getApiMetrics(combineApiRequests(combineCommandSequences(messages.slice(1))))
+		// Get task directory size
+		const cachedSize = taskSizeCache.get<number>(taskDir)
+
+		if (cachedSize === undefined) {
+			try {
+				taskDirSize = await getFolderSize.loose(taskDir)
+				taskSizeCache.set<number>(taskDir, taskDirSize)
+			} catch (error) {
+				taskDirSize = 0
+			}
+		} else {
+			taskDirSize = cachedSize
+		}
+	}
 
+	// Create historyItem once with pre-calculated values
 	const historyItem: HistoryItem = {
 		id: taskId,
 		number: taskNumber,
-		ts: lastRelevantMessage.ts,
-		task: taskMessage.text ?? "",
+		ts: timestamp,
+		task: hasMessages
+			? taskMessage!.text?.trim() || t("common:tasks.incomplete", { taskNumber })
+			: t("common:tasks.no_messages", { taskNumber }),
 		tokensIn: tokenUsage.totalTokensIn,
 		tokensOut: tokenUsage.totalTokensOut,
 		cacheWrites: tokenUsage.totalCacheWrites,

src/i18n/locales/ca/common.json

@@ -101,7 +101,9 @@
 	},
 	"tasks": {
 		"canceled": "Error de tasca: Ha estat aturada i cancel·lada per l'usuari.",
-		"deleted": "Fallada de tasca: Ha estat aturada i eliminada per l'usuari."
+		"deleted": "Fallada de tasca: Ha estat aturada i eliminada per l'usuari.",
+		"incomplete": "Tasca #{{taskNumber}} (Incompleta)",
+		"no_messages": "Tasca #{{taskNumber}} (Sense missatges)"
 	},
 	"storage": {
 		"prompt_custom_path": "Introdueix una ruta d'emmagatzematge personalitzada per a l'historial de converses o deixa-ho buit per utilitzar la ubicació predeterminada",

src/i18n/locales/de/common.json

@@ -97,7 +97,9 @@
 	},
 	"tasks": {
 		"canceled": "Aufgabenfehler: Die Aufgabe wurde vom Benutzer gestoppt und abgebrochen.",
-		"deleted": "Aufgabenfehler: Die Aufgabe wurde vom Benutzer gestoppt und gelöscht."
+		"deleted": "Aufgabenfehler: Die Aufgabe wurde vom Benutzer gestoppt und gelöscht.",
+		"incomplete": "Aufgabe #{{taskNumber}} (Unvollständig)",
+		"no_messages": "Aufgabe #{{taskNumber}} (Keine Nachrichten)"
 	},
 	"storage": {
 		"prompt_custom_path": "Gib den benutzerdefinierten Speicherpfad für den Gesprächsverlauf ein, leer lassen für Standardspeicherort",

src/i18n/locales/en/common.json

@@ -97,7 +97,9 @@
 	},
 	"tasks": {
 		"canceled": "Task error: It was stopped and canceled by the user.",
-		"deleted": "Task failure: It was stopped and deleted by the user."
+		"deleted": "Task failure: It was stopped and deleted by the user.",
+		"incomplete": "Task #{{taskNumber}} (Incomplete)",
+		"no_messages": "Task #{{taskNumber}} (No messages)"
 	},
 	"storage": {
 		"prompt_custom_path": "Enter custom conversation history storage path, leave empty to use default location",

src/i18n/locales/es/common.json

@@ -97,7 +97,9 @@
 	},
 	"tasks": {
 		"canceled": "Error de tarea: Fue detenida y cancelada por el usuario.",
-		"deleted": "Fallo de tarea: Fue detenida y eliminada por el usuario."
+		"deleted": "Fallo de tarea: Fue detenida y eliminada por el usuario.",
+		"incomplete": "Tarea #{{taskNumber}} (Incompleta)",
+		"no_messages": "Tarea #{{taskNumber}} (Sin mensajes)"
 	},
 	"storage": {
 		"prompt_custom_path": "Ingresa la ruta de almacenamiento personalizada para el historial de conversaciones, déjala vacía para usar la ubicación predeterminada",

src/i18n/locales/fr/common.json

@@ -97,7 +97,9 @@
 	},
 	"tasks": {
 		"canceled": "Erreur de tâche : Elle a été arrêtée et annulée par l'utilisateur.",
-		"deleted": "Échec de la tâche : Elle a été arrêtée et supprimée par l'utilisateur."
+		"deleted": "Échec de la tâche : Elle a été arrêtée et supprimée par l'utilisateur.",
+		"incomplete": "Tâche #{{taskNumber}} (Incomplète)",
+		"no_messages": "Tâche #{{taskNumber}} (Aucun message)"
 	},
 	"storage": {
 		"prompt_custom_path": "Entrez le chemin de stockage personnalisé pour l'historique des conversations, laissez vide pour utiliser l'emplacement par défaut",

src/i18n/locales/hi/common.json

@@ -97,7 +97,9 @@
 	},
 	"tasks": {
 		"canceled": "टास्क त्रुटि: इसे उपयोगकर्ता द्वारा रोका और रद्द किया गया था।",
-		"deleted": "टास्क विफलता: इसे उपयोगकर्ता द्वारा रोका और हटाया गया था।"
+		"deleted": "टास्क विफलता: इसे उपयोगकर्ता द्वारा रोका और हटाया गया था।",
+		"incomplete": "टास्क #{{taskNumber}} (अधूरा)",
+		"no_messages": "टास्क #{{taskNumber}} (कोई संदेश नहीं)"
 	},
 	"storage": {
 		"prompt_custom_path": "वार्तालाप इतिहास के लिए कस्टम स्टोरेज पाथ दर्ज करें, डिफ़ॉल्ट स्थान का उपयोग करने के लिए खाली छोड़ दें",

src/i18n/locales/id/common.json

@@ -97,7 +97,9 @@
 	},
 	"tasks": {
 		"canceled": "Error tugas: Dihentikan dan dibatalkan oleh pengguna.",
-		"deleted": "Kegagalan tugas: Dihentikan dan dihapus oleh pengguna."
+		"deleted": "Kegagalan tugas: Dihentikan dan dihapus oleh pengguna.",
+		"incomplete": "Tugas #{{taskNumber}} (Tidak lengkap)",
+		"no_messages": "Tugas #{{taskNumber}} (Tidak ada pesan)"
 	},
 	"storage": {
 		"prompt_custom_path": "Masukkan path penyimpanan riwayat percakapan kustom, biarkan kosong untuk menggunakan lokasi default",

src/i18n/locales/it/common.json

@@ -97,7 +97,9 @@
 	},
 	"tasks": {
 		"canceled": "Errore attività: È stata interrotta e annullata dall'utente.",
-		"deleted": "Fallimento attività: È stata interrotta ed eliminata dall'utente."
+		"deleted": "Fallimento attività: È stata interrotta ed eliminata dall'utente.",
+		"incomplete": "Attività #{{taskNumber}} (Incompleta)",
+		"no_messages": "Attività #{{taskNumber}} (Nessun messaggio)"
 	},
 	"storage": {
 		"prompt_custom_path": "Inserisci il percorso di archiviazione personalizzato per la cronologia delle conversazioni, lascia vuoto per utilizzare la posizione predefinita",

src/i18n/locales/ja/common.json

@@ -97,7 +97,9 @@
 	},
 	"tasks": {
 		"canceled": "タスクエラー：ユーザーによって停止およびキャンセルされました。",
-		"deleted": "タスク失敗：ユーザーによって停止および削除されました。"
+		"deleted": "タスク失敗：ユーザーによって停止および削除されました。",
+		"incomplete": "タスク #{{taskNumber}} (未完了)",
+		"no_messages": "タスク #{{taskNumber}} (メッセージなし)"
 	},
 	"storage": {
 		"prompt_custom_path": "会話履歴のカスタムストレージパスを入力してください。デフォルトの場所を使用する場合は空のままにしてください",