fix: make @ file search respect VSCode search.useIgnoreFiles setting

- Modified executeRipgrepForFiles to accept respectIgnoreFiles parameter
- Added --no-ignore-vcs flag when VSCode search.useIgnoreFiles is disabled
- Updated searchWorkspaceFiles to read VSCode configuration
- Added comprehensive tests to verify functionality
- Fixes issue where @ file search could not find files in ignored directories when VSCode setting was disabled

Fixes #5721

Author: Roo

src/services/search/__tests__/file-search.spec.ts

@@ -0,0 +1,136 @@
+import { describe, it, expect, vi, beforeEach } from "vitest"
+
+// Mock getBinPath first - this needs to be hoisted
+vi.mock("../../ripgrep", () => ({
+	getBinPath: vi.fn().mockResolvedValue("/usr/bin/rg"),
+}))
+
+// Mock vscode
+vi.mock("vscode", () => ({
+	workspace: {
+		getConfiguration: vi.fn(),
+	},
+	env: {
+		appRoot: "/mock/vscode/app",
+	},
+}))
+
+// Mock child_process
+vi.mock("child_process", () => ({
+	spawn: vi.fn(),
+}))
+
+// Mock readline
+vi.mock("readline", () => ({
+	createInterface: vi.fn(),
+}))
+
+// Import after mocks are set up
+import * as vscode from "vscode"
+import * as childProcess from "child_process"
+import * as readline from "readline"
+import { executeRipgrepForFiles, searchWorkspaceFiles } from "../file-search"
+
+describe("file-search", () => {
+	const mockSpawn = vi.mocked(childProcess.spawn)
+	const mockGetConfiguration = vi.mocked(vscode.workspace.getConfiguration)
+	const mockCreateInterface = vi.mocked(readline.createInterface)
+
+	beforeEach(() => {
+		vi.clearAllMocks()
+
+		// Setup default mocks for each test
+		const mockProcess = {
+			stdout: {},
+			stderr: {
+				on: vi.fn(),
+			},
+			on: vi.fn(),
+			kill: vi.fn(),
+		}
+
+		const mockReadlineInterface = {
+			on: vi.fn((event, callback) => {
+				if (event === "line") {
+					// Simulate some file output
+					setTimeout(() => {
+						callback("/test/workspace/src/file1.ts")
+						callback("/test/workspace/src/file2.ts")
+					}, 10)
+				} else if (event === "close") {
+					setTimeout(() => callback(), 20)
+				}
+			}),
+			close: vi.fn(),
+		}
+
+		mockSpawn.mockReturnValue(mockProcess as any)
+		mockCreateInterface.mockReturnValue(mockReadlineInterface as any)
+	})
+
+	describe("executeRipgrepForFiles", () => {
+		it("should include --no-ignore-vcs flag when respectIgnoreFiles is false", async () => {
+			const workspacePath = "/test/workspace"
+
+			// Test with respectIgnoreFiles = false
+			await executeRipgrepForFiles(workspacePath, 5000, false)
+
+			// Verify that --no-ignore-vcs was included in the args
+			expect(mockSpawn).toHaveBeenCalledWith("/usr/bin/rg", expect.arrayContaining(["--no-ignore-vcs"]))
+		})
+
+		it("should not include --no-ignore-vcs flag when respectIgnoreFiles is true", async () => {
+			const workspacePath = "/test/workspace"
+
+			// Test with respectIgnoreFiles = true (default)
+			await executeRipgrepForFiles(workspacePath, 5000, true)
+
+			// Verify that --no-ignore-vcs was NOT included in the args
+			expect(mockSpawn).toHaveBeenCalledWith("/usr/bin/rg", expect.not.arrayContaining(["--no-ignore-vcs"]))
+		})
+	})
+
+	describe("searchWorkspaceFiles", () => {
+		it("should respect VSCode search.useIgnoreFiles setting when true", async () => {
+			// Mock VSCode configuration to return useIgnoreFiles = true
+			mockGetConfiguration.mockReturnValue({
+				get: vi.fn().mockReturnValue(true),
+			} as any)
+
+			await searchWorkspaceFiles("test", "/test/workspace", 20)
+
+			// Verify VSCode configuration was checked
+			expect(mockGetConfiguration).toHaveBeenCalledWith("search")
+
+			// Verify that --no-ignore-vcs was NOT included (respecting .gitignore)
+			expect(mockSpawn).toHaveBeenCalledWith("/usr/bin/rg", expect.not.arrayContaining(["--no-ignore-vcs"]))
+		})
+
+		it("should respect VSCode search.useIgnoreFiles setting when false", async () => {
+			// Mock VSCode configuration to return useIgnoreFiles = false
+			mockGetConfiguration.mockReturnValue({
+				get: vi.fn().mockReturnValue(false),
+			} as any)
+
+			await searchWorkspaceFiles("test", "/test/workspace", 20)
+
+			// Verify VSCode configuration was checked
+			expect(mockGetConfiguration).toHaveBeenCalledWith("search")
+
+			// Verify that --no-ignore-vcs was included (ignoring .gitignore)
+			expect(mockSpawn).toHaveBeenCalledWith("/usr/bin/rg", expect.arrayContaining(["--no-ignore-vcs"]))
+		})
+
+		it("should default to respecting ignore files when VSCode setting is not available", async () => {
+			// Mock VSCode configuration to return undefined (use default)
+			mockGetConfiguration.mockReturnValue({
+				get: vi.fn().mockReturnValue(undefined),
+			} as any)
+
+			await searchWorkspaceFiles("test", "/test/workspace", 20)
+
+			// Verify that the default behavior (respecting .gitignore) is used
+			expect(mockSpawn).toHaveBeenCalledWith("/usr/bin/rg", expect.not.arrayContaining(["--no-ignore-vcs"]))
+		})
+	})
+})

src/services/search/file-search.ts

@@ -88,6 +88,7 @@ export async function executeRipgrep({
 export async function executeRipgrepForFiles(
 	workspacePath: string,
 	limit: number = 5000,
+	respectIgnoreFiles: boolean = true,
 ): Promise<{ path: string; type: "file" | "folder"; label?: string }[]> {
 	const args = [
 		"--files",
@@ -101,9 +102,15 @@ export async function executeRipgrepForFiles(
 		"!**/out/**",
 		"-g",
 		"!**/dist/**",
-		workspacePath,
 	]
 
+	// If VSCode's search.useIgnoreFiles is disabled, add --no-ignore-vcs to ignore .gitignore files
+	if (!respectIgnoreFiles) {
+		args.push("--no-ignore-vcs")
+	}
+
+	args.push(workspacePath)
+
 	return executeRipgrep({ args, workspacePath, limit })
 }
 
@@ -113,8 +120,11 @@ export async function searchWorkspaceFiles(
 	limit: number = 20,
 ): Promise<{ path: string; type: "file" | "folder"; label?: string }[]> {
 	try {
+		// Check VSCode's search.useIgnoreFiles setting
+		const useIgnoreFiles = vscode.workspace.getConfiguration("search").get<boolean>("useIgnoreFiles", true)
+
 		// Get all files and directories (from our modified function)
-		const allItems = await executeRipgrepForFiles(workspacePath, 5000)
+		const allItems = await executeRipgrepForFiles(workspacePath, 5000, useIgnoreFiles)
 
 		// If no query, just return the top items
 		if (!query.trim()) {