Skip to content

Commit c7562a6

Browse files
authored
Try to avoid placeholders in follow-up questions (#1839)
* Try to avoid placeholders in follow-up questions * Fix this too
1 parent f1efeca commit c7562a6

File tree

3 files changed

+19
-17
lines changed

3 files changed

+19
-17
lines changed

src/core/prompts/__tests__/__snapshots__/system.test.ts.snap

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ Parameters:
188188
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
189189
1. Be provided in its own <suggest> tag
190190
2. Be specific, actionable, and directly related to the completed task
191-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
191+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
192192
Usage:
193193
<ask_followup_question>
194194
<question>Your question here</question>
@@ -650,7 +650,7 @@ Parameters:
650650
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
651651
1. Be provided in its own <suggest> tag
652652
2. Be specific, actionable, and directly related to the completed task
653-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
653+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
654654
Usage:
655655
<ask_followup_question>
656656
<question>Your question here</question>
@@ -1081,7 +1081,7 @@ Parameters:
10811081
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
10821082
1. Be provided in its own <suggest> tag
10831083
2. Be specific, actionable, and directly related to the completed task
1084-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
1084+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
10851085
Usage:
10861086
<ask_followup_question>
10871087
<question>Your question here</question>
@@ -1461,7 +1461,7 @@ Parameters:
14611461
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
14621462
1. Be provided in its own <suggest> tag
14631463
2. Be specific, actionable, and directly related to the completed task
1464-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
1464+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
14651465
Usage:
14661466
<ask_followup_question>
14671467
<question>Your question here</question>
@@ -1838,7 +1838,7 @@ Parameters:
18381838
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
18391839
1. Be provided in its own <suggest> tag
18401840
2. Be specific, actionable, and directly related to the completed task
1841-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
1841+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
18421842
Usage:
18431843
<ask_followup_question>
18441844
<question>Your question here</question>
@@ -2215,7 +2215,7 @@ Parameters:
22152215
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
22162216
1. Be provided in its own <suggest> tag
22172217
2. Be specific, actionable, and directly related to the completed task
2218-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
2218+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
22192219
Usage:
22202220
<ask_followup_question>
22212221
<question>Your question here</question>
@@ -2638,7 +2638,7 @@ Parameters:
26382638
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
26392639
1. Be provided in its own <suggest> tag
26402640
2. Be specific, actionable, and directly related to the completed task
2641-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
2641+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
26422642
Usage:
26432643
<ask_followup_question>
26442644
<question>Your question here</question>
@@ -3067,7 +3067,7 @@ Parameters:
30673067
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
30683068
1. Be provided in its own <suggest> tag
30693069
2. Be specific, actionable, and directly related to the completed task
3070-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
3070+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
30713071
Usage:
30723072
<ask_followup_question>
30733073
<question>Your question here</question>
@@ -3895,7 +3895,7 @@ Parameters:
38953895
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
38963896
1. Be provided in its own <suggest> tag
38973897
2. Be specific, actionable, and directly related to the completed task
3898-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
3898+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
38993899
Usage:
39003900
<ask_followup_question>
39013901
<question>Your question here</question>
@@ -4335,7 +4335,7 @@ Parameters:
43354335
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
43364336
1. Be provided in its own <suggest> tag
43374337
2. Be specific, actionable, and directly related to the completed task
4338-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
4338+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
43394339
Usage:
43404340
<ask_followup_question>
43414341
<question>Your question here</question>
@@ -4714,7 +4714,7 @@ Parameters:
47144714
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
47154715
1. Be provided in its own <suggest> tag
47164716
2. Be specific, actionable, and directly related to the completed task
4717-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
4717+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
47184718
Usage:
47194719
<ask_followup_question>
47204720
<question>Your question here</question>
@@ -5267,7 +5267,7 @@ Parameters:
52675267
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
52685268
1. Be provided in its own <suggest> tag
52695269
2. Be specific, actionable, and directly related to the completed task
5270-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
5270+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
52715271
Usage:
52725272
<ask_followup_question>
52735273
<question>Your question here</question>
@@ -5735,7 +5735,7 @@ Parameters:
57355735
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
57365736
1. Be provided in its own <suggest> tag
57375737
2. Be specific, actionable, and directly related to the completed task
5738-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
5738+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
57395739
Usage:
57405740
<ask_followup_question>
57415741
<question>Your question here</question>
@@ -6066,7 +6066,7 @@ Parameters:
60666066
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
60676067
1. Be provided in its own <suggest> tag
60686068
2. Be specific, actionable, and directly related to the completed task
6069-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
6069+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
60706070
Usage:
60716071
<ask_followup_question>
60726072
<question>Your question here</question>
@@ -6610,7 +6610,7 @@ Parameters:
66106610
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
66116611
1. Be provided in its own <suggest> tag
66126612
2. Be specific, actionable, and directly related to the completed task
6613-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
6613+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
66146614
Usage:
66156615
<ask_followup_question>
66166616
<question>Your question here</question>

src/core/prompts/tools/ask-followup-question.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Parameters:
66
- follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must:
77
1. Be provided in its own <suggest> tag
88
2. Be specific, actionable, and directly related to the completed task
9-
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details
9+
3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses.
1010
Usage:
1111
<ask_followup_question>
1212
<question>Your question here</question>

webview-ui/src/components/chat/ChatRow.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1006,7 +1006,9 @@ export const ChatRowContent = ({
10061006
</div>
10071007
)}
10081008
<div style={{ paddingTop: 10, paddingBottom: 15 }}>
1009-
<Markdown markdown={followUpData?.question} />
1009+
<Markdown
1010+
markdown={message.partial === true ? message?.text : followUpData?.question}
1011+
/>
10101012
</div>
10111013
<FollowUpSuggest
10121014
suggestions={followUpData?.suggest}

0 commit comments

Comments
 (0)