Skip to content

Commit cae2337

Browse files
committed
fix(settings/prompts): enable Save on textarea input and preserve empty strings
Use onInput to update custom support prompts per keystroke (no blur needed). In ModesView, avoid trimming during editing and send raw values to backend; preserve empty strings via ?? to ensure immediate dirty state. Closes #5780.
1 parent cc26220 commit cae2337

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

webview-ui/src/components/modes/ModesView.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1110,7 +1110,7 @@ const ModesView = ({ onDone }: ModesViewProps) => {
11101110
updateCustomMode(visualMode, {
11111111
...customMode,
11121112
// Preserve empty string; only treat null/undefined as unset
1113-
customInstructions: value.trim() ?? undefined,
1113+
customInstructions: value ?? undefined,
11141114
source: customMode.source || "global",
11151115
})
11161116
} else {
@@ -1313,7 +1313,7 @@ const ModesView = ({ onDone }: ModesViewProps) => {
13131313
setCustomInstructions(value ?? undefined)
13141314
vscode.postMessage({
13151315
type: "customInstructions",
1316-
text: value.trim() ?? undefined,
1316+
text: value ?? undefined,
13171317
})
13181318
}}
13191319
rows={4}

webview-ui/src/components/settings/PromptsSettings.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ const PromptsSettings = ({ customSupportPrompts, setCustomSupportPrompts }: Prom
167167
<VSCodeTextArea
168168
resize="vertical"
169169
value={getSupportPromptValue(activeSupportOption)}
170-
onChange={(e) => {
170+
onInput={(e) => {
171171
const value =
172172
(e as unknown as CustomEvent)?.detail?.target?.value ??
173173
((e as any).target as HTMLTextAreaElement).value

0 commit comments

Comments
 (0)