refactor: streamline suggestion handling and remove debug logs

- Remove console.log debug statements
- Refactor suggest handling logic to be more efficient
- Add dedicated prompt_suggest message type
- Add proper state management for suggestions in UI
- Fix ESLint warning in ChatRow.tsx

Author: samhvw8

src/core/Cline.ts

@@ -2708,7 +2708,6 @@ export class Cline {
 								let normalizedSuggest = null
 
 								if (values) {
-									console.log("values", values)
 									type Suggest = {
 										suggest: string
 									}
@@ -2721,7 +2720,6 @@ export class Cline {
 										parsedSuggest = parseXml(values, ["values.suggest"]) as {
 											suggest: Suggest[] | Suggest
 										}
-										console.log("parsedSuggest", parsedSuggest)
 									} catch (error) {
 										this.consecutiveMistakeCount++
 										await this.say("error", `Failed to parse operations: ${error.message}`)
@@ -2734,8 +2732,6 @@ export class Cline {
 									normalizedSuggest = Array.isArray(parsedSuggest?.suggest)
 										? parsedSuggest.suggest
 										: [parsedSuggest?.suggest].filter((sug): sug is Suggest => sug !== undefined)
-
-									console.log("normalizedSuggest", normalizedSuggest)
 								} else {
 									this.consecutiveMistakeCount = 0
 								}
@@ -2765,45 +2761,39 @@ export class Cline {
 								}
 
 								const toolResults: (Anthropic.TextBlockParam | Anthropic.ImageBlockParam)[] = []
+
 								if (normalizedSuggest) {
 									console.log("normalizedSuggest", normalizedSuggest)
-									const { text, images } = await this.ask(
-										"prompt_suggest",
-										JSON.stringify(normalizedSuggest),
-										false,
-									)
-									await this.say("user_feedback", text ?? "", images)
-									pushToolResult(
-										formatResponse.toolResult(`<user_feedback>\n${text}\n</user_feedback>`, images),
-									)
-								} else {
-									// we already sent completion_result says, an empty string asks relinquishes control over button and field
-									const { response, text, images } = await this.ask("completion_result", "", false)
-									if (response === "yesButtonClicked") {
-										pushToolResult("") // signals to recursive loop to stop (for now this never happens since yesButtonClicked will trigger a new task)
-										break
-									}
-									await this.say("user_feedback", text ?? "", images)
+									await this.say("prompt_suggest", JSON.stringify(normalizedSuggest))
+								}
 
-									if (commandResult) {
-										if (typeof commandResult === "string") {
-											toolResults.push({ type: "text", text: commandResult })
-										} else if (Array.isArray(commandResult)) {
-											toolResults.push(...commandResult)
-										}
+								// we already sent completion_result says, an empty string asks relinquishes control over button and field
+								const { response, text, images } = await this.ask("completion_result", "", false)
+								if (response === "yesButtonClicked") {
+									pushToolResult("") // signals to recursive loop to stop (for now this never happens since yesButtonClicked will trigger a new task)
+									break
+								}
+								await this.say("user_feedback", text ?? "", images)
+
+								if (commandResult) {
+									if (typeof commandResult === "string") {
+										toolResults.push({ type: "text", text: commandResult })
+									} else if (Array.isArray(commandResult)) {
+										toolResults.push(...commandResult)
 									}
-									toolResults.push({
-										type: "text",
-										text: `The user has provided feedback on the results. Consider their input to continue the task, and then attempt completion again.\n<feedback>\n${text}\n</feedback>`,
-									})
-									toolResults.push(...formatResponse.imageBlocks(images))
-									this.userMessageContent.push({
-										type: "text",
-										text: `${toolDescription()} Result:`,
-									})
-									this.userMessageContent.push(...toolResults)
 								}
 
+								toolResults.push({
+									type: "text",
+									text: `The user has provided feedback on the results. Consider their input to continue the task, and then attempt completion again.\n<feedback>\n${text}\n</feedback>`,
+								})
+								toolResults.push(...formatResponse.imageBlocks(images))
+								this.userMessageContent.push({
+									type: "text",
+									text: `${toolDescription()} Result:`,
+								})
+								this.userMessageContent.push(...toolResults)
+
 								break
 							}
 						} catch (error) {

src/shared/ExtensionMessage.ts

@@ -182,6 +182,7 @@ export type ClineSay =
 	| "new_task_started"
 	| "new_task"
 	| "checkpoint_saved"
+	| "prompt_suggest"
 
 export interface ClineSayTool {
 	tool:

webview-ui/src/components/chat/ChatRow.tsx

@@ -773,6 +773,8 @@ export const ChatRowContent = ({
 							checkpoint={message.checkpoint}
 						/>
 					)
+				case "prompt_suggest":
+					return null
 				default:
 					return (
 						<>

webview-ui/src/components/chat/ChatView.tsx

@@ -236,9 +236,22 @@ const ChatView = ({ isHidden, showAnnouncement, hideAnnouncement, showHistoryVie
 								setTextAreaDisabled(true)
 								setSelectedImages([])
 								setClineAsk(undefined)
+								setPromptSuggest([])
 								setEnableButtons(false)
 							}
 							break
+						case "prompt_suggest": {
+							const isPartial = lastMessage.partial === true
+							if (!isPartial) {
+								try {
+									let temp_suggest = JSON.parse(lastMessage.text ?? "[]")
+									setPromptSuggest(temp_suggest || [])
+								} catch (error) {
+									console.error(error)
+								}
+							}
+							break
+						}
 						case "api_req_finished":
 						case "task":
 						case "error":
@@ -268,6 +281,7 @@ const ChatView = ({ isHidden, showAnnouncement, hideAnnouncement, showHistoryVie
 		if (messages.length === 0) {
 			setTextAreaDisabled(false)
 			setClineAsk(undefined)
+			setPromptSuggest([])
 			setEnableButtons(false)
 			setPrimaryButtonText(undefined)
 			setSecondaryButtonText(undefined)
@@ -343,6 +357,7 @@ const ChatView = ({ isHidden, showAnnouncement, hideAnnouncement, showHistoryVie
 				setSelectedImages([])
 				setClineAsk(undefined)
 				setEnableButtons(false)
+				setPromptSuggest([])
 				// Do not reset mode here as it should persist
 				// setPrimaryButtonText(undefined)
 				// setSecondaryButtonText(undefined)
@@ -413,6 +428,7 @@ const ChatView = ({ isHidden, showAnnouncement, hideAnnouncement, showHistoryVie
 			setClineAsk(undefined)
 			setEnableButtons(false)
 			disableAutoScrollRef.current = false
+			setPromptSuggest([])
 		},
 		[clineAsk, startNewTask],
 	)
@@ -459,6 +475,7 @@ const ChatView = ({ isHidden, showAnnouncement, hideAnnouncement, showHistoryVie
 			setTextAreaDisabled(true)
 			setClineAsk(undefined)
 			setEnableButtons(false)
+			setPromptSuggest([])
 			disableAutoScrollRef.current = false
 		},
 		[clineAsk, startNewTask, isStreaming],