Skip to content

Commit cfe434b

Browse files
committed
refactor(modes): remove import auto-select to avoid conflict with PR #9003
Removes import auto-select logic introduced in this PR: - Removed prevModesForImportRef and snapshot-based detection - Removed customModesRef used only for import logic - Removed auto-select behavior in importModeResult handler PR #9003 implements a better backend-driven approach for import auto-select. This change prevents merge conflicts; we keep create/delete auto-select which is unique to our PR.
1 parent 769e019 commit cfe434b

File tree

1 file changed

+1
-22
lines changed

1 file changed

+1
-22
lines changed

webview-ui/src/components/modes/ModesView.tsx

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -110,15 +110,6 @@ const ModesView = ({ onDone }: ModesViewProps) => {
110110
// Display list that overlays optimistic names
111111
const displayModes = (modes || []).map((m) => (localRenames[m.slug] ? { ...m, name: localRenames[m.slug] } : m))
112112

113-
// Track latest custom modes for import/diff logic
114-
const customModesRef = useRef<readonly ModeConfig[] | undefined>(customModes)
115-
useEffect(() => {
116-
customModesRef.current = customModes
117-
}, [customModes])
118-
119-
// Snapshot of modes before import to detect the newly imported one
120-
const prevModesForImportRef = useRef<readonly ModeConfig[] | undefined>(undefined)
121-
122113
// Direct update functions
123114
const updateAgentPrompt = useCallback(
124115
(mode: Mode, promptData: PromptComponent) => {
@@ -501,18 +492,8 @@ const ModesView = ({ onDone }: ModesViewProps) => {
501492
if (message.error !== "cancelled") {
502493
console.error("Failed to import mode:", message.error)
503494
}
504-
} else {
505-
// On successful import, select the newly imported mode
506-
const before = prevModesForImportRef.current || []
507-
const after = customModesRef.current || []
508-
const added = after.find((m) => !before.some((b) => b.slug === m.slug))
509-
const targetSlug = added?.slug || "code"
510-
if (targetSlug) {
511-
setVisualMode(targetSlug)
512-
switchMode(targetSlug)
513-
checkRulesDirectory(targetSlug)
514-
}
515495
}
496+
// Note: Auto-select after import will be handled by PR #9003
516497
} else if (message.type === "checkRulesDirectoryResult") {
517498
setHasRulesToExport((prev) => ({
518499
...prev,
@@ -1660,8 +1641,6 @@ const ModesView = ({ onDone }: ModesViewProps) => {
16601641
'input[name="importLevel"]:checked',
16611642
) as HTMLInputElement
16621643
)?.value as "global" | "project"
1663-
// Snapshot modes before import to detect the newly imported one
1664-
prevModesForImportRef.current = customModesRef.current
16651644
setIsImporting(true)
16661645
vscode.postMessage({
16671646
type: "importMode",

0 commit comments

Comments
 (0)