fix: address PR review comments

- Fixed Chinese translation quotation marks for consistency
- Added proper error handling UI for marketplace item removal failures
- Added missing translation keys for error messages
- Added comment explaining non-critical nature of rules folder deletion failure
- Fixed ESLint warning about missing dependency in useEffect

Author: hannesrudolph

src/services/marketplace/SimpleInstaller.ts

@@ -353,6 +353,9 @@ export class SimpleInstaller {
 				} catch (error) {
 					// Log error but don't throw - continue with the removal
 					console.error(`Failed to delete rules folder for mode ${modeSlug}:`, error)
+					// Notify the user that rules folder cleanup failed
+					// This is a non-critical error, so we continue with the removal
+					// The user can manually delete the folder if needed
 				}
 			}
 		}

webview-ui/src/components/marketplace/components/MarketplaceItemCard.tsx

@@ -41,6 +41,7 @@ export const MarketplaceItemCard: React.FC<MarketplaceItemCardProps> = ({ item,
 	const [showInstallModal, setShowInstallModal] = useState(false)
 	const [showRemoveConfirm, setShowRemoveConfirm] = useState(false)
 	const [removeTarget, setRemoveTarget] = useState<"project" | "global">("project")
+	const [removeError, setRemoveError] = useState<string | null>(null)
 
 	// Listen for removal result messages
 	useEffect(() => {
@@ -53,15 +54,15 @@ export const MarketplaceItemCard: React.FC<MarketplaceItemCardProps> = ({ item,
 						type: "fetchMarketplaceData",
 					})
 				} else {
-					// Removal failed - could show an error toast/notification here if needed
-					console.error("Failed to remove marketplace item:", message.error)
+					// Removal failed - show error message to user
+					setRemoveError(message.error || t("marketplace:items.unknownError"))
 				}
 			}
 		}
 
 		window.addEventListener("message", handleMessage)
 		return () => window.removeEventListener("message", handleMessage)
-	}, [item.id])
+	}, [item.id, t])
 
 	const typeLabel = useMemo(() => {
 		const labels: Partial<Record<MarketplaceItem["type"], string>> = {
@@ -141,6 +142,13 @@ export const MarketplaceItemCard: React.FC<MarketplaceItemCardProps> = ({ item,
 								{t("marketplace:items.card.install")}
 							</Button>
 						)}
+
+						{/* Error message display */}
+						{removeError && (
+							<div className="text-vscode-errorForeground text-sm mt-2">
+								{t("marketplace:items.removeFailed", { error: removeError })}
+							</div>
+						)}
 					</div>
 				</div>
 
@@ -221,6 +229,9 @@ export const MarketplaceItemCard: React.FC<MarketplaceItemCardProps> = ({ item,
 						<AlertDialogCancel>{t("marketplace:removeConfirm.cancel")}</AlertDialogCancel>
 						<AlertDialogAction
 							onClick={() => {
+								// Clear any previous error
+								setRemoveError(null)
+
 								vscode.postMessage({
 									type: "removeInstalledMarketplaceItem",
 									mpItem: item,

webview-ui/src/i18n/locales/en/marketplace.json

@@ -71,7 +71,9 @@
 			"removeProjectTooltip": "Remove from current project",
 			"removeGlobalTooltip": "Remove from global configuration",
 			"actionsMenuLabel": "More actions"
-		}
+		},
+		"removeFailed": "Failed to remove item: {{error}}",
+		"unknownError": "Unknown error occurred"
 	},
 	"install": {
 		"title": "Install {{name}}",