Skip to content

Commit d1876d6

Browse files
authored
Get rid of "partial" component in names referencing not necessarily partial messages (#4332)
1 parent 6f21103 commit d1876d6

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

src/core/task/Task.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -340,17 +340,17 @@ export class Task extends EventEmitter<ClineEvents> {
340340
await this.saveClineMessages()
341341
}
342342

343-
private async updateClineMessage(partialMessage: ClineMessage) {
343+
private async updateClineMessage(message: ClineMessage) {
344344
const provider = this.providerRef.deref()
345-
await provider?.postMessageToWebview({ type: "partialMessage", partialMessage })
346-
this.emit("message", { action: "updated", message: partialMessage })
345+
await provider?.postMessageToWebview({ type: "messageUpdated", clineMessage: message })
346+
this.emit("message", { action: "updated", message })
347347

348-
const shouldCaptureMessage = partialMessage.partial !== true && CloudService.isEnabled()
348+
const shouldCaptureMessage = message.partial !== true && CloudService.isEnabled()
349349

350350
if (shouldCaptureMessage) {
351351
CloudService.instance.captureEvent({
352352
event: TelemetryEventName.TASK_MESSAGE,
353-
properties: { taskId: this.taskId, message: partialMessage },
353+
properties: { taskId: this.taskId, message },
354354
})
355355
}
356356
}

src/shared/ExtensionMessage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export interface ExtensionMessage {
3535
| "theme"
3636
| "workspaceUpdated"
3737
| "invoke"
38-
| "partialMessage"
38+
| "messageUpdated"
3939
| "mcpServers"
4040
| "enhancedPrompt"
4141
| "commitSearchResults"
@@ -92,7 +92,7 @@ export interface ExtensionMessage {
9292
isActive: boolean
9393
path?: string
9494
}>
95-
partialMessage?: ClineMessage
95+
clineMessage?: ClineMessage
9696
routerModels?: RouterModels
9797
openAiModels?: string[]
9898
ollamaModels?: string[]

webview-ui/src/context/ExtensionStateContext.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,14 +263,14 @@ export const ExtensionStateContextProvider: React.FC<{ children: React.ReactNode
263263
setOpenedTabs(tabs)
264264
break
265265
}
266-
case "partialMessage": {
267-
const partialMessage = message.partialMessage!
266+
case "messageUpdated": {
267+
const clineMessage = message.clineMessage!
268268
setState((prevState) => {
269269
// worth noting it will never be possible for a more up-to-date message to be sent here or in normal messages post since the presentAssistantContent function uses lock
270-
const lastIndex = findLastIndex(prevState.clineMessages, (msg) => msg.ts === partialMessage.ts)
270+
const lastIndex = findLastIndex(prevState.clineMessages, (msg) => msg.ts === clineMessage.ts)
271271
if (lastIndex !== -1) {
272272
const newClineMessages = [...prevState.clineMessages]
273-
newClineMessages[lastIndex] = partialMessage
273+
newClineMessages[lastIndex] = clineMessage
274274
return { ...prevState, clineMessages: newClineMessages }
275275
}
276276
return prevState

0 commit comments

Comments
 (0)