Skip to content

Commit d38a996

Browse files
committed
fix: resolve codebase indexing ignore rules issues (#5655)
- Fix .gitignore files having no effect on indexing by replacing broken single-file logic with proper findGitignoreFiles() usage - Fix .rooignore inconsistency by using global RooIgnoreController instance instead of creating new instances per scan - Fix .rooignore rules being ignored after 'Clear Index Data' by ensuring patterns are reloaded during service recreation - Add comprehensive integration tests covering all three reported issues - Fix VSCode test mocks to support RelativePattern and createFileSystemWatcher - Ensure backward compatibility and proper disposal handling All 346 code-index tests passing with new integration test coverage.
1 parent e84dd0a commit d38a996

File tree

7 files changed

+591
-19
lines changed

7 files changed

+591
-19
lines changed

src/core/ignore/RooIgnoreController.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export class RooIgnoreController {
6060
/**
6161
* Load custom patterns from .rooignore if it exists
6262
*/
63-
private async loadRooIgnore(): Promise<void> {
63+
public async loadRooIgnore(): Promise<void> {
6464
try {
6565
// Reset ignore instance to prevent duplicate patterns
6666
this.ignoreInstance = ignore()
@@ -183,7 +183,7 @@ export class RooIgnoreController {
183183
* Clean up resources when the controller is no longer needed
184184
*/
185185
dispose(): void {
186-
this.disposables.forEach((d) => d.dispose())
186+
this.disposables.forEach((d) => d?.dispose?.())
187187
this.disposables = []
188188
}
189189

0 commit comments

Comments
 (0)