refactor(providers): remove createOpenAIClientWithErrorHandling; construct clients directly and keep request-time error mapping via handleOpenAIError

Author: daniel-lxs

src/api/providers/huggingface.ts

@@ -8,7 +8,7 @@ import type { SingleCompletionHandler, ApiHandlerCreateMessageMetadata } from ".
 import { DEFAULT_HEADERS } from "./constants"
 import { BaseProvider } from "./base-provider"
 import { getHuggingFaceModels, getCachedHuggingFaceModels } from "./fetchers/huggingface"
-import { createOpenAIClientWithErrorHandling, handleOpenAIError } from "./utils/openai-error-handler"
+import { handleOpenAIError } from "./utils/openai-error-handler"
 
 export class HuggingFaceHandler extends BaseProvider implements SingleCompletionHandler {
 	private client: OpenAI
@@ -23,15 +23,11 @@ export class HuggingFaceHandler extends BaseProvider implements SingleCompletion
 			throw new Error("Hugging Face API key is required")
 		}
 
-		this.client = createOpenAIClientWithErrorHandling(
-			() =>
-				new OpenAI({
-					baseURL: "https://router.huggingface.co/v1",
-					apiKey: this.options.huggingFaceApiKey,
-					defaultHeaders: DEFAULT_HEADERS,
-				}),
-			"HuggingFace",
-		)
+		this.client = new OpenAI({
+			baseURL: "https://router.huggingface.co/v1",
+			apiKey: this.options.huggingFaceApiKey,
+			defaultHeaders: DEFAULT_HEADERS,
+		})
 
 		// Try to get cached models first
 		this.modelCache = getCachedHuggingFaceModels()

src/api/providers/openai-native.ts

@@ -22,7 +22,6 @@ import { getModelParams } from "../transform/model-params"
 
 import { BaseProvider } from "./base-provider"
 import type { SingleCompletionHandler, ApiHandlerCreateMessageMetadata } from "../index"
-import { createOpenAIClientWithErrorHandling } from "./utils/openai-error-handler"
 
 export type OpenAiNativeModel = ReturnType<OpenAiNativeHandler["getModel"]>
 
@@ -61,10 +60,7 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 		}
 		const apiKey = this.options.openAiNativeApiKey ?? "not-provided"
 
-		this.client = createOpenAIClientWithErrorHandling(
-			() => new OpenAI({ baseURL: this.options.openAiNativeBaseUrl, apiKey }),
-			"OpenAI Native",
-		)
+		this.client = new OpenAI({ baseURL: this.options.openAiNativeBaseUrl, apiKey })
 	}
 
 	private normalizeUsage(usage: any, model: OpenAiNativeModel): ApiStreamUsageChunk | undefined {

src/api/providers/utils/openai-error-handler.ts

@@ -27,18 +27,3 @@ export function handleOpenAIError(error: unknown, providerName: string): Error {
 	// If it's not even an Error object, wrap it
 	return new Error(`${providerName} error: ${String(error)}`)
 }
-
-/**
- * Wraps an OpenAI client instantiation with error handling
- * @param createClient - Function that creates the OpenAI client
- * @param providerName - The name of the provider for error messages
- * @returns The created client
- * @throws User-friendly error if client creation fails
- */
-export function createOpenAIClientWithErrorHandling<T>(createClient: () => T, providerName: string): T {
-	try {
-		return createClient()
-	} catch (error) {
-		throw handleOpenAIError(error, providerName)
-	}
-}