refactor: remove updateCodebaseIndexConfig and integrate max search results into saveCodeIndexSettingsAtomic

- Removed updateCodebaseIndexConfig message type and handler as per PR feedback
- Added codebaseIndexSearchMaxResults to codeIndexSettings type in WebviewMessage.ts
- Updated saveCodeIndexSettingsAtomic to save codebaseIndexSearchMaxResults
- Fixed SettingsView.tsx to use codebaseIndexEnabled message instead of updateCodebaseIndexConfig

Author: daniel-lxs

src/core/webview/webviewMessageHandler.ts

@@ -1130,23 +1130,6 @@ export const webviewMessageHandler = async (
 
 			await provider.postStateToWebview()
 			break
-		case "updateCodebaseIndexConfig":
-			// Update the entire codebaseIndexConfig with the provided configuration
-			if (message.codebaseIndexConfig) {
-				const currentConfig = getGlobalState("codebaseIndexConfig") || {}
-				await updateGlobalState("codebaseIndexConfig", {
-					...currentConfig,
-					...message.codebaseIndexConfig,
-				})
-
-				// Notify the code index manager about the change
-				if (provider.codeIndexManager) {
-					await provider.codeIndexManager.handleSettingsChange()
-				}
-
-				await provider.postStateToWebview()
-			}
-			break
 		case "language":
 			changeLanguage(message.text ?? "en")
 			await updateGlobalState("language", message.text as Language)
@@ -1857,6 +1840,7 @@ export const webviewMessageHandler = async (
 					codebaseIndexEmbedderModelId: settings.codebaseIndexEmbedderModelId,
 					codebaseIndexOpenAiCompatibleBaseUrl: settings.codebaseIndexOpenAiCompatibleBaseUrl,
 					codebaseIndexOpenAiCompatibleModelDimension: settings.codebaseIndexOpenAiCompatibleModelDimension,
+					codebaseIndexSearchMaxResults: settings.codebaseIndexSearchMaxResults,
 				}
 
 				// Save global state first

src/shared/WebviewMessage.ts

@@ -7,7 +7,6 @@ import type {
 	InstallMarketplaceItemOptions,
 	MarketplaceItem,
 	ShareVisibility,
-	CodebaseIndexConfig,
 } from "@roo-code/types"
 import { marketplaceItemSchema } from "@roo-code/types"
 
@@ -142,7 +141,6 @@ export interface WebviewMessage {
 		| "humanRelayCancel"
 		| "browserToolEnabled"
 		| "codebaseIndexEnabled"
-		| "updateCodebaseIndexConfig"
 		| "telemetrySetting"
 		| "showRooIgnoredFiles"
 		| "testBrowserConnection"
@@ -227,7 +225,6 @@ export interface WebviewMessage {
 	visibility?: ShareVisibility // For share visibility
 	hasContent?: boolean // For checkRulesDirectoryResult
 	checkOnly?: boolean // For deleteCustomMode check
-	codebaseIndexConfig?: CodebaseIndexConfig // For updateCodebaseIndexConfig
 	codeIndexSettings?: {
 		// Global state settings
 		codebaseIndexEnabled: boolean
@@ -237,6 +234,7 @@ export interface WebviewMessage {
 		codebaseIndexEmbedderModelId: string
 		codebaseIndexOpenAiCompatibleBaseUrl?: string
 		codebaseIndexOpenAiCompatibleModelDimension?: number
+		codebaseIndexSearchMaxResults?: number
 
 		// Secret settings
 		codeIndexOpenAiKey?: string

webview-ui/src/components/settings/SettingsView.tsx

@@ -321,7 +321,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 			vscode.postMessage({ type: "upsertApiConfiguration", text: currentApiConfigName, apiConfiguration })
 			vscode.postMessage({ type: "telemetrySetting", text: telemetrySetting })
 			if (codebaseIndexConfig) {
-				vscode.postMessage({ type: "updateCodebaseIndexConfig", codebaseIndexConfig: codebaseIndexConfig })
+				vscode.postMessage({ type: "codebaseIndexEnabled", bool: codebaseIndexConfig.codebaseIndexEnabled })
 			}
 			vscode.postMessage({ type: "profileThresholds", values: profileThresholds })
 			setChangeDetected(false)