PR feedback

Author: mrubens

packages/ipc/README.md

@@ -41,6 +41,11 @@ Resumes a task from history.
 
 - `data`: Task ID to resume (string)
 
+**Error Handling:**
+
+- If the task ID is not found in history, the command will fail gracefully without crashing the IPC server
+- Errors are logged for debugging purposes but do not propagate to the client
+
 ## Usage Example
 
 ```typescript

packages/types/src/__tests__/ipc.test.ts

@@ -15,6 +15,25 @@ describe("IPC Types", () => {
 				expect(actualCommands).toContain(command)
 			})
 		})
+
+		describe("Error Handling", () => {
+			it("should handle ResumeTask command gracefully when task not found", () => {
+				// This test verifies the schema validation - the actual error handling
+				// for invalid task IDs is tested at the API level, not the schema level
+				const resumeTaskCommand = {
+					commandName: TaskCommandName.ResumeTask,
+					data: "non-existent-task-id",
+				}
+
+				const result = taskCommandSchema.safeParse(resumeTaskCommand)
+				expect(result.success).toBe(true)
+
+				if (result.success) {
+					expect(result.data.commandName).toBe("ResumeTask")
+					expect(result.data.data).toBe("non-existent-task-id")
+				}
+			})
+		})
 	})
 
 	describe("taskCommandSchema", () => {

src/extension/api.ts

@@ -80,7 +80,14 @@ export class API extends EventEmitter<RooCodeEvents> implements RooCodeAPI {
 						break
 					case TaskCommandName.ResumeTask:
 						this.log(`[API] ResumeTask -> ${data}`)
-						await this.resumeTask(data)
+						try {
+							await this.resumeTask(data)
+						} catch (error) {
+							const errorMessage = error instanceof Error ? error.message : String(error)
+							this.log(`[API] ResumeTask failed for taskId ${data}: ${errorMessage}`)
+							// Don't rethrow - we want to prevent IPC server crashes
+							// The error is logged for debugging purposes
+						}
 						break
 				}
 			})