fix: return proper error message when workspace is null in importModeWithRules

hannesrudolph · hannesrudolph · commit d62d372a8f92 · 2025-06-25T15:01:16.000-06:00
- Fixed error handling in importModeWithRules to return 'No workspace found' error instead of letting path.join() throw when workspace is null
- This fixes the failing unit test in CustomModesManager.spec.ts
diff --git a/src/core/config/CustomModesManager.ts b/src/core/config/CustomModesManager.ts
@@ -625,8 +625,7 @@ export class CustomModesManager {
 				if (source === "project" && rulesFiles && Array.isArray(rulesFiles)) {
 					const workspacePath = getWorkspacePath()
 					if (!workspacePath) {
-						logger.warn("No workspace found for project-level import, skipping rules files")
-						continue
+						return { success: false, error: "No workspace found" }
 					}
 
 					// First, remove the existing rules folder for this mode if it exists

Original file line number	Diff line number	Diff line change
`@@ -625,8 +625,7 @@ export class CustomModesManager {`
`625`	`625`	`if (source === "project" && rulesFiles && Array.isArray(rulesFiles)) {`
`626`	`626`	`const workspacePath = getWorkspacePath()`
`627`	`627`	`if (!workspacePath) {`
`628`		`- logger.warn("No workspace found for project-level import, skipping rules files")`
`629`		`- continue`
	`628`	`+ return { success: false, error: "No workspace found" }`
`630`	`629`	`}`
`631`	`630`
`632`	`631`	`// First, remove the existing rules folder for this mode if it exists`