refactor: simplify organizationSettingsVersion to use number with -1 default

- Change organizationSettingsVersion from number | undefined to number with default -1
- Simplify fetch check in MarketplaceView to just currentVersion !== lastOrganizationSettingsVersion
- Update test to verify -1 behavior instead of undefined behavior
- All tests pass and TypeScript compilation successful

Author: roomote

webview-ui/src/components/marketplace/MarketplaceView.tsx

@@ -27,11 +27,7 @@ export function MarketplaceView({ stateManager, onDone, targetTab }: Marketplace
 	// Track when organization settings version changes and trigger refresh
 	useEffect(() => {
 		const currentVersion = extensionState?.organizationSettingsVersion ?? -1
-		if (
-			currentVersion !== -1 &&
-			lastOrganizationSettingsVersion !== -1 &&
-			currentVersion !== lastOrganizationSettingsVersion
-		) {
+		if (currentVersion !== lastOrganizationSettingsVersion) {
 			// Organization settings version changed, refresh marketplace data
 			vscode.postMessage({
 				type: "fetchMarketplaceData",

webview-ui/src/components/marketplace/__tests__/MarketplaceView.spec.tsx

@@ -104,11 +104,11 @@ describe("MarketplaceView", () => {
 		})
 	})
 
-	it("should not trigger fetchMarketplaceData when organization settings version is undefined", async () => {
-		// Start with undefined version
+	it("should trigger fetchMarketplaceData when organization settings version changes from -1", async () => {
+		// Start with -1 version (default)
 		mockExtensionState = {
 			...mockExtensionState,
-			organizationSettingsVersion: undefined,
+			organizationSettingsVersion: -1,
 		}
 
 		const { rerender } = render(
@@ -117,6 +117,9 @@ describe("MarketplaceView", () => {
 			</ExtensionStateContext.Provider>,
 		)
 
+		// Clear any initial calls
+		vi.clearAllMocks()
+
 		// Update to a defined version
 		mockExtensionState = {
 			...mockExtensionState,
@@ -129,9 +132,9 @@ describe("MarketplaceView", () => {
 			</ExtensionStateContext.Provider>,
 		)
 
-		// Should not trigger fetch when transitioning from undefined
+		// Should trigger fetch when transitioning from -1 to 1
 		await waitFor(() => {
-			expect(vscode.postMessage).not.toHaveBeenCalledWith({
+			expect(vscode.postMessage).toHaveBeenCalledWith({
 				type: "fetchMarketplaceData",
 			})
 		})

webview-ui/src/context/ExtensionStateContext.tsx

@@ -35,7 +35,7 @@ export interface ExtensionStateContextType extends ExtensionState {
 	openedTabs: Array<{ label: string; isActive: boolean; path?: string }>
 	commands: Command[]
 	organizationAllowList: OrganizationAllowList
-	organizationSettingsVersion?: number
+	organizationSettingsVersion: number
 	cloudIsAuthenticated: boolean
 	sharingEnabled: boolean
 	maxConcurrentFileReads?: number
@@ -227,7 +227,7 @@ export const ExtensionStateContextProvider: React.FC<{ children: React.ReactNode
 		cloudIsAuthenticated: false,
 		sharingEnabled: false,
 		organizationAllowList: ORGANIZATION_ALLOW_ALL,
-		organizationSettingsVersion: undefined,
+		organizationSettingsVersion: -1,
 		autoCondenseContext: true,
 		autoCondenseContextPercent: 100,
 		profileThresholds: {},
@@ -394,7 +394,7 @@ export const ExtensionStateContextProvider: React.FC<{ children: React.ReactNode
 		screenshotQuality: state.screenshotQuality,
 		routerModels: extensionRouterModels,
 		cloudIsAuthenticated: state.cloudIsAuthenticated ?? false,
-		organizationSettingsVersion: state.organizationSettingsVersion,
+		organizationSettingsVersion: state.organizationSettingsVersion ?? -1,
 		marketplaceItems,
 		marketplaceInstalledMetadata,
 		profileThresholds: state.profileThresholds ?? {},