fix: update service-factory tests to check for translation keys instead of hardcoded messages

Author: daniel-lxs

src/services/code-index/__tests__/service-factory.spec.ts

@@ -146,7 +146,7 @@ describe("CodeIndexServiceFactory", () => {
 			mockConfigManager.getConfig.mockReturnValue(testConfig as any)
 
 			// Act & Assert
-			expect(() => factory.createEmbedder()).toThrow("OpenAI configuration missing for embedder creation")
+			expect(() => factory.createEmbedder()).toThrow("serviceFactory.openAiConfigMissing")
 		})
 
 		it("should throw error when Ollama base URL is missing", () => {
@@ -161,7 +161,7 @@ describe("CodeIndexServiceFactory", () => {
 			mockConfigManager.getConfig.mockReturnValue(testConfig as any)
 
 			// Act & Assert
-			expect(() => factory.createEmbedder()).toThrow("Ollama configuration missing for embedder creation")
+			expect(() => factory.createEmbedder()).toThrow("serviceFactory.ollamaConfigMissing")
 		})
 
 		it("should pass model ID to OpenAI Compatible embedder when using OpenAI Compatible provider", () => {
@@ -224,9 +224,7 @@ describe("CodeIndexServiceFactory", () => {
 			mockConfigManager.getConfig.mockReturnValue(testConfig as any)
 
 			// Act & Assert
-			expect(() => factory.createEmbedder()).toThrow(
-				"OpenAI Compatible configuration missing for embedder creation",
-			)
+			expect(() => factory.createEmbedder()).toThrow("serviceFactory.openAiCompatibleConfigMissing")
 		})
 
 		it("should throw error when OpenAI Compatible API key is missing", () => {
@@ -242,9 +240,7 @@ describe("CodeIndexServiceFactory", () => {
 			mockConfigManager.getConfig.mockReturnValue(testConfig as any)
 
 			// Act & Assert
-			expect(() => factory.createEmbedder()).toThrow(
-				"OpenAI Compatible configuration missing for embedder creation",
-			)
+			expect(() => factory.createEmbedder()).toThrow("serviceFactory.openAiCompatibleConfigMissing")
 		})
 
 		it("should throw error when OpenAI Compatible options are missing", () => {
@@ -257,9 +253,7 @@ describe("CodeIndexServiceFactory", () => {
 			mockConfigManager.getConfig.mockReturnValue(testConfig as any)
 
 			// Act & Assert
-			expect(() => factory.createEmbedder()).toThrow(
-				"OpenAI Compatible configuration missing for embedder creation",
-			)
+			expect(() => factory.createEmbedder()).toThrow("serviceFactory.openAiCompatibleConfigMissing")
 		})
 
 		it("should create GeminiEmbedder when using Gemini provider", () => {
@@ -290,7 +284,7 @@ describe("CodeIndexServiceFactory", () => {
 			mockConfigManager.getConfig.mockReturnValue(testConfig as any)
 
 			// Act & Assert
-			expect(() => factory.createEmbedder()).toThrow("Gemini configuration missing for embedder creation")
+			expect(() => factory.createEmbedder()).toThrow("serviceFactory.geminiConfigMissing")
 		})
 
 		it("should throw error when Gemini options are missing", () => {
@@ -302,7 +296,7 @@ describe("CodeIndexServiceFactory", () => {
 			mockConfigManager.getConfig.mockReturnValue(testConfig as any)
 
 			// Act & Assert
-			expect(() => factory.createEmbedder()).toThrow("Gemini configuration missing for embedder creation")
+			expect(() => factory.createEmbedder()).toThrow("serviceFactory.geminiConfigMissing")
 		})
 
 		it("should throw error for invalid embedder provider", () => {
@@ -314,7 +308,7 @@ describe("CodeIndexServiceFactory", () => {
 			mockConfigManager.getConfig.mockReturnValue(testConfig as any)
 
 			// Act & Assert
-			expect(() => factory.createEmbedder()).toThrow("Invalid embedder type configured: invalid-provider")
+			expect(() => factory.createEmbedder()).toThrow("serviceFactory.invalidEmbedderType")
 		})
 	})
 
@@ -478,7 +472,7 @@ describe("CodeIndexServiceFactory", () => {
 
 			// Act & Assert
 			expect(() => factory.createVectorStore()).toThrow(
-				"Could not determine vector dimension for model 'custom-model' with provider 'openai-compatible'. Please ensure the 'Embedding Dimension' is correctly set in the \x1b[1m\x1b[4mOpenAI-Compatible\x1b[0m provider settings.",
+				"serviceFactory.vectorDimensionNotDeterminedOpenAiCompatible",
 			)
 		})
 
@@ -500,7 +494,7 @@ describe("CodeIndexServiceFactory", () => {
 
 			// Act & Assert
 			expect(() => factory.createVectorStore()).toThrow(
-				"Could not determine vector dimension for model 'unknown-model' with provider 'openai-compatible'. Please ensure the 'Embedding Dimension' is correctly set in the \x1b[1m\x1b[4mOpenAI-Compatible\x1b[0m provider settings.",
+				"serviceFactory.vectorDimensionNotDeterminedOpenAiCompatible",
 			)
 		})
 
@@ -564,9 +558,7 @@ describe("CodeIndexServiceFactory", () => {
 			mockGetModelDimension.mockReturnValue(undefined)
 
 			// Act & Assert
-			expect(() => factory.createVectorStore()).toThrow(
-				"Could not determine vector dimension for model 'unknown-model' with provider 'openai'. Check model profiles or configuration.",
-			)
+			expect(() => factory.createVectorStore()).toThrow("serviceFactory.vectorDimensionNotDetermined")
 		})
 
 		it("should throw error when Qdrant URL is missing", () => {
@@ -581,7 +573,7 @@ describe("CodeIndexServiceFactory", () => {
 			mockGetModelDimension.mockReturnValue(1536)
 
 			// Act & Assert
-			expect(() => factory.createVectorStore()).toThrow("Qdrant URL missing for vector store creation")
+			expect(() => factory.createVectorStore()).toThrow("serviceFactory.qdrantUrlMissing")
 		})
 	})
 
@@ -751,7 +743,7 @@ describe("CodeIndexServiceFactory", () => {
 			await expect(async () => {
 				const embedder = factory.createEmbedder()
 				await factory.validateEmbedder(embedder)
-			}).rejects.toThrow("OpenAI configuration missing for embedder creation")
+			}).rejects.toThrow("serviceFactory.openAiConfigMissing")
 		})
 
 		it("should return error for unknown embedder provider", async () => {
@@ -764,7 +756,7 @@ describe("CodeIndexServiceFactory", () => {
 
 			// Act & Assert
 			// This should throw when trying to create the embedder
-			expect(() => factory.createEmbedder()).toThrow("Invalid embedder type configured: unknown-provider")
+			expect(() => factory.createEmbedder()).toThrow("serviceFactory.invalidEmbedderType")
 		})
 	})
 })