fix: simplify error handling in manager.ts and update tests to expect translation keys

- Remove complex fallback logic from manager.ts since errors should be translated at source
- Update tests to expect translation keys as returned by t() function in test environment
- This ensures consistent behavior between test and production environments

Author: daniel-lxs

src/services/code-index/__tests__/manager.spec.ts

@@ -308,6 +308,7 @@ describe("CodeIndexManager - handleSettingsChange regression", () => {
 			})
 
 			// Act & Assert
+			// In test environment, t() returns the key
 			await expect((manager as any)._recreateServices()).rejects.toThrow(
 				"embeddings:validation.authenticationFailed",
 			)
@@ -331,6 +332,7 @@ describe("CodeIndexManager - handleSettingsChange regression", () => {
 			})
 
 			// Act & Assert
+			// In test environment, t() returns the key
 			await expect((manager as any)._recreateServices()).rejects.toThrow(
 				"embeddings:validation.configurationError",
 			)

src/services/code-index/manager.ts

@@ -263,15 +263,8 @@ export class CodeIndexManager {
 		const validationResult = await this._serviceFactory.validateEmbedder(embedder)
 		if (!validationResult.valid) {
 			const errorMessage = validationResult.error || "Embedder configuration validation failed"
-			// Always attempt translation, use original as fallback
-			const translatedMessage = t(errorMessage)
-
-			// If i18next returns the key, it means no translation was found.
-			// In that case, we should use the original, untranslated error message.
-			const finalMessage = translatedMessage === errorMessage ? errorMessage : translatedMessage
-
-			this._stateManager.setSystemState("Error", finalMessage)
-			throw new Error(finalMessage)
+			this._stateManager.setSystemState("Error", errorMessage)
+			throw new Error(errorMessage)
 		}
 
 		// (Re)Initialize orchestrator