Skip to content

Commit e1d3022

Browse files
hannesrudolphdaniel-lxs
authored andcommitted
fix: address bot review comments
- Fix typo in zh-TW translation (duplicate '預' character) - Fix typo in Hindi translation (incorrect character 'ਹੈ' to 'है') - Fix inconsistent default value in webviewMessageHandler.ts (100 to 50) - Remove unused 'diagnosticCount' variable in diagnostics/index.ts
1 parent 2a2a66b commit e1d3022

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

src/core/webview/webviewMessageHandler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1261,7 +1261,7 @@ export const webviewMessageHandler = async (
12611261
await provider.postStateToWebview()
12621262
break
12631263
case "maxDiagnosticMessages":
1264-
await updateGlobalState("maxDiagnosticMessages", message.value ?? 100)
1264+
await updateGlobalState("maxDiagnosticMessages", message.value ?? 50)
12651265
await provider.postStateToWebview()
12661266
break
12671267
case "setHistoryPreviewCollapsed": // Add the new case handler

src/integrations/diagnostics/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ export async function diagnosticsToProblemsString(
8585
const documents = new Map<vscode.Uri, vscode.TextDocument>()
8686
const fileStats = new Map<vscode.Uri, vscode.FileStat>()
8787
let result = ""
88-
let diagnosticCount = 0
8988

9089
// If we have a limit, we need to collect all diagnostics first, sort by severity, then limit
9190
if (maxDiagnosticMessages && maxDiagnosticMessages > 0) {
@@ -213,7 +212,6 @@ export async function diagnosticsToProblemsString(
213212
} catch {
214213
result += `\n- [${source}${label}] ${line} | (unavailable) : ${diagnostic.message}`
215214
}
216-
diagnosticCount++
217215
}
218216
}
219217
}

webview-ui/src/i18n/locales/hi/settings.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/zh-TW/settings.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)