chore(browser): remove legacy browserCapability helper and tests; rely solely on supportsImages gating

Author: hannesrudolph

packages/types/src/model.ts

@@ -57,7 +57,6 @@ export const modelInfoSchema = z.object({
 	maxThinkingTokens: z.number().nullish(),
 	contextWindow: z.number(),
 	supportsImages: z.boolean().optional(),
-
 	supportsPromptCache: z.boolean(),
 	// Capability flag to indicate whether the model supports an output verbosity parameter
 	supportsVerbosity: z.boolean().optional(),

src/core/task/Task.ts

@@ -53,7 +53,6 @@ import { ClineApiReqCancelReason, ClineApiReqInfo } from "../../shared/Extension
 import { getApiMetrics, hasTokenUsageChanged } from "../../shared/getApiMetrics"
 import { ClineAskResponse } from "../../shared/WebviewMessage"
 import { defaultModeSlug, getModeBySlug, getGroupName } from "../../shared/modes"
-import { computeCanUseBrowserTool } from "../../shared/browserCapability"
 import { DiffStrategy } from "../../shared/tools"
 import { EXPERIMENT_IDS, experiments } from "../../shared/experiments"
 import { getModelMaxOutputTokens } from "../../shared/api"
@@ -2420,12 +2419,11 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 			const modeConfig = getModeBySlug(mode ?? defaultModeSlug, customModes)
 			const modeSupportsBrowser = modeConfig?.groups.some((group) => getGroupName(group) === "browser") ?? false
 
-			const canUseBrowserTool = computeCanUseBrowserTool(
-				this.api.getModel().info,
-				modeSupportsBrowser,
-				browserToolEnabled,
-				apiConfiguration,
-			)
+			// Check if model supports browser capability (images)
+			const modelInfo = this.api.getModel().info
+			const modelSupportsBrowser = (modelInfo as any)?.supportsImages === true
+
+			const canUseBrowserTool = modelSupportsBrowser && modeSupportsBrowser && (browserToolEnabled ?? true)
 
 			return SYSTEM_PROMPT(
 				provider.context,

src/core/webview/generateSystemPrompt.ts

@@ -3,7 +3,6 @@ import { WebviewMessage } from "../../shared/WebviewMessage"
 import { defaultModeSlug, getModeBySlug, getGroupName } from "../../shared/modes"
 import { buildApiHandler } from "../../api"
 import { experiments as experimentsModule, EXPERIMENT_IDS } from "../../shared/experiments"
-import { computeCanUseBrowserTool } from "../../shared/browserCapability"
 
 import { SYSTEM_PROMPT } from "../prompts/system"
 import { MultiSearchReplaceDiffStrategy } from "../diff/strategies/multi-search-replace"
@@ -61,14 +60,12 @@ export const generateSystemPrompt = async (provider: ClineProvider, message: Web
 	const modeConfig = getModeBySlug(mode, customModes)
 	const modeSupportsBrowser = modeConfig?.groups.some((group) => getGroupName(group) === "browser") ?? false
 
+	// Check if model supports browser capability (images)
+	const modelSupportsBrowser = modelInfo && (modelInfo as any)?.supportsImages === true
+
 	// Only enable browser tools if the model supports it, the mode includes browser tools,
 	// and browser tools are enabled in settings
-	const canUseBrowserTool = computeCanUseBrowserTool(
-		modelInfo,
-		modeSupportsBrowser,
-		browserToolEnabled,
-		apiConfiguration,
-	)
+	const canUseBrowserTool = modelSupportsBrowser && modeSupportsBrowser && (browserToolEnabled ?? true)
 
 	const systemPrompt = await SYSTEM_PROMPT(
 		provider.context,

src/shared/__tests__/browserCapability.spec.ts

@@ -28,7 +28,11 @@ const RooTips = () => {
 				<Trans
 					i18nKey="chat:about"
 					components={{
-						DocsLink: <span>the docs</span>,
+						DocsLink: (
+							<a href={buildDocLink("", "welcome")} target="_blank" rel="noopener noreferrer">
+								the docs
+							</a>
+						),
 					}}
 				/>
 			</p>

src/shared/browserCapability.ts

@@ -39,8 +39,8 @@ describe("RooTips Component", () => {
 		})
 
 		test("renders only the top two tips", () => {
-			// Ensure only the two tip links are present (docs text is no longer a link)
-			expect(screen.getAllByRole("link")).toHaveLength(2)
+			// Ensure only two tips are present plus the docs link in the Trans component (3 total links)
+			expect(screen.getAllByRole("link")).toHaveLength(3)
 		})
 	})
 })