onValueCommit -> onValueChange

Author: cte

webview-ui/src/components/settings/AdvancedSettings.tsx

@@ -51,7 +51,7 @@ export const AdvancedSettings = ({
 								max={60}
 								step={1}
 								value={[rateLimitSeconds]}
-								onValueCommit={([value]) => setCachedStateField("rateLimitSeconds", value)}
+								onValueChange={([value]) => setCachedStateField("rateLimitSeconds", value)}
 							/>
 							<span className="w-10">{rateLimitSeconds}s</span>
 						</div>
@@ -141,7 +141,7 @@ export const AdvancedSettings = ({
 									max={1}
 									step={0.005}
 									value={[fuzzyMatchThreshold ?? 1.0]}
-									onValueCommit={([value]) => setCachedStateField("fuzzyMatchThreshold", value)}
+									onValueChange={([value]) => setCachedStateField("fuzzyMatchThreshold", value)}
 								/>
 								<span className="w-10">{Math.round((fuzzyMatchThreshold || 1) * 100)}%</span>
 							</div>

webview-ui/src/components/settings/AutoApproveSettings.tsx

@@ -98,7 +98,7 @@ export const AutoApproveSettings = ({
 									max={5000}
 									step={100}
 									value={[writeDelayMs]}
-									onValueCommit={(value) => setCachedStateField("writeDelayMs", value)}
+									onValueChange={(value) => setCachedStateField("writeDelayMs", value)}
 									data-testid="write-delay-slider"
 								/>
 								<span className="w-20">{writeDelayMs}ms</span>
@@ -144,7 +144,7 @@ export const AutoApproveSettings = ({
 									max={100}
 									step={1}
 									value={[requestDelaySeconds]}
-									onValueCommit={(value) => setCachedStateField("requestDelaySeconds", value)}
+									onValueChange={(value) => setCachedStateField("requestDelaySeconds", value)}
 									data-testid="request-delay-slider"
 								/>
 								<span className="w-20">{requestDelaySeconds}s</span>

webview-ui/src/components/settings/BrowserSettings.tsx

@@ -167,7 +167,7 @@ export const BrowserSettings = ({
 									max={100}
 									step={1}
 									value={[screenshotQuality ?? 75]}
-									onValueCommit={([value]) => setCachedStateField("screenshotQuality", value)}
+									onValueChange={([value]) => setCachedStateField("screenshotQuality", value)}
 								/>
 								<span className="w-10">{screenshotQuality ?? 75}%</span>
 							</div>

webview-ui/src/components/settings/ContextManagementSettings.tsx

@@ -44,7 +44,7 @@ export const ContextManagementSettings = ({
 							max={500}
 							step={1}
 							value={[maxOpenTabsContext ?? 20]}
-							onValueCommit={([value]) => setCachedStateField("maxOpenTabsContext", value)}
+							onValueChange={([value]) => setCachedStateField("maxOpenTabsContext", value)}
 							data-testid="open-tabs-limit-slider"
 						/>
 						<span className="w-10">{maxOpenTabsContext ?? 20}</span>
@@ -64,7 +64,7 @@ export const ContextManagementSettings = ({
 							max={500}
 							step={1}
 							value={[maxWorkspaceFiles ?? 200]}
-							onValueCommit={([value]) => setCachedStateField("maxWorkspaceFiles", value)}
+							onValueChange={([value]) => setCachedStateField("maxWorkspaceFiles", value)}
 							data-testid="workspace-files-limit-slider"
 						/>
 						<span className="w-10">{maxWorkspaceFiles ?? 200}</span>

webview-ui/src/components/settings/NotificationSettings.tsx

@@ -59,7 +59,7 @@ export const NotificationSettings = ({
 									max={2.0}
 									step={0.01}
 									value={[ttsSpeed ?? 1.0]}
-									onValueCommit={([value]) => setCachedStateField("ttsSpeed", value)}
+									onValueChange={([value]) => setCachedStateField("ttsSpeed", value)}
 									data-testid="tts-speed-slider"
 								/>
 								<span className="w-10">{((ttsSpeed ?? 1.0) * 100).toFixed(0)}%</span>
@@ -92,7 +92,7 @@ export const NotificationSettings = ({
 									max={1}
 									step={0.01}
 									value={[soundVolume ?? 0.5]}
-									onValueCommit={([value]) => setCachedStateField("soundVolume", value)}
+									onValueChange={([value]) => setCachedStateField("soundVolume", value)}
 									data-testid="sound-volume-slider"
 								/>
 								<span className="w-10">{((soundVolume ?? 0.5) * 100).toFixed(0)}%</span>

webview-ui/src/components/settings/TemperatureControl.tsx

@@ -56,7 +56,7 @@ export const TemperatureControl = ({ value, onChange, maxValue = 1 }: Temperatur
 								max={maxValue}
 								step={0.01}
 								value={[inputValue ?? 0]}
-								onValueCommit={([value]) => setInputValue(value)}
+								onValueChange={([value]) => setInputValue(value)}
 							/>
 							<span className="w-10">{inputValue}</span>
 						</div>

webview-ui/src/components/settings/TerminalSettings.tsx

@@ -42,7 +42,7 @@ export const TerminalSettings = ({
 							max={5000}
 							step={100}
 							value={[terminalOutputLineLimit ?? 500]}
-							onValueCommit={([value]) => setCachedStateField("terminalOutputLineLimit", value)}
+							onValueChange={([value]) => setCachedStateField("terminalOutputLineLimit", value)}
 							data-testid="terminal-output-limit-slider"
 						/>
 						<span className="w-10">{terminalOutputLineLimit ?? 500}</span>
@@ -62,7 +62,7 @@ export const TerminalSettings = ({
 							max={60000}
 							step={1000}
 							value={[terminalShellIntegrationTimeout ?? 5000]}
-							onValueCommit={([value]) =>
+							onValueChange={([value]) =>
 								setCachedStateField(
 									"terminalShellIntegrationTimeout",
 									Math.min(60000, Math.max(1000, value)),

webview-ui/src/components/settings/ThinkingBudget.tsx

@@ -46,7 +46,7 @@ export const ThinkingBudget = ({ apiConfiguration, setApiConfigurationField, mod
 						max={tokensMax}
 						step={1024}
 						value={[tokens]}
-						onValueCommit={([value]) => setApiConfigurationField("modelMaxTokens", value)}
+						onValueChange={([value]) => setApiConfigurationField("modelMaxTokens", value)}
 					/>
 					<div className="w-12 text-sm text-center">{tokens}</div>
 				</div>
@@ -59,7 +59,7 @@ export const ThinkingBudget = ({ apiConfiguration, setApiConfigurationField, mod
 						max={thinkingTokensMax}
 						step={1024}
 						value={[thinkingTokens]}
-						onValueCommit={([value]) => setApiConfigurationField("modelMaxThinkingTokens", value)}
+						onValueChange={([value]) => setApiConfigurationField("modelMaxThinkingTokens", value)}
 					/>
 					<div className="w-12 text-sm text-center">{thinkingTokens}</div>
 				</div>

webview-ui/src/components/settings/__tests__/ContextManagementSettings.test.tsx

@@ -14,11 +14,11 @@ global.ResizeObserver = MockResizeObserver
 
 jest.mock("@/components/ui", () => ({
 	...jest.requireActual("@/components/ui"),
-	Slider: ({ value, onValueCommit, "data-testid": dataTestId }: any) => (
+	Slider: ({ value, onValueChange, "data-testid": dataTestId }: any) => (
 		<input
 			type="range"
 			value={value[0]}
-			onChange={(e) => onValueCommit([parseFloat(e.target.value)])}
+			onChange={(e) => onValueChange([parseFloat(e.target.value)])}
 			data-testid={dataTestId}
 		/>
 	),

webview-ui/src/components/settings/__tests__/SettingsView.test.tsx

@@ -88,11 +88,11 @@ jest.mock("@vscode/webview-ui-toolkit/react", () => ({
 // Mock Slider component
 jest.mock("@/components/ui", () => ({
 	...jest.requireActual("@/components/ui"),
-	Slider: ({ value, onValueCommit, "data-testid": dataTestId }: any) => (
+	Slider: ({ value, onValueChange, "data-testid": dataTestId }: any) => (
 		<input
 			type="range"
 			value={value[0]}
-			onChange={(e) => onValueCommit([parseFloat(e.target.value)])}
+			onChange={(e) => onValueChange([parseFloat(e.target.value)])}
 			data-testid={dataTestId}
 		/>
 	),