Skip to content

Commit e473d67

Browse files
committed
fix(custom-openai): sanitize error msg to prevent circular error
addressing PR feedback
1 parent ec18380 commit e473d67

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

src/api/providers/custom-openai.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -184,15 +184,17 @@ export class CustomOpenAiHandler extends BaseProvider implements SingleCompletio
184184
}
185185
}
186186
} catch (error: any) {
187-
console.error("Custom OpenAI API request failed:", error)
188-
let errorMessage = "Custom OpenAI API request failed."
189-
if (axios.isAxiosError(error) && error.response) {
190-
errorMessage += ` Status: ${error.response.status}. Data: ${JSON.stringify(error.response.data)}`
187+
console.error("Custom OpenAI API request failed:", error?.message || error) // Log basic error message
188+
let simpleErrorMessage = "Custom OpenAI API request failed."
189+
if (axios.isAxiosError(error)) {
190+
simpleErrorMessage += ` Status: ${error.response?.status || "unknown"}.`
191+
// Avoid logging potentially large/circular response data
192+
// console.error("Error Response Data:", error.response?.data); // Optional: Log only during debugging if needed
191193
} else if (error instanceof Error) {
192-
errorMessage += ` Error: ${error.message}`
194+
simpleErrorMessage += ` Error: ${error.message}`
193195
}
194-
// Yield an error chunk or throw? For now, yield text.
195-
yield { type: "text", text: `[ERROR: ${errorMessage}]` }
196+
// Yield a simplified error message
197+
yield { type: "text", text: `[ERROR: ${simpleErrorMessage}]` }
196198
// Consider throwing an error instead if that's preferred for handling failures
197199
// throw new Error(errorMessage);
198200
}

0 commit comments

Comments
 (0)