Skip to content

Commit e4d8fde

Browse files
committed
fix: resolve failing tests and add missing translations
- Update useMcpToolTool.spec.ts mock to handle new toolName parameter in formatResponse.toolError - Add translations for new error title keys in all supported languages (ca, de, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW)
1 parent 6136ba9 commit e4d8fde

File tree

18 files changed

+222
-3
lines changed

18 files changed

+222
-3
lines changed

src/core/tools/__tests__/useMcpToolTool.spec.ts

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,12 @@ import { ToolUse } from "../../../shared/tools"
88
vi.mock("../../prompts/responses", () => ({
99
formatResponse: {
1010
toolResult: vi.fn((result: string) => `Tool result: ${result}`),
11-
toolError: vi.fn((error: string) => `Tool error: ${error}`),
11+
toolError: vi.fn((error: string, toolName?: string) => {
12+
if (toolName) {
13+
return `Tool Call Error: ${toolName}\n<error>\n${error}\n</error>`
14+
}
15+
return `Tool Execution Error\n<error>\n${error}\n</error>`
16+
}),
1217
invalidMcpToolArgumentError: vi.fn((server: string, tool: string) => `Invalid args for ${server}:${tool}`),
1318
},
1419
}))
@@ -136,8 +141,18 @@ describe("useMcpToolTool", () => {
136141

137142
expect(mockTask.consecutiveMistakeCount).toBe(1)
138143
expect(mockTask.recordToolError).toHaveBeenCalledWith("use_mcp_tool")
139-
expect(mockTask.say).toHaveBeenCalledWith("error", expect.stringContaining("invalid JSON argument"))
140-
expect(mockPushToolResult).toHaveBeenCalledWith("Tool error: Invalid args for test_server:test_tool")
144+
expect(mockTask.say).toHaveBeenCalledWith(
145+
"error",
146+
expect.stringContaining("invalid JSON argument"),
147+
undefined,
148+
undefined,
149+
undefined,
150+
undefined,
151+
{ title: "tools:errors.invalidInput" },
152+
)
153+
expect(mockPushToolResult).toHaveBeenCalledWith(
154+
"Tool Call Error: use_mcp_tool\n<error>\nInvalid args for test_server:test_tool\n</error>",
155+
)
141156
})
142157
})
143158

src/i18n/locales/ca/tools.json

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/i18n/locales/de/tools.json

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/i18n/locales/es/tools.json

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/i18n/locales/fr/tools.json

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/i18n/locales/hi/tools.json

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/i18n/locales/id/tools.json

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/i18n/locales/it/tools.json

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/i18n/locales/ja/tools.json

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/i18n/locales/ko/tools.json

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)