fix: properly update Task API configuration when provider settings change

- Add updateApiConfiguration method to Task class to safely update config
- Convert apiConfiguration to getter/setter pattern for controlled access
- Update ClineProvider to use new method when updating provider settings
- Ensure both API handler and configuration are updated together

This ensures the Gemini API key (and other provider settings) are properly
refreshed in active tasks when changed through the UI.

Author: roomote

src/core/task/Task.ts

@@ -187,11 +187,23 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 	private pauseInterval: NodeJS.Timeout | undefined
 
 	// API
-	readonly apiConfiguration: ProviderSettings
+	private _apiConfiguration: ProviderSettings
 	api: ApiHandler
 	private static lastGlobalApiRequestTime?: number
 	private autoApprovalHandler: AutoApprovalHandler
 
+	get apiConfiguration(): ProviderSettings {
+		return this._apiConfiguration
+	}
+
+	/**
+	 * Updates the API configuration and ensures consistency
+	 * This is used when the provider settings change (e.g., API key update)
+	 */
+	public updateApiConfiguration(newConfiguration: ProviderSettings): void {
+		this._apiConfiguration = newConfiguration
+	}
+
 	/**
 	 * Reset the global API request timestamp. This should only be used for testing.
 	 * @internal
@@ -301,7 +313,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 			console.error("Failed to initialize RooIgnoreController:", error)
 		})
 
-		this.apiConfiguration = apiConfiguration
+		this._apiConfiguration = apiConfiguration
 		this.api = buildApiHandler(apiConfiguration)
 		this.autoApprovalHandler = new AutoApprovalHandler()
 

src/core/webview/ClineProvider.ts

@@ -1144,7 +1144,7 @@ export class ClineProvider
 
 				if (task) {
 					task.api = buildApiHandler(providerSettings)
-					task.apiConfiguration = providerSettings
+					task.updateApiConfiguration(providerSettings)
 				}
 			} else {
 				await this.updateGlobalState("listApiConfigMeta", await this.providerSettingsManager.listConfig())
@@ -1206,7 +1206,7 @@ export class ClineProvider
 
 		if (task) {
 			task.api = buildApiHandler(providerSettings)
-			task.apiConfiguration = providerSettings
+			task.updateApiConfiguration(providerSettings)
 		}
 
 		await this.postStateToWebview()

src/core/webview/__tests__/ClineProvider.gemini.spec.ts

@@ -20,9 +20,18 @@ vi.mock("../../../api", () => ({
 vi.mock("../../task/Task", () => ({
 	Task: vi.fn().mockImplementation(function (this: any, options: any) {
 		this.api = options.apiConfiguration ? buildApiHandler(options.apiConfiguration) : null
-		this.apiConfiguration = options.apiConfiguration
+		this._apiConfiguration = options.apiConfiguration
 		this.taskId = "test-task-id"
 		this.providerRef = { deref: () => options.provider }
+		this.updateApiConfiguration = vi.fn((newConfig) => {
+			this._apiConfiguration = newConfig
+		})
+		Object.defineProperty(this, "apiConfiguration", {
+			get: function () {
+				return this._apiConfiguration
+			},
+			configurable: true,
+		})
 	}),
 }))
 
@@ -186,7 +195,7 @@ describe("ClineProvider - Gemini API Key Update", () => {
 
 		// Verify that the task's API handler was updated
 		expect(mockTask.api).toBeDefined()
-		expect(mockTask.apiConfiguration).toEqual(newProviderSettings)
+		expect(mockTask.updateApiConfiguration).toHaveBeenCalledWith(newProviderSettings)
 
 		// Verify that context proxy was updated with new settings
 		expect(mockContextProxy.setProviderSettings).toHaveBeenCalledWith(newProviderSettings)
@@ -228,7 +237,7 @@ describe("ClineProvider - Gemini API Key Update", () => {
 
 		// Verify that the task's API handler and configuration were updated
 		expect(mockTask.api).toBeDefined()
-		expect(mockTask.apiConfiguration).toEqual(newProviderSettings)
+		expect(mockTask.updateApiConfiguration).toHaveBeenCalledWith(newProviderSettings)
 
 		// Verify that context proxy was updated
 		expect(mockContextProxy.setProviderSettings).toHaveBeenCalledWith(newProviderSettings)
@@ -247,7 +256,6 @@ describe("ClineProvider - Gemini API Key Update", () => {
 		}) as any
 
 		const originalApi = mockTask.api
-		const originalConfig = mockTask.apiConfiguration
 
 		// Add the task to the provider's stack
 		provider["clineStack"] = [mockTask]
@@ -264,7 +272,7 @@ describe("ClineProvider - Gemini API Key Update", () => {
 
 		// Verify that the task's API handler was NOT updated
 		expect(mockTask.api).toBe(originalApi)
-		expect(mockTask.apiConfiguration).toBe(originalConfig)
+		expect(mockTask.updateApiConfiguration).not.toHaveBeenCalled()
 
 		// Verify that context proxy was NOT updated
 		expect(mockContextProxy.setProviderSettings).not.toHaveBeenCalled()
@@ -321,7 +329,7 @@ describe("ClineProvider - Gemini API Key Update", () => {
 		await provider.upsertProviderProfile("test-profile", newProviderSettings, true)
 
 		// Verify that all settings are preserved except the API key
-		expect(mockTask.apiConfiguration).toEqual({
+		expect(mockTask.updateApiConfiguration).toHaveBeenCalledWith({
 			apiProvider: "gemini",
 			geminiApiKey: "new-key",
 			apiModelId: "gemini-1.5-pro",