Change Variable name to a better camel-case format.

KrabsWong · KrabsWong · commit e638a56dcb53 · 2025-05-21T16:36:25.000+08:00
diff --git a/evals/packages/types/src/roo-code-defaults.ts b/evals/packages/types/src/roo-code-defaults.ts
@@ -8,7 +8,7 @@ export const rooCodeDefaults: RooCodeSettings = {
 
 	pinnedApiConfigs: {},
 
-	markdownBlockLineheight: 1.25,
+	markdownBlockLineHeight: 1.25,
 	autoApprovalEnabled: true,
 	alwaysAllowReadOnly: true,
 	alwaysAllowReadOnlyOutsideWorkspace: false,
diff --git a/evals/packages/types/src/roo-code.ts b/evals/packages/types/src/roo-code.ts
@@ -731,7 +731,7 @@ export const globalSettingsSchema = z.object({
 	customInstructions: z.string().optional(),
 	taskHistory: z.array(historyItemSchema).optional(),
 
-	markdownBlockLineheight: z.number().optional(),
+	markdownBlockLineHeight: z.number().optional(),
 	autoApprovalEnabled: z.boolean().optional(),
 	alwaysAllowReadOnly: z.boolean().optional(),
 	alwaysAllowReadOnlyOutsideWorkspace: z.boolean().optional(),
@@ -811,7 +811,7 @@ const globalSettingsRecord: GlobalSettingsRecord = {
 	customInstructions: undefined,
 	taskHistory: undefined,
 
-	markdownBlockLineheight: undefined,
+	markdownBlockLineHeight: undefined,
 	autoApprovalEnabled: undefined,
 	alwaysAllowReadOnly: undefined,
 	alwaysAllowReadOnlyOutsideWorkspace: undefined,
diff --git a/src/core/webview/ClineProvider.ts b/src/core/webview/ClineProvider.ts
@@ -1268,7 +1268,7 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements
 			maxReadFileLine,
 			terminalCompressProgressBar,
 			historyPreviewCollapsed,
-			markdownBlockLineheight,
+			markdownBlockLineHeight,
 		} = await this.getState()
 
 		const telemetryKey = process.env.POSTHOG_API_KEY
@@ -1357,7 +1357,7 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements
 			terminalCompressProgressBar: terminalCompressProgressBar ?? true,
 			hasSystemPromptOverride,
 			historyPreviewCollapsed: historyPreviewCollapsed ?? false,
-			markdownBlockLineheight: markdownBlockLineheight ?? 1.25,
+			markdownBlockLineHeight: markdownBlockLineHeight ?? 1.25,
 		}
 	}
 
@@ -1448,7 +1448,7 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements
 			showRooIgnoredFiles: stateValues.showRooIgnoredFiles ?? true,
 			maxReadFileLine: stateValues.maxReadFileLine ?? 500,
 			historyPreviewCollapsed: stateValues.historyPreviewCollapsed ?? false,
-			markdownBlockLineheight: stateValues.markdownBlockLineheight ?? 1.25,
+			markdownBlockLineHeight: stateValues.markdownBlockLineHeight ?? 1.25,
 		}
 	}
 
diff --git a/src/core/webview/webviewMessageHandler.ts b/src/core/webview/webviewMessageHandler.ts
@@ -894,8 +894,8 @@ export const webviewMessageHandler = async (provider: ClineProvider, message: We
 			await updateGlobalState("maxReadFileLine", message.value)
 			await provider.postStateToWebview()
 			break
-		case "markdownBlockLineheight":
-			await updateGlobalState("markdownBlockLineheight", message.value ?? 1.25)
+		case "markdownBlockLineHeight":
+			await updateGlobalState("markdownBlockLineHeight", message.value ?? 1.25)
 			await provider.postStateToWebview()
 			break
 		case "setHistoryPreviewCollapsed": // Add the new case handler
diff --git a/src/exports/roo-code.d.ts b/src/exports/roo-code.d.ts
@@ -56,7 +56,7 @@ type GlobalSettings = {
 				workspace?: string | undefined
 		  }[]
 		| undefined
-	markdownBlockLineheight: number | undefined
+	markdownBlockLineHeight?: number | undefined
 	autoApprovalEnabled?: boolean | undefined
 	alwaysAllowReadOnly?: boolean | undefined
 	alwaysAllowReadOnlyOutsideWorkspace?: boolean | undefined
diff --git a/src/exports/types.ts b/src/exports/types.ts
@@ -56,7 +56,7 @@ type GlobalSettings = {
 				workspace?: string | undefined
 		  }[]
 		| undefined
-	markdownBlockLineheight?: number | undefined
+	markdownBlockLineHeight?: number | undefined
 	autoApprovalEnabled?: boolean | undefined
 	alwaysAllowReadOnly?: boolean | undefined
 	alwaysAllowReadOnlyOutsideWorkspace?: boolean | undefined
diff --git a/src/schemas/index.ts b/src/schemas/index.ts
@@ -735,7 +735,7 @@ export const globalSettingsSchema = z.object({
 	customInstructions: z.string().optional(),
 	taskHistory: z.array(historyItemSchema).optional(),
 
-	markdownBlockLineheight: z.number().optional(),
+	markdownBlockLineHeight: z.number().optional(),
 	autoApprovalEnabled: z.boolean().optional(),
 	alwaysAllowReadOnly: z.boolean().optional(),
 	alwaysAllowReadOnlyOutsideWorkspace: z.boolean().optional(),
@@ -816,7 +816,7 @@ const globalSettingsRecord: GlobalSettingsRecord = {
 	customInstructions: undefined,
 	taskHistory: undefined,
 
-	markdownBlockLineheight: undefined,
+	markdownBlockLineHeight: undefined,
 	autoApprovalEnabled: undefined,
 	alwaysAllowReadOnly: undefined,
 	alwaysAllowReadOnlyOutsideWorkspace: undefined,
diff --git a/src/shared/ExtensionMessage.ts b/src/shared/ExtensionMessage.ts
@@ -70,7 +70,7 @@ export interface ExtensionMessage {
 		| "commandExecutionStatus"
 		| "vsCodeSetting"
 		| "condenseTaskContextResponse"
-		| "markdownBlockLineheight"
+		| "markdownBlockLineHeight"
 	text?: string
 	action?:
 		| "chatButtonClicked"
@@ -171,7 +171,7 @@ export type ExtensionState = Pick<
 	| "customModePrompts"
 	| "customSupportPrompts"
 	| "enhancementApiConfigId"
-	| "markdownBlockLineheight"
+	| "markdownBlockLineHeight"
 > & {
 	version: string
 	clineMessages: ClineMessage[]
diff --git a/src/shared/WebviewMessage.ts b/src/shared/WebviewMessage.ts
@@ -132,7 +132,7 @@ export interface WebviewMessage {
 		| "toggleApiConfigPin"
 		| "setHistoryPreviewCollapsed"
 		| "condenseTaskContextRequest"
-		| "markdownBlockLineheight"
+		| "markdownBlockLineHeight"
 	text?: string
 	disabled?: boolean
 	askResponse?: ClineAskResponse
diff --git a/webview-ui/src/components/common/MarkdownBlock.tsx b/webview-ui/src/components/common/MarkdownBlock.tsx
@@ -122,7 +122,7 @@ const StyledMarkdown = styled.div<{ lineheight: number | string }>`
 `
 
 const MarkdownBlock = memo(({ markdown }: MarkdownBlockProps) => {
-	const { theme, markdownBlockLineheight } = useExtensionState()
+	const { theme, markdownBlockLineHeight } = useExtensionState()
 	const [reactContent, setMarkdown] = useRemark({
 		remarkPlugins: [
 			remarkUrlToLink,
@@ -229,7 +229,7 @@ const MarkdownBlock = memo(({ markdown }: MarkdownBlockProps) => {
 
 	return (
 		<div style={{}}>
-			<StyledMarkdown lineheight={markdownBlockLineheight || 1.25}>{reactContent}</StyledMarkdown>
+			<StyledMarkdown lineheight={markdownBlockLineHeight || 1.25}>{reactContent}</StyledMarkdown>
 		</div>
 	)
 })
diff --git a/webview-ui/src/components/settings/SettingsView.tsx b/webview-ui/src/components/settings/SettingsView.tsx
@@ -163,7 +163,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 		remoteBrowserEnabled,
 		maxReadFileLine,
 		terminalCompressProgressBar,
-		markdownBlockLineheight,
+		markdownBlockLineHeight,
 	} = cachedState
 
 	const apiConfiguration = useMemo(() => cachedState.apiConfiguration ?? {}, [cachedState.apiConfiguration])
@@ -288,7 +288,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 			vscode.postMessage({ type: "alwaysAllowSubtasks", bool: alwaysAllowSubtasks })
 			vscode.postMessage({ type: "upsertApiConfiguration", text: currentApiConfigName, apiConfiguration })
 			vscode.postMessage({ type: "telemetrySetting", text: telemetrySetting })
-			vscode.postMessage({ type: "markdownBlockLineheight", value: markdownBlockLineheight })
+			vscode.postMessage({ type: "markdownBlockLineHeight", value: markdownBlockLineHeight })
 			setChangeDetected(false)
 		}
 	}
@@ -556,7 +556,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 					{/* UISettings Section */}
 					{activeTab === "uiSettings" && (
 						<UISettings
-							markdownBlockLineheight={cachedState.markdownBlockLineheight ?? 1.25}
+							markdownBlockLineHeight={cachedState.markdownBlockLineHeight ?? 1.25}
 							setCachedStateField={setCachedStateField}
 						/>
 					)}
diff --git a/webview-ui/src/components/settings/UISettings.tsx b/webview-ui/src/components/settings/UISettings.tsx
@@ -10,11 +10,11 @@ import { SectionHeader } from "./SectionHeader"
 import { Section } from "./Section"
 
 type UISettingsProps = HTMLAttributes<HTMLDivElement> & {
-	markdownBlockLineheight: number
-	setCachedStateField: SetCachedStateField<"markdownBlockLineheight">
+	markdownBlockLineHeight: number
+	setCachedStateField: SetCachedStateField<"markdownBlockLineHeight">
 }
 
-export const UISettings = ({ markdownBlockLineheight, setCachedStateField, className, ...props }: UISettingsProps) => {
+export const UISettings = ({ markdownBlockLineHeight, setCachedStateField, className, ...props }: UISettingsProps) => {
 	const { t } = useAppTranslation()
 	return (
 		<div className={cn("flex flex-col gap-2", className)} {...props}>
@@ -28,21 +28,21 @@ export const UISettings = ({ markdownBlockLineheight, setCachedStateField, class
 			<Section>
 				<div>
 					<span className="block font-medium mb-1">
-						{t("settings:uiSettings.markdownBlockLineheight.label")}
+						{t("settings:uiSettings.markdownBlockLineHeight.label")}
 					</span>
 					<div className="flex items-center gap-2">
 						<Slider
 							min={1.25}
 							max={2}
 							step={0.01}
-							value={[markdownBlockLineheight ?? 1.25]}
-							onValueChange={([value]) => setCachedStateField("markdownBlockLineheight", value)}
+							value={[markdownBlockLineHeight ?? 1.25]}
+							onValueChange={([value]) => setCachedStateField("markdownBlockLineHeight", value)}
 							data-testid="markdown-lineheight-slider"
 						/>
-						<span className="w-10">{markdownBlockLineheight ?? 1.25}</span>
+						<span className="w-10">{markdownBlockLineHeight ?? 1.25}</span>
 					</div>
 					<div className="text-vscode-descriptionForeground text-sm mt-1">
-						{t("settings:uiSettings.markdownBlockLineheight.description")}
+						{t("settings:uiSettings.markdownBlockLineHeight.description")}
 					</div>
 				</div>
 			</Section>
diff --git a/webview-ui/src/context/ExtensionStateContext.tsx b/webview-ui/src/context/ExtensionStateContext.tsx
@@ -161,7 +161,7 @@ export const ExtensionStateContextProvider: React.FC<{ children: React.ReactNode
 		customSupportPrompts: {},
 		experiments: experimentDefault,
 		enhancementApiConfigId: "",
-		markdownBlockLineheight: 1.25,
+		markdownBlockLineHeight: 1.25,
 		autoApprovalEnabled: false,
 		customModes: [],
 		maxOpenTabsContext: 20,
@@ -269,9 +269,9 @@ export const ExtensionStateContextProvider: React.FC<{ children: React.ReactNode
 		fuzzyMatchThreshold: state.fuzzyMatchThreshold,
 		writeDelayMs: state.writeDelayMs,
 		screenshotQuality: state.screenshotQuality,
-		markdownBlockLineheight: state.markdownBlockLineheight,
-		setMarkdownBlockLineheight: (value) =>
-			setState((prevState) => ({ ...prevState, markdownBlockLineheight: value })),
+		markdownBlockLineHeight: state.markdownBlockLineHeight,
+		setMarkdownBlockLineHeight: (value) =>
+			setState((prevState) => ({ ...prevState, markdownBlockLineHeight: value })),
 		setExperimentEnabled: (id, enabled) =>
 			setState((prevState) => ({ ...prevState, experiments: { ...prevState.experiments, [id]: enabled } })),
 		setApiConfiguration: (value) =>
diff --git a/webview-ui/src/i18n/locales/ca/settings.json b/webview-ui/src/i18n/locales/ca/settings.json
@@ -327,7 +327,7 @@
 	},
 	"uiSettings": {
 		"description": "Configuració relacionada amb la interfície d'usuari",
-		"markdownBlockLineheight": {
+		"markdownBlockLineHeight": {
 			"label": "Espaiat entre línies del contingut del panell",
 			"description": "Ajusteu l'interlineat del contingut del panell per millorar la llegibilitat."
 		}
@@ -537,4 +537,4 @@
 		"customArn": "ARN personalitzat",
 		"useCustomArn": "Utilitza ARN personalitzat..."
 	}
-}
+}
diff --git a/webview-ui/src/i18n/locales/de/settings.json b/webview-ui/src/i18n/locales/de/settings.json
@@ -327,7 +327,7 @@
 	},
 	"uiSettings": {
 		"description": "Benutzeroberflächenbezogene Konfiguration",
-		"markdownBlockLineheight": {
+		"markdownBlockLineHeight": {
 			"label": "Zeilenabstand des Panelinhalts",
 			"description": "Passen Sie den Zeilenabstand des Panel-Inhalts an, um die Lesbarkeit zu verbessern."
 		}
@@ -537,4 +537,4 @@
 		"customArn": "Benutzerdefinierte ARN",
 		"useCustomArn": "Benutzerdefinierte ARN verwenden..."
 	}
-}
+}
diff --git a/webview-ui/src/i18n/locales/en/settings.json b/webview-ui/src/i18n/locales/en/settings.json
@@ -327,7 +327,7 @@
 	},
 	"uiSettings": {
 		"description": "UI related configuration",
-		"markdownBlockLineheight": {
+		"markdownBlockLineHeight": {
 			"label": "Content vertical spacing",
 			"description": "Adjust content vertical line spacing to improve readability."
 		}
@@ -537,4 +537,4 @@
 		"customArn": "Custom ARN",
 		"useCustomArn": "Use custom ARN..."
 	}
-}
+}
diff --git a/webview-ui/src/i18n/locales/es/settings.json b/webview-ui/src/i18n/locales/es/settings.json
@@ -327,7 +327,7 @@
 	},
 	"uiSettings": {
 		"description": "Configuración relacionada con la interfaz de usuario",
-		"markdownBlockLineheight": {
+		"markdownBlockLineHeight": {
 			"label": "Interlineado del contenido del panel",
 			"description": "Ajuste el espaciado entre líneas del contenido del panel para mejorar la legibilidad."
 		}
@@ -537,4 +537,4 @@
 		"customArn": "ARN personalizado",
 		"useCustomArn": "Usar ARN personalizado..."
 	}
-}
+}
diff --git a/webview-ui/src/i18n/locales/fr/settings.json b/webview-ui/src/i18n/locales/fr/settings.json
@@ -327,7 +327,7 @@
 	},
 	"uiSettings": {
 		"description": "Configuration liée à l'interface utilisateur",
-		"markdownBlockLineheight": {
+		"markdownBlockLineHeight": {
 			"label": "Espacement des lignes du contenu du panneau",
 			"description": "Ajustez l'espacement des lignes de contenu du panneau pour améliorer la lisibilité."
 		}
@@ -537,4 +537,4 @@
 		"customArn": "ARN personnalisé",
 		"useCustomArn": "Utiliser un ARN personnalisé..."
 	}
-}
+}
diff --git a/webview-ui/src/i18n/locales/hi/settings.json b/webview-ui/src/i18n/locales/hi/settings.json
@@ -327,7 +327,7 @@
 	},
 	"uiSettings": {
 		"description": "उपयोगकर्ता इंटरफ़ेस संबंधित कॉन्फ़िगरेशन",
-		"markdownBlockLineheight": {
+		"markdownBlockLineHeight": {
 			"label": "पैनल सामग्री पंक्ति रिक्ति",
 			"description": "पठनीयता में सुधार के लिए पैनल सामग्री की पंक्ति रिक्ति समायोजित करें."
 		}
@@ -537,4 +537,4 @@
 		"customArn": "कस्टम ARN",
 		"useCustomArn": "कस्टम ARN का उपयोग करें..."
 	}
-}
+}
diff --git a/webview-ui/src/i18n/locales/it/settings.json b/webview-ui/src/i18n/locales/it/settings.json
@@ -327,7 +327,7 @@
 	},
 	"uiSettings": {
 		"description": "Configurazione relativa all'interfaccia utente",
-		"markdownBlockLineheight": {
+		"markdownBlockLineHeight": {
 			"label": "Interlinea del contenuto del pannello",
 			"description": "Regola la spaziatura delle righe del contenuto del pannello per migliorarne la leggibilità."
 		}
@@ -537,4 +537,4 @@
 		"customArn": "ARN personalizzato",
 		"useCustomArn": "Usa ARN personalizzato..."
 	}
-}
+}
diff --git a/webview-ui/src/i18n/locales/ja/settings.json b/webview-ui/src/i18n/locales/ja/settings.json
@@ -327,7 +327,7 @@
 	},
 	"uiSettings": {
 		"description": "ユーザーインターフェース関連の設定",
-		"markdownBlockLineheight": {
+		"markdownBlockLineHeight": {
 			"label": "パネルコンテンツの行間隔",
 			"description": "読みやすさを向上させるために、パネル コンテンツの行間隔を調整します。"
 		}
@@ -537,4 +537,4 @@
 		"customArn": "カスタム ARN",
 		"useCustomArn": "カスタム ARN を使用..."
 	}
-}
+}
diff --git a/webview-ui/src/i18n/locales/ko/settings.json b/webview-ui/src/i18n/locales/ko/settings.json
@@ -327,7 +327,7 @@
 	},
 	"uiSettings": {
 		"description": "사용자 인터페이스 관련 구성",
-		"markdownBlockLineheight": {
+		"markdownBlockLineHeight": {
 			"label": "패널 콘텐츠 줄 간격",
 			"description": "가독성을 높이려면 패널 콘텐츠 줄 간격을 조정하세요."
 		}
@@ -537,4 +537,4 @@
 		"customArn": "사용자 지정 ARN",
 		"useCustomArn": "사용자 지정 ARN 사용..."
 	}
-}
+}
diff --git a/webview-ui/src/i18n/locales/nl/settings.json b/webview-ui/src/i18n/locales/nl/settings.json
@@ -327,7 +327,7 @@
 	},
 	"uiSettings": {
 		"description": "Gebruikersinterfacegerelateerde configuratie",
-		"markdownBlockLineheight": {
+		"markdownBlockLineHeight": {
 			"label": "Regelafstand van paneelinhoud",
 			"description": "Pas de regelafstand van de paneelinhoud aan om de leesbaarheid te verbeteren."
 		}
@@ -537,4 +537,4 @@
 		"customArn": "Aangepaste ARN",
 		"useCustomArn": "Aangepaste ARN gebruiken..."
 	}
-}
+}
diff --git a/webview-ui/src/i18n/locales/pl/settings.json b/webview-ui/src/i18n/locales/pl/settings.json
diff --git a/webview-ui/src/i18n/locales/pt-BR/settings.json b/webview-ui/src/i18n/locales/pt-BR/settings.json
diff --git a/webview-ui/src/i18n/locales/ru/settings.json b/webview-ui/src/i18n/locales/ru/settings.json
diff --git a/webview-ui/src/i18n/locales/tr/settings.json b/webview-ui/src/i18n/locales/tr/settings.json
diff --git a/webview-ui/src/i18n/locales/vi/settings.json b/webview-ui/src/i18n/locales/vi/settings.json
diff --git a/webview-ui/src/i18n/locales/zh-CN/settings.json b/webview-ui/src/i18n/locales/zh-CN/settings.json
diff --git a/webview-ui/src/i18n/locales/zh-TW/settings.json b/webview-ui/src/i18n/locales/zh-TW/settings.json

Original file line number	Diff line number	Diff line change
`@@ -1268,7 +1268,7 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements`
`1268`	`1268`	`maxReadFileLine,`
`1269`	`1269`	`terminalCompressProgressBar,`
`1270`	`1270`	`historyPreviewCollapsed,`
`1271`		`- markdownBlockLineheight,`
	`1271`	`+ markdownBlockLineHeight,`
`1272`	`1272`	`} = await this.getState()`
`1273`	`1273`
`1274`	`1274`	`const telemetryKey = process.env.POSTHOG_API_KEY`
`@@ -1357,7 +1357,7 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements`
`1357`	`1357`	`terminalCompressProgressBar: terminalCompressProgressBar ?? true,`
`1358`	`1358`	`hasSystemPromptOverride,`
`1359`	`1359`	`historyPreviewCollapsed: historyPreviewCollapsed ?? false,`
`1360`		`- markdownBlockLineheight: markdownBlockLineheight ?? 1.25,`
	`1360`	`+ markdownBlockLineHeight: markdownBlockLineHeight ?? 1.25,`
`1361`	`1361`	`}`
`1362`	`1362`	`}`
`1363`	`1363`
`@@ -1448,7 +1448,7 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements`
`1448`	`1448`	`showRooIgnoredFiles: stateValues.showRooIgnoredFiles ?? true,`
`1449`	`1449`	`maxReadFileLine: stateValues.maxReadFileLine ?? 500,`
`1450`	`1450`	`historyPreviewCollapsed: stateValues.historyPreviewCollapsed ?? false,`
`1451`		`- markdownBlockLineheight: stateValues.markdownBlockLineheight ?? 1.25,`
	`1451`	`+ markdownBlockLineHeight: stateValues.markdownBlockLineHeight ?? 1.25,`
`1452`	`1452`	`}`
`1453`	`1453`	`}`
`1454`	`1454`