Skip to content

Commit e63b5a6

Browse files
committed
fix: address PR feedback for slash commands tip
- Add TRANSLATION_TODO.md documenting missing translations for 11 languages - Update test to expect 4 links instead of 3 (3 tips + 1 docs link) - Document that slash commands documentation link is consistent with existing usage
1 parent e8bdd83 commit e63b5a6

File tree

2 files changed

+78
-3
lines changed

2 files changed

+78
-3
lines changed

webview-ui/src/components/welcome/__tests__/RooTips.spec.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ describe("RooTips Component", () => {
3838
render(<RooTips />)
3939
})
4040

41-
test("renders only the top two tips", () => {
42-
// Ensure only two tips are present plus the docs link in the Trans component (3 total links)
43-
expect(screen.getAllByRole("link")).toHaveLength(3)
41+
test("renders all three tips", () => {
42+
// Ensure three tips are present plus the docs link in the Trans component (4 total links)
43+
expect(screen.getAllByRole("link")).toHaveLength(4)
4444
})
4545
})
4646
})
Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
# Translation TODO for Slash Commands Feature
2+
3+
The following languages need proper translations for the slash commands tip in the RooTips component:
4+
5+
## Languages needing translation
6+
7+
### Portuguese (pt-BR)
8+
9+
- `rooTips.slashCommands.title`: Currently "Slash Commands" - needs Portuguese translation
10+
- `rooTips.slashCommands.description`: Currently "Create custom commands for quick access to frequently used prompts" - needs Portuguese translation
11+
12+
### Korean (ko)
13+
14+
- `rooTips.slashCommands.title`: Currently "Slash Commands" - needs Korean translation
15+
- `rooTips.slashCommands.description`: Currently "Create custom commands for quick access to frequently used prompts" - needs Korean translation
16+
17+
### Hindi (hi)
18+
19+
- `rooTips.slashCommands.title`: Currently "Slash Commands" - needs Hindi translation
20+
- `rooTips.slashCommands.description`: Currently "Create custom commands for quick access to frequently used prompts" - needs Hindi translation
21+
22+
### Italian (it)
23+
24+
- `rooTips.slashCommands.title`: Currently "Slash Commands" - needs Italian translation
25+
- `rooTips.slashCommands.description`: Currently "Create custom commands for quick access to frequently used prompts" - needs Italian translation
26+
27+
### Dutch (nl)
28+
29+
- `rooTips.slashCommands.title`: Currently "Slash Commands" - needs Dutch translation
30+
- `rooTips.slashCommands.description`: Currently "Create custom commands for quick access to frequently used prompts" - needs Dutch translation
31+
32+
### Turkish (tr)
33+
34+
- `rooTips.slashCommands.title`: Currently "Slash Commands" - needs Turkish translation
35+
- `rooTips.slashCommands.description`: Currently "Create custom commands for quick access to frequently used prompts" - needs Turkish translation
36+
37+
### Indonesian (id)
38+
39+
- `rooTips.slashCommands.title`: Currently "Slash Commands" - needs Indonesian translation
40+
- `rooTips.slashCommands.description`: Currently "Create custom commands for quick access to frequently used prompts" - needs Indonesian translation
41+
42+
### Polish (pl)
43+
44+
- `rooTips.slashCommands.title`: Currently "Slash Commands" - needs Polish translation
45+
- `rooTips.slashCommands.description`: Currently "Create custom commands for quick access to frequently used prompts" - needs Polish translation
46+
47+
### Russian (ru)
48+
49+
- `rooTips.slashCommands.title`: Currently "Slash Commands" - needs Russian translation
50+
- `rooTips.slashCommands.description`: Currently "Create custom commands for quick access to frequently used prompts" - needs Russian translation
51+
52+
### Vietnamese (vi)
53+
54+
- `rooTips.slashCommands.title`: Currently "Slash Commands" - needs Vietnamese translation
55+
- `rooTips.slashCommands.description`: Currently "Create custom commands for quick access to frequently used prompts" - needs Vietnamese translation
56+
57+
### Chinese Traditional (zh-TW)
58+
59+
- `rooTips.slashCommands.title`: Currently "Slash Commands" - needs Chinese Traditional translation
60+
- `rooTips.slashCommands.description`: Currently "Create custom commands for quick access to frequently used prompts" - needs Chinese Traditional translation
61+
62+
## Languages with proper translations
63+
64+
The following languages already have proper translations:
65+
66+
- Spanish (es): "Comandos de Barra"
67+
- French (fr): "Commandes Slash"
68+
- German (de): "Slash-Befehle"
69+
- Japanese (ja): "スラッシュコマンド"
70+
- Catalan (ca): "Ordres de Barra"
71+
- Chinese Simplified (zh-CN): "斜杠命令"
72+
73+
## Notes
74+
75+
This is a known limitation that should be addressed in a follow-up PR to provide proper internationalization support for all languages.

0 commit comments

Comments
 (0)