Skip to content

Commit e74c3a5

Browse files
committed
feat(terminal): disable VS Code terminal shell integration by default
1 parent 8622d93 commit e74c3a5

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/core/tools/executeCommandTool.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export async function executeCommandTool(
6767
const {
6868
terminalOutputLineLimit = 500,
6969
terminalOutputCharacterLimit = DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
70-
terminalShellIntegrationDisabled = false,
70+
terminalShellIntegrationDisabled = true,
7171
} = providerState ?? {}
7272

7373
// Get command execution timeout from VSCode configuration (in seconds)
@@ -149,7 +149,7 @@ export async function executeCommand(
149149
executionId,
150150
command,
151151
customCwd,
152-
terminalShellIntegrationDisabled = false,
152+
terminalShellIntegrationDisabled = true,
153153
terminalOutputLineLimit = 500,
154154
terminalOutputCharacterLimit = DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
155155
commandExecutionTimeout = 0,

src/core/webview/ClineProvider.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -731,7 +731,7 @@ export class ClineProvider
731731
this.getState().then(
732732
({
733733
terminalShellIntegrationTimeout = Terminal.defaultShellIntegrationTimeout,
734-
terminalShellIntegrationDisabled = false,
734+
terminalShellIntegrationDisabled = true,
735735
terminalCommandDelay = 0,
736736
terminalZshClearEolMark = true,
737737
terminalZshOhMy = false,
@@ -1885,7 +1885,7 @@ export class ClineProvider
18851885
terminalOutputLineLimit: terminalOutputLineLimit ?? 500,
18861886
terminalOutputCharacterLimit: terminalOutputCharacterLimit ?? DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
18871887
terminalShellIntegrationTimeout: terminalShellIntegrationTimeout ?? Terminal.defaultShellIntegrationTimeout,
1888-
terminalShellIntegrationDisabled: terminalShellIntegrationDisabled ?? false,
1888+
terminalShellIntegrationDisabled: terminalShellIntegrationDisabled ?? true,
18891889
terminalCommandDelay: terminalCommandDelay ?? 0,
18901890
terminalPowershellCounter: terminalPowershellCounter ?? false,
18911891
terminalZshClearEolMark: terminalZshClearEolMark ?? true,
@@ -2106,7 +2106,7 @@ export class ClineProvider
21062106
stateValues.terminalOutputCharacterLimit ?? DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
21072107
terminalShellIntegrationTimeout:
21082108
stateValues.terminalShellIntegrationTimeout ?? Terminal.defaultShellIntegrationTimeout,
2109-
terminalShellIntegrationDisabled: stateValues.terminalShellIntegrationDisabled ?? false,
2109+
terminalShellIntegrationDisabled: stateValues.terminalShellIntegrationDisabled ?? true,
21102110
terminalCommandDelay: stateValues.terminalCommandDelay ?? 0,
21112111
terminalPowershellCounter: stateValues.terminalPowershellCounter ?? false,
21122112
terminalZshClearEolMark: stateValues.terminalZshClearEolMark ?? true,

0 commit comments

Comments
 (0)