chore: remove unnecessary type cast

Author: Lagyu

src/api/providers/__tests__/openai.spec.ts

@@ -7,6 +7,20 @@ import OpenAI from "openai"
 import { Package } from "../../../shared/package"
 import axios from "axios"
 
+type ErrorWithStatus = Error & { status?: number }
+
+function getMockCallsOf(fn: unknown): any[] {
+	const isObj = (v: unknown): v is Record<string, unknown> => typeof v === "object" && v !== null
+	if (isObj(fn) || typeof fn === "function") {
+		const rec = fn as Record<string, unknown>
+		const mock = rec["mock"]
+		if (isObj(mock)) {
+			const calls = mock["calls"]
+			if (Array.isArray(calls)) return calls
+		}
+	}
+	return []
+}
 const mockCreate = vitest.fn()
 const mockResponsesCreate = vitest.fn()
 
@@ -424,9 +438,9 @@ describe("OpenAiHandler", () => {
 		})
 
 		it("should handle rate limiting", async () => {
-			const rateLimitError = new Error("Rate limit exceeded")
+			const rateLimitError: ErrorWithStatus = new Error("Rate limit exceeded")
 			rateLimitError.name = "Error"
-			;(rateLimitError as any).status = 429
+			rateLimitError.status = 429
 			mockCreate.mockRejectedValueOnce(rateLimitError)
 
 			const stream = handler.createMessage("system prompt", testMessages)
@@ -1198,9 +1212,9 @@ describe("OpenAI Compatible - Responses API", () => {
 
 	it("Verbosity (Responses): include when set; if server rejects, retry without it (warn once)", async () => {
 		// First call throws 400 for 'verbosity', second succeeds
-		mockResponsesCreate.mockImplementationOnce((_opts: any) => {
-			const err = new Error("Unsupported parameter: 'verbosity'")
-			;(err as any).status = 400
+		mockResponsesCreate.mockImplementationOnce((_opts: unknown) => {
+			const err: ErrorWithStatus = new Error("Unsupported parameter: 'verbosity'")
+			err.status = 400
 			throw err
 		})
 
@@ -1295,10 +1309,13 @@ describe("OpenAI Compatible - Responses API", () => {
 
 		// Ensure SDK constructor was called with normalized baseURL and 'preview' apiVersion (per requirement)
 		// Note: AzureOpenAI and OpenAI share same mock constructor; inspect last call
-		const ctorCalls = vi.mocked(OpenAI as unknown as any).mock.calls as any[]
-		const lastCtorArgs = ctorCalls[ctorCalls.length - 1]?.[0] || {}
-		expect(lastCtorArgs.baseURL).toBe("https://sample-name.openai.azure.com/openai/v1")
-		expect(lastCtorArgs.apiVersion).toBe("preview")
+		const ctorCalls = getMockCallsOf(OpenAI)
+		const lastCall = ctorCalls[ctorCalls.length - 1]
+		const lastArg0 = Array.isArray(lastCall) ? lastCall[0] : undefined
+		const lastCtorArgs =
+			typeof lastArg0 === "object" && lastArg0 !== null ? (lastArg0 as Record<string, unknown>) : {}
+		expect(lastCtorArgs["baseURL"]).toBe("https://sample-name.openai.azure.com/openai/v1")
+		expect(lastCtorArgs["apiVersion"]).toBe("preview")
 	})
 
 	it("streams Responses API when provider returns AsyncIterable", async () => {
@@ -1461,7 +1478,7 @@ describe("OpenAI Compatible - Responses API (multimodal)", () => {
 					{
 						type: "image" as const,
 						// Minimal Anthropic-style inline image (base64) block
-						source: { media_type: "image/png", data: "BASE64DATA" } as any,
+						source: { type: "base64" as const, media_type: "image/png", data: "BASE64DATA" },
 					},
 				],
 			},
@@ -1478,7 +1495,7 @@ describe("OpenAI Compatible - Responses API (multimodal)", () => {
 
 		// Input should be an array (structured input mode)
 		expect(Array.isArray(args.input)).toBe(true)
-		const arr = args.input as any[]
+		const arr = Array.isArray(args.input) ? args.input : []
 
 		// First element should be Developer preface as input_text
 		expect(arr[0]?.role).toBe("user")
@@ -1537,7 +1554,7 @@ describe("OpenAI Compatible - Responses API (multimodal)", () => {
 					{ type: "text" as const, text: "Look at this" },
 					{
 						type: "image" as const,
-						source: { media_type: "image/jpeg", data: "IMGDATA" } as any,
+						source: { type: "base64" as const, media_type: "image/jpeg", data: "IMGDATA" },
 					},
 				],
 			},
@@ -1648,7 +1665,7 @@ describe("OpenAI Compatible - Responses API conversation continuity", () => {
 		for await (const _ of handler.createMessage(
 			"sys",
 			[{ role: "user", content: [{ type: "text" as const, text: "Turn 2" }] }],
-			{ suppressPreviousResponseId: true } as any,
+			{ taskId: "test", suppressPreviousResponseId: true },
 		)) {
 		}
 
@@ -1668,9 +1685,9 @@ describe("OpenAI Compatible - Responses API parity improvements", () => {
 	it("retries without previous_response_id when server returns 400 'Previous response ... not found' (non-streaming)", async () => {
 		// First call throws 400 for previous_response_id, second succeeds
 		mockResponsesCreate
-			.mockImplementationOnce((_opts: any) => {
-				const err = new Error("Previous response rid-bad not found")
-				;(err as any).status = 400
+			.mockImplementationOnce((_opts: unknown) => {
+				const err: ErrorWithStatus = new Error("Previous response rid-bad not found")
+				err.status = 400
 				throw err
 			})
 			.mockImplementationOnce(async (_opts: any) => {
@@ -1688,7 +1705,7 @@ describe("OpenAI Compatible - Responses API parity improvements", () => {
 		for await (const ch of h.createMessage(
 			"sys",
 			[{ role: "user", content: [{ type: "text" as const, text: "Turn" }] }],
-			{ previousResponseId: "rid-bad" } as any,
+			{ taskId: "test", previousResponseId: "rid-bad" },
 		)) {
 			chunks.push(ch)
 		}
@@ -1709,9 +1726,9 @@ describe("OpenAI Compatible - Responses API parity improvements", () => {
 	it("retries without previous_response_id when server returns 400 (streaming)", async () => {
 		// First call throws, second returns a stream
 		mockResponsesCreate
-			.mockImplementationOnce((_opts: any) => {
-				const err = new Error("Previous response not found")
-				;(err as any).status = 400
+			.mockImplementationOnce((_opts: unknown) => {
+				const err: ErrorWithStatus = new Error("Previous response not found")
+				err.status = 400
 				throw err
 			})
 			.mockImplementationOnce(async (_opts: any) => {
@@ -1734,7 +1751,7 @@ describe("OpenAI Compatible - Responses API parity improvements", () => {
 		for await (const ch of h.createMessage(
 			"sys",
 			[{ role: "user", content: [{ type: "text" as const, text: "Hi" }] }],
-			{ previousResponseId: "bad-id" } as any,
+			{ taskId: "test", previousResponseId: "bad-id" },
 		)) {
 			out.push(ch)
 		}
@@ -1884,7 +1901,10 @@ describe("OpenAI Compatible - Responses API minimal input parity (new tests)", (
 		]
 
 		const chunks: any[] = []
-		for await (const ch of handler.createMessage("System Inst", msgs, { previousResponseId: "prev-1" } as any)) {
+		for await (const ch of handler.createMessage("System Inst", msgs, {
+			taskId: "test",
+			previousResponseId: "prev-1",
+		})) {
 			chunks.push(ch)
 		}
 
@@ -1914,12 +1934,15 @@ describe("OpenAI Compatible - Responses API minimal input parity (new tests)", (
 				role: "user",
 				content: [
 					{ type: "text" as const, text: "See" },
-					{ type: "image" as const, source: { media_type: "image/png", data: "IMGDATA" } as any },
+					{
+						type: "image" as const,
+						source: { type: "base64" as const, media_type: "image/png", data: "IMGDATA" },
+					},
 				],
 			},
 		]
 
-		const iter = handler.createMessage("Sys", msgs, { previousResponseId: "prev-2" } as any)
+		const iter = handler.createMessage("Sys", msgs, { taskId: "test", previousResponseId: "prev-2" })
 		for await (const _ of iter) {
 			// consume
 		}
@@ -1928,7 +1951,7 @@ describe("OpenAI Compatible - Responses API minimal input parity (new tests)", (
 		const args = mockResponsesCreate.mock.calls.pop()?.[0]
 		expect(Array.isArray(args.input)).toBe(true)
 
-		const arr = args.input as any[]
+		const arr = Array.isArray(args.input) ? args.input : []
 		expect(arr.length).toBe(1)
 		expect(arr[0]?.role).toBe("user")
 

src/api/providers/openai.ts

@@ -25,7 +25,6 @@ import { DEFAULT_HEADERS } from "./constants"
 import { BaseProvider } from "./base-provider"
 import type { SingleCompletionHandler, ApiHandlerCreateMessageMetadata } from "../index"
 import { getApiRequestTimeout } from "./utils/timeout-config"
-import { ResponseCreateParamsNonStreaming } from "openai/resources/responses/responses"
 
 // TODO: Rename this to OpenAICompatibleHandler. Also, I think the
 // `OpenAINativeHandler` can subclass from this, since it's obviously
@@ -151,19 +150,14 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
 		metadata?: ApiHandlerCreateMessageMetadata,
 	): ApiStream {
 		// Gather model params (centralized: temperature, max tokens, reasoning, verbosity)
-		const modelParams = this.getModel()
-		const {
-			info: modelInfo,
-			reasoning,
-			reasoningEffort,
-			verbosity,
-		} = modelParams as unknown as {
-			id: string
-			info: ModelInfo
-			reasoning?: { reasoning_effort?: "low" | "medium" | "high" }
-			reasoningEffort?: "minimal" | "low" | "medium" | "high"
-			verbosity?: "low" | "medium" | "high"
-		}
+		const { info: modelInfo } = this.getModel()
+		const openAiParams = getModelParams({
+			format: "openai",
+			modelId: this.options.openAiModelId ?? "",
+			model: modelInfo,
+			settings: this.options,
+		})
+		const { reasoning, reasoningEffort, verbosity } = openAiParams
 
 		const modelUrl = this.options.openAiBaseUrl ?? ""
 		const modelId = this.options.openAiModelId ?? ""
@@ -280,7 +274,7 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
 			}
 
 			// Always include max_output_tokens for Responses API to cap output length
-			const reservedMax = (modelParams as any)?.maxTokens
+			const reservedMax = openAiParams.maxTokens
 			;(basePayload as Record<string, unknown>).max_output_tokens =
 				this.options.modelMaxTokens || reservedMax || modelInfo.maxTokens
 
@@ -293,7 +287,7 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
 					systemPrompt,
 					messages,
 				})
-				yield* this._yieldResponsesResult(response as unknown, modelInfo)
+				yield* this._yieldResponsesResult(response, modelInfo)
 				return
 			}
 
@@ -320,7 +314,7 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
 				}
 			} else {
 				// Some providers may ignore the stream flag and return a complete response
-				yield* this._yieldResponsesResult(maybeStream as unknown, modelInfo)
+				yield* this._yieldResponsesResult(maybeStream, modelInfo)
 			}
 			return
 		}
@@ -521,7 +515,7 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
 					} as Anthropic.Messages.MessageParam,
 					/*includeRole*/ true,
 				)
-				const payload: ResponseCreateParamsNonStreaming = {
+				const payload: Record<string, unknown> = {
 					model: model.id,
 					input: formattedInput,
 				}
@@ -552,7 +546,7 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
 					payload.max_output_tokens = this.options.modelMaxTokens || modelInfo.maxTokens
 				}
 
-				const response = await this._responsesCreateWithRetries(payload as unknown as Record<string, unknown>, {
+				const response = await this._responsesCreateWithRetries(payload, {
 					usedArrayInput: false,
 					lastUserMessage: undefined,
 					previousId: undefined,
@@ -976,10 +970,20 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
 			messages: Anthropic.Messages.MessageParam[]
 		},
 	): Promise<unknown> {
-		const create = (body: Record<string, unknown>) =>
-			(
-				this.client as unknown as { responses: { create: (b: Record<string, unknown>) => Promise<unknown> } }
-			).responses.create(body)
+		const create = (body: Record<string, unknown>) => {
+			const hasResponsesCreate = (
+				obj: unknown,
+			): obj is { responses: { create: (b: Record<string, unknown>) => Promise<unknown> } } => {
+				if (obj == null || typeof obj !== "object") return false
+				const responses = (obj as Record<string, unknown>).responses
+				if (responses == null || typeof responses !== "object") return false
+				return typeof (responses as Record<string, unknown>).create === "function"
+			}
+			if (!hasResponsesCreate(this.client)) {
+				throw new Error("Responses API not available on client")
+			}
+			return this.client.responses.create(body)
+		}
 
 		try {
 			return await create(payload)

src/api/transform/responses-stream.ts

@@ -18,7 +18,7 @@ export async function* handleResponsesStream(
 	for await (const event of stream) {
 		// Surface response.id to callers when available (for conversation continuity)
 		if (isObject(event)) {
-			const resp = (event as Record<string, unknown>).response as unknown
+			const resp = (event as Record<string, unknown>).response
 			if (isObject(resp)) {
 				const rid = (resp as Record<string, unknown>).id
 				if (typeof rid === "string") {
@@ -224,11 +224,11 @@ function isDoneEvent(event: unknown): event is DoneEvent {
 
 function getChoiceDeltaContent(event: unknown): string | undefined {
 	if (!isObject(event)) return undefined
-	const choices = (event as Record<string, unknown>).choices as unknown
+	const choices = (event as Record<string, unknown>).choices
 	if (!Array.isArray(choices) || choices.length === 0) return undefined
-	const first = choices[0] as unknown
+	const first = choices[0]
 	if (!isObject(first)) return undefined
-	const delta = (first as Record<string, unknown>).delta as unknown
+	const delta = (first as Record<string, unknown>).delta
 	if (!isObject(delta)) return undefined
 	const content = (delta as Record<string, unknown>).content
 	if (content == null) return undefined
@@ -237,11 +237,11 @@ function getChoiceDeltaContent(event: unknown): string | undefined {
 
 function extractUsage(event: unknown): ResponseUsage | undefined {
 	if (!isObject(event)) return undefined
-	const resp = (event as Record<string, unknown>).response as unknown
+	const resp = (event as Record<string, unknown>).response
 	if (isObject(resp) && isObject((resp as Record<string, unknown>).usage)) {
 		return (resp as Record<string, unknown>).usage as ResponseUsage
 	}
-	const usage = (event as Record<string, unknown>).usage as unknown
+	const usage = (event as Record<string, unknown>).usage
 	if (isObject(usage)) {
 		return usage as ResponseUsage
 	}