feat(marketplace): yaml migrate for modes, + uninstall UX (remove empty)

Author: NamesMT

pnpm-lock.yaml

@@ -367,7 +367,7 @@
 		"cheerio": "^1.0.0",
 		"chokidar": "^4.0.1",
 		"clone-deep": "^4.0.1",
-		"config-rocket": "^0.5.8",
+		"config-rocket": "^0.6.1",
 		"default-shell": "^2.2.0",
 		"delay": "^6.0.0",
 		"diff": "^5.2.0",
@@ -396,7 +396,7 @@
 		"puppeteer-chromium-resolver": "^23.0.0",
 		"puppeteer-core": "^23.4.0",
 		"reconnecting-eventsource": "^1.6.4",
-		"roo-rocket": "^0.4.0",
+		"roo-rocket": "^0.5.0",
 		"sanitize-filename": "^1.6.3",
 		"say": "^0.16.0",
 		"serialize-error": "^11.0.3",

src/package.json

@@ -161,8 +161,10 @@ export class InstalledMetadataManager {
 			// Serialize metadata to YAML
 			const yamlContent = yaml.stringify(metadata)
 
-			// Write to file
-			await fs.writeFile(filePath, yamlContent, "utf-8")
+			// Write to file if there are any entries, otherwise remove file
+			if (Object.keys(metadata).length) await fs.writeFile(filePath, yamlContent, "utf-8")
+			else await fs.rm(filePath)
+
 			console.debug(`InstalledMetadataManager: Metadata saved successfully to ${filePath}`)
 		} catch (error) {
 			console.error(`InstalledMetadataManager: Error saving metadata file ${filePath}:`, error)

src/services/marketplace/InstalledMetadataManager.ts

@@ -1,6 +1,7 @@
 import * as vscode from "vscode"
 import * as path from "path"
 import * as fs from "fs/promises"
+import * as yaml from "yaml"
 import { GitFetcher } from "./GitFetcher"
 import {
 	MarketplaceItem,
@@ -684,17 +685,16 @@ export class MarketplaceManager {
 				mcps: [],
 				files: [],
 			}
-			customHookable.hook("onFileOutput", ({ filePath, data }) => {
+			customHookable.hook("onFileOutput", ({ filePath, parsedData }) => {
+				const pD = parsedData as Record<string, any>
 				if (filePath.endsWith("/.roomodes")) {
-					const parsedData = JSON.parse(data)
-					if (parsedData?.customModes?.length) {
-						parsedData.customModes.forEach((mode: any) => {
+					if (pD?.customModes?.length) {
+						pD.customModes.forEach((mode: any) => {
 							itemInstalledMetadata.modes?.push(mode.slug)
 						})
 					}
 				} else if (filePath.endsWith("/.roo/mcp.json")) {
-					const parsedData = JSON.parse(data)
-					const mcpSlugs = Object.keys(parsedData?.mcpServers ?? {})
+					const mcpSlugs = Object.keys(pD?.mcpServers ?? {})
 					if (mcpSlugs.length) {
 						mcpSlugs.forEach((mcpSlug: any) => {
 							itemInstalledMetadata.mcps?.push(mcpSlug)
@@ -737,11 +737,13 @@ export class MarketplaceManager {
 				if (await fs.access(modesFilePath).catch(() => true))
 					vscode.window.showWarningMessage(`"${item.name}": modes file not found`)
 				else {
-					const parsedModesFile = JSON.parse(await fs.readFile(modesFilePath, "utf-8"))
+					const parsedModesFile = yaml.parse(await fs.readFile(modesFilePath, "utf-8"))
 					parsedModesFile.customModes = parsedModesFile.customModes.filter(
 						(m: any) => !itemInstalledMetadata.modes!.includes(m.slug),
 					)
-					await fs.writeFile(modesFilePath, JSON.stringify(parsedModesFile, null, 2), "utf-8")
+					if (parsedModesFile.customModes.length)
+						await fs.writeFile(modesFilePath, yaml.stringify(parsedModesFile, null, 2), "utf-8") // Remove file if no more modes left
+					else await fs.rm(modesFilePath)
 				}
 			}
 			if (itemInstalledMetadata.mcps) {
@@ -752,7 +754,9 @@ export class MarketplaceManager {
 					itemInstalledMetadata.mcps.forEach((mcp) => {
 						delete parsedMcpsFile.mcpServers[mcp]
 					})
-					await fs.writeFile(mcpsFilePath, JSON.stringify(parsedMcpsFile, null, 2), "utf-8")
+					if (Object.keys(parsedMcpsFile.mcpServers).length)
+						await fs.writeFile(mcpsFilePath, JSON.stringify(parsedMcpsFile, null, 2), "utf-8") // Remove file if no more modes left
+					else await fs.rm(mcpsFilePath)
 				}
 			}
 			if (itemInstalledMetadata.files) {

src/services/marketplace/MarketplaceManager.ts

@@ -38,7 +38,7 @@
 		"class-variance-authority": "^0.7.1",
 		"clsx": "^2.1.1",
 		"cmdk": "^1.0.0",
-		"config-rocket": "^0.5.8",
+		"config-rocket": "^0.6.1",
 		"date-fns": "^4.1.0",
 		"debounce": "^2.1.1",
 		"fast-deep-equal": "^3.1.3",