Skip to content

Commit f10bbef

Browse files
committed
fix: address PR review feedback
- Change isLoading default to false in DismissedUpsellsContext to prevent flash of upsells - Fix import path inconsistency in ChatView.tsx (use @src/ instead of @/)
1 parent 6af9324 commit f10bbef

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

webview-ui/src/components/chat/ChatView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ import { Cloud } from "lucide-react"
5959
import { CloudUpsellDialog } from "@src/components/cloud/CloudUpsellDialog"
6060
import DismissibleUpsell from "../common/DismissibleUpsell"
6161
import { useCloudUpsell } from "@src/hooks/useCloudUpsell"
62-
import { useUpsellVisibility, UPSELL_IDS } from "@/hooks/useUpsellVisibility"
62+
import { useUpsellVisibility, UPSELL_IDS } from "@src/hooks/useUpsellVisibility"
6363

6464
export interface ChatViewProps {
6565
isHidden: boolean

webview-ui/src/context/DismissedUpsellsContext.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ interface DismissedUpsellsProviderProps {
2323

2424
export const DismissedUpsellsProvider: React.FC<DismissedUpsellsProviderProps> = ({ children }) => {
2525
const [dismissedUpsells, setDismissedUpsells] = useState<string[]>([])
26-
const [isLoading, setIsLoading] = useState(true)
26+
const [isLoading, setIsLoading] = useState(false)
2727

2828
// Request dismissed upsells from extension
2929
const refreshDismissedUpsells = useCallback(() => {

0 commit comments

Comments
 (0)