chore(openai-native,task): guard debug logs behind flag and extract GPT-5 model prefix constant; no behavior change

Author: hannesrudolph

src/api/providers/openai-native.ts

@@ -41,6 +41,13 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 	private responseIdPromise: Promise<string | undefined> | undefined
 	private responseIdResolver: ((value: string | undefined) => void) | undefined
 
+	// Internal debug logger for conditional diagnostics
+	private logDebug(...args: any[]): void {
+		if (DEBUG_RESPONSES_API) {
+			console.debug(...args)
+		}
+	}
+
 	// Event types handled by the shared event processor to avoid duplication
 	private readonly coreHandledEventTypes = new Set<string>([
 		"response.text.delta",
@@ -268,11 +275,9 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 
 			if (is400Error && requestBody.previous_response_id && isPreviousResponseError) {
 				// Log the error and retry without the previous_response_id
-				if (DEBUG_RESPONSES_API) {
-					console.debug(
-						`[Responses API] Previous response ID not found (${requestBody.previous_response_id}), retrying without it`,
-					)
-				}
+				this.logDebug(
+					`[Responses API] Previous response ID not found (${requestBody.previous_response_id}), retrying without it`,
+				)
 
 				// Remove the problematic previous_response_id and retry
 				const retryRequestBody = { ...requestBody }
@@ -442,11 +447,9 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 
 				if (response.status === 400 && requestBody.previous_response_id && isPreviousResponseError) {
 					// Log the error and retry without the previous_response_id
-					if (DEBUG_RESPONSES_API) {
-						console.debug(
-							`[Responses API] Previous response ID not found (${requestBody.previous_response_id}), retrying without it`,
-						)
-					}
+					this.logDebug(
+						`[Responses API] Previous response ID not found (${requestBody.previous_response_id}), retrying without it`,
+					)
 
 					// Remove the problematic previous_response_id and retry
 					const retryRequestBody = { ...requestBody }

src/core/task/Task.ts

@@ -106,6 +106,8 @@ import { Gpt5Metadata, ClineMessageWithMetadata } from "./types"
 
 const MAX_EXPONENTIAL_BACKOFF_SECONDS = 600 // 10 minutes
 const DEFAULT_USAGE_COLLECTION_TIMEOUT_MS = 5000 // 5 seconds
+// Centralized GPT‑5 model prefix to avoid magic strings
+const GPT5_MODEL_PREFIX = "gpt-5"
 
 export type TaskOptions = {
 	provider: ClineProvider
@@ -2394,7 +2396,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 		let previousResponseId: string | undefined = undefined
 		try {
 			const modelId = this.api.getModel().id
-			if (modelId && modelId.startsWith("gpt-5") && !this.skipPrevResponseIdOnce) {
+			if (modelId && modelId.startsWith(GPT5_MODEL_PREFIX) && !this.skipPrevResponseIdOnce) {
 				// Find the last assistant message that has a previous_response_id stored
 				const idx = findLastIndex(
 					this.clineMessages,
@@ -2580,7 +2582,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 	private async persistGpt5Metadata(reasoningMessage?: string): Promise<void> {
 		try {
 			const modelId = this.api.getModel().id
-			if (!modelId || !modelId.startsWith("gpt-5")) return
+			if (!modelId || !modelId.startsWith(GPT5_MODEL_PREFIX)) return
 
 			// Check if the API handler has a getLastResponseId method (OpenAiNativeHandler specific)
 			const handler = this.api as ApiHandler & { getLastResponseId?: () => string | undefined }
@@ -2633,4 +2635,4 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 	public get taskAsk(): ClineMessage | undefined {
 		return this.idleAsk || this.resumableAsk || this.interactiveAsk
 	}
-}
+}