fix: address PR #5582 review feedback for diagnostic messages feature

- Fix default value from 5 to 50 in ClineProvider.ts and tests
- Fix translation inconsistencies in Hindi and Turkish locales
- Move diagnostics delay setting from Auto-Approve to Context Management section

Author: daniel-lxs

src/core/webview/ClineProvider.ts

@@ -1562,7 +1562,7 @@ export class ClineProvider
 			alwaysAllowFollowupQuestions: alwaysAllowFollowupQuestions ?? false,
 			followupAutoApproveTimeoutMs: followupAutoApproveTimeoutMs ?? 60000,
 			includeDiagnosticMessages: includeDiagnosticMessages ?? true,
-			maxDiagnosticMessages: maxDiagnosticMessages ?? 5,
+			maxDiagnosticMessages: maxDiagnosticMessages ?? 50,
 		}
 	}
 
@@ -1730,7 +1730,7 @@ export class ClineProvider
 			profileThresholds: stateValues.profileThresholds ?? {},
 			// Add diagnostic message settings
 			includeDiagnosticMessages: stateValues.includeDiagnosticMessages ?? true,
-			maxDiagnosticMessages: stateValues.maxDiagnosticMessages ?? 5,
+			maxDiagnosticMessages: stateValues.maxDiagnosticMessages ?? 50,
 		}
 
 		// Return the same structure as before
@@ -1824,7 +1824,7 @@ export class ClineProvider
 			profileThresholds: stateValues.profileThresholds ?? {},
 			// Add diagnostic message settings
 			includeDiagnosticMessages: stateValues.includeDiagnosticMessages ?? true,
-			maxDiagnosticMessages: stateValues.maxDiagnosticMessages ?? 5,
+			maxDiagnosticMessages: stateValues.maxDiagnosticMessages ?? 50,
 		}
 	}
 

src/core/webview/__tests__/diagnosticSettingsPersistence.spec.ts

@@ -5,7 +5,7 @@ import { TelemetryService } from "@roo-code/telemetry"
 
 // Default values for diagnostic settings
 const DEFAULT_INCLUDE_DIAGNOSTIC_MESSAGES = true
-const DEFAULT_MAX_DIAGNOSTIC_MESSAGES = 5
+const DEFAULT_MAX_DIAGNOSTIC_MESSAGES = 50
 
 // Mock fs/promises to avoid file system operations
 vi.mock("fs/promises", () => ({

webview-ui/src/components/settings/AutoApproveSettings.tsx

@@ -20,7 +20,6 @@ type AutoApproveSettingsProps = HTMLAttributes<HTMLDivElement> & {
 	alwaysAllowWrite?: boolean
 	alwaysAllowWriteOutsideWorkspace?: boolean
 	alwaysAllowWriteProtected?: boolean
-	writeDelayMs: number
 	alwaysAllowBrowser?: boolean
 	alwaysApproveResubmit?: boolean
 	requestDelaySeconds: number
@@ -39,7 +38,6 @@ type AutoApproveSettingsProps = HTMLAttributes<HTMLDivElement> & {
 		| "alwaysAllowWrite"
 		| "alwaysAllowWriteOutsideWorkspace"
 		| "alwaysAllowWriteProtected"
-		| "writeDelayMs"
 		| "alwaysAllowBrowser"
 		| "alwaysApproveResubmit"
 		| "requestDelaySeconds"
@@ -61,7 +59,6 @@ export const AutoApproveSettings = ({
 	alwaysAllowWrite,
 	alwaysAllowWriteOutsideWorkspace,
 	alwaysAllowWriteProtected,
-	writeDelayMs,
 	alwaysAllowBrowser,
 	alwaysApproveResubmit,
 	requestDelaySeconds,
@@ -216,22 +213,6 @@ export const AutoApproveSettings = ({
 								{t("settings:autoApprove.write.protected.description")}
 							</div>
 						</div>
-						<div>
-							<div className="flex items-center gap-2">
-								<Slider
-									min={0}
-									max={5000}
-									step={100}
-									value={[writeDelayMs]}
-									onValueChange={([value]) => setCachedStateField("writeDelayMs", value)}
-									data-testid="write-delay-slider"
-								/>
-								<span className="w-20">{writeDelayMs}ms</span>
-							</div>
-							<div className="text-vscode-descriptionForeground text-sm mt-1">
-								{t("settings:autoApprove.write.delayLabel")}
-							</div>
-						</div>
 					</div>
 				)}
 

webview-ui/src/components/settings/ContextManagementSettings.tsx

@@ -24,6 +24,7 @@ type ContextManagementSettingsProps = HTMLAttributes<HTMLDivElement> & {
 	profileThresholds?: Record<string, number>
 	includeDiagnosticMessages?: boolean
 	maxDiagnosticMessages?: number
+	writeDelayMs: number
 	setCachedStateField: SetCachedStateField<
 		| "autoCondenseContext"
 		| "autoCondenseContextPercent"
@@ -35,6 +36,7 @@ type ContextManagementSettingsProps = HTMLAttributes<HTMLDivElement> & {
 		| "profileThresholds"
 		| "includeDiagnosticMessages"
 		| "maxDiagnosticMessages"
+		| "writeDelayMs"
 	>
 }
 
@@ -51,6 +53,7 @@ export const ContextManagementSettings = ({
 	profileThresholds = {},
 	includeDiagnosticMessages,
 	maxDiagnosticMessages,
+	writeDelayMs,
 	className,
 	...props
 }: ContextManagementSettingsProps) => {
@@ -271,6 +274,26 @@ export const ContextManagementSettings = ({
 						{t("settings:contextManagement.diagnostics.maxMessages.description")}
 					</div>
 				</div>
+
+				<div>
+					<span className="block font-medium mb-1">
+						{t("settings:contextManagement.diagnostics.delayAfterWrite.label")}
+					</span>
+					<div className="flex items-center gap-2">
+						<Slider
+							min={0}
+							max={5000}
+							step={100}
+							value={[writeDelayMs]}
+							onValueChange={([value]) => setCachedStateField("writeDelayMs", value)}
+							data-testid="write-delay-slider"
+						/>
+						<span className="w-20">{writeDelayMs}ms</span>
+					</div>
+					<div className="text-vscode-descriptionForeground text-sm mt-1">
+						{t("settings:contextManagement.diagnostics.delayAfterWrite.description")}
+					</div>
+				</div>
 			</Section>
 			<Section className="pt-2">
 				<VSCodeCheckbox

webview-ui/src/components/settings/SettingsView.tsx

@@ -610,7 +610,6 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 							alwaysAllowWrite={alwaysAllowWrite}
 							alwaysAllowWriteOutsideWorkspace={alwaysAllowWriteOutsideWorkspace}
 							alwaysAllowWriteProtected={alwaysAllowWriteProtected}
-							writeDelayMs={writeDelayMs}
 							alwaysAllowBrowser={alwaysAllowBrowser}
 							alwaysApproveResubmit={alwaysApproveResubmit}
 							requestDelaySeconds={requestDelaySeconds}
@@ -672,6 +671,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 							profileThresholds={profileThresholds}
 							includeDiagnosticMessages={includeDiagnosticMessages}
 							maxDiagnosticMessages={maxDiagnosticMessages}
+							writeDelayMs={writeDelayMs}
 							setCachedStateField={setCachedStateField}
 						/>
 					)}

webview-ui/src/i18n/locales/en/settings.json

@@ -498,6 +498,10 @@
 				"description": "Limits the number of diagnostic messages (errors, warnings) included in the context. When set, only this many diagnostics will be shown, prioritizing errors over warnings. Set to 0 for unlimited diagnostics.",
 				"resetTooltip": "Reset to default value (50)",
 				"unlimitedLabel": "Unlimited"
+			},
+			"delayAfterWrite": {
+				"label": "Delay after writes to allow diagnostics to detect potential problems",
+				"description": "Time to wait after file writes before proceeding, allowing diagnostic tools to process changes and detect issues."
 			}
 		},
 		"condensingThreshold": {