fix: address feedback for provider-level todo list toggle

- Remove unnecessary backfill logic for non-existent setting
- Move temperature and rate limit controls under advanced settings toggle
- Fix text wrapping issue with whitespace-nowrap class

Addresses feedback from issue #5624

Author: roomote

src/core/config/ProviderSettingsManager.ts

@@ -215,22 +215,13 @@ export class ProviderSettingsManager {
 
 	private async migrateTodoListSettings(providerProfiles: ProviderProfiles) {
 		try {
-			let todoListEnabled: boolean | undefined
-
-			try {
-				todoListEnabled = await this.context.globalState.get<boolean>("alwaysAllowUpdateTodoList")
-			} catch (error) {
-				console.error("[MigrateTodoListSettings] Error getting global todo list settings:", error)
-			}
-
-			if (todoListEnabled === undefined) {
-				// Failed to get the existing value, use the default.
-				todoListEnabled = true
-			}
+			// No backfill required - this is a new provider-level setting
+			// Default to true (enabled) for all existing profiles
+			const defaultTodoListEnabled = true
 
 			for (const [_name, apiConfig] of Object.entries(providerProfiles.apiConfigs)) {
 				if (apiConfig.todoListEnabled === undefined) {
-					apiConfig.todoListEnabled = todoListEnabled
+					apiConfig.todoListEnabled = defaultTodoListEnabled
 				}
 			}
 		} catch (error) {

webview-ui/src/components/settings/AdvancedSettingsSection.tsx

@@ -9,13 +9,15 @@ interface AdvancedSettingsSectionProps {
 	fuzzyMatchThreshold?: number
 	todoListEnabled?: boolean
 	onChange: (field: "diffEnabled" | "fuzzyMatchThreshold" | "todoListEnabled", value: any) => void
+	children?: React.ReactNode
 }
 
 export const AdvancedSettingsSection: React.FC<AdvancedSettingsSectionProps> = ({
 	diffEnabled,
 	fuzzyMatchThreshold,
 	todoListEnabled,
 	onChange,
+	children,
 }) => {
 	const { t } = useAppTranslation()
 	const [isExpanded, setIsExpanded] = useState(false)
@@ -30,7 +32,7 @@ export const AdvancedSettingsSection: React.FC<AdvancedSettingsSectionProps> = (
 				appearance="secondary"
 				onClick={toggleExpanded}
 				className="flex items-center justify-between w-full text-left">
-				<span className="font-medium">{t("settings:advanced.section.label")}</span>
+				<span className="font-medium whitespace-nowrap">{t("settings:advanced.section.label")}</span>
 				<span className="ml-2">{isExpanded ? "▼" : "▶"}</span>
 			</VSCodeButton>
 
@@ -42,6 +44,7 @@ export const AdvancedSettingsSection: React.FC<AdvancedSettingsSectionProps> = (
 						onChange={onChange}
 					/>
 					<TodoListSettingsControl todoListEnabled={todoListEnabled} onChange={onChange} />
+					{children}
 				</div>
 			)}
 		</div>

webview-ui/src/components/settings/ApiOptions.tsx

@@ -532,13 +532,11 @@ const ApiOptions = ({
 			/>
 
 			{!fromWelcomeView && (
-				<>
-					<AdvancedSettingsSection
-						diffEnabled={apiConfiguration.diffEnabled}
-						fuzzyMatchThreshold={apiConfiguration.fuzzyMatchThreshold}
-						todoListEnabled={apiConfiguration.todoListEnabled}
-						onChange={(field, value) => setApiConfigurationField(field, value)}
-					/>
+				<AdvancedSettingsSection
+					diffEnabled={apiConfiguration.diffEnabled}
+					fuzzyMatchThreshold={apiConfiguration.fuzzyMatchThreshold}
+					todoListEnabled={apiConfiguration.todoListEnabled}
+					onChange={(field, value) => setApiConfigurationField(field, value)}>
 					<TemperatureControl
 						value={apiConfiguration.modelTemperature}
 						onChange={handleInputChange("modelTemperature", noTransform)}
@@ -548,7 +546,7 @@ const ApiOptions = ({
 						value={apiConfiguration.rateLimitSeconds || 0}
 						onChange={(value) => setApiConfigurationField("rateLimitSeconds", value)}
 					/>
-				</>
+				</AdvancedSettingsSection>
 			)}
 		</div>
 	)