fix: hide todos parameter from new_task tool prompt when experiment is disabled

- Modified getNewTaskDescription to completely omit todos parameter when experiment is off
- Updated tests to verify todos parameter is not shown at all when disabled
- Ensures tool prompt remains unchanged when experimental setting is disabled
- Maintains backward compatibility while providing cleaner prompt interface

Author: roomote

src/core/prompts/tools/__tests__/new-task.spec.ts

@@ -3,7 +3,7 @@ import { getNewTaskDescription } from "../new-task"
 import { ToolArgs } from "../types"
 
 describe("getNewTaskDescription", () => {
-	it("should show todos as optional when experiment is disabled", () => {
+	it("should not show todos parameter at all when experiment is disabled", () => {
 		const args: ToolArgs = {
 			cwd: "/test",
 			supportsComputerUse: false,
@@ -14,12 +14,18 @@ describe("getNewTaskDescription", () => {
 
 		const description = getNewTaskDescription(args)
 
-		// Check that todos is marked as optional
-		expect(description).toContain("todos: (optional)")
-		expect(description).toContain("optional initial todo list")
+		// Check that todos parameter is not mentioned at all
+		expect(description).not.toContain("todos:")
+		expect(description).not.toContain("todo list")
+		expect(description).not.toContain("<todos>")
+		expect(description).not.toContain("</todos>")
 
-		// Should not contain any mention of required
-		expect(description).not.toContain("todos: (required)")
+		// Should have a simple example without todos
+		expect(description).toContain("Implement a new feature for the application")
+
+		// Should still have mode and message as required
+		expect(description).toContain("mode: (required)")
+		expect(description).toContain("message: (required)")
 	})
 
 	it("should show todos as required when experiment is enabled", () => {
@@ -40,9 +46,14 @@ describe("getNewTaskDescription", () => {
 		// Should not contain any mention of optional for todos
 		expect(description).not.toContain("todos: (optional)")
 		expect(description).not.toContain("optional initial todo list")
+
+		// Should include todos in the example
+		expect(description).toContain("<todos>")
+		expect(description).toContain("</todos>")
+		expect(description).toContain("Set up auth middleware")
 	})
 
-	it("should default to optional when experiments is undefined", () => {
+	it("should not show todos parameter when experiments is undefined", () => {
 		const args: ToolArgs = {
 			cwd: "/test",
 			supportsComputerUse: false,
@@ -51,12 +62,14 @@ describe("getNewTaskDescription", () => {
 
 		const description = getNewTaskDescription(args)
 
-		// Check that todos is marked as optional by default
-		expect(description).toContain("todos: (optional)")
-		expect(description).toContain("optional initial todo list")
+		// Check that todos parameter is not shown by default
+		expect(description).not.toContain("todos:")
+		expect(description).not.toContain("todo list")
+		expect(description).not.toContain("<todos>")
+		expect(description).not.toContain("</todos>")
 	})
 
-	it("should default to optional when newTaskRequireTodos is undefined", () => {
+	it("should not show todos parameter when newTaskRequireTodos is undefined", () => {
 		const args: ToolArgs = {
 			cwd: "/test",
 			supportsComputerUse: false,
@@ -65,12 +78,14 @@ describe("getNewTaskDescription", () => {
 
 		const description = getNewTaskDescription(args)
 
-		// Check that todos is marked as optional by default
-		expect(description).toContain("todos: (optional)")
-		expect(description).toContain("optional initial todo list")
+		// Check that todos parameter is not shown by default
+		expect(description).not.toContain("todos:")
+		expect(description).not.toContain("todo list")
+		expect(description).not.toContain("<todos>")
+		expect(description).not.toContain("</todos>")
 	})
 
-	it("should always include the example with todos", () => {
+	it("should only include todos in example when experiment is enabled", () => {
 		const argsWithExperimentOff: ToolArgs = {
 			cwd: "/test",
 			supportsComputerUse: false,
@@ -90,9 +105,13 @@ describe("getNewTaskDescription", () => {
 		const descriptionOff = getNewTaskDescription(argsWithExperimentOff)
 		const descriptionOn = getNewTaskDescription(argsWithExperimentOn)
 
-		// Both should include the example with todos
-		const examplePattern = /<todos>\s*\[\s*\]\s*Set up auth middleware/s
-		expect(descriptionOff).toMatch(examplePattern)
-		expect(descriptionOn).toMatch(examplePattern)
+		// When experiment is off, should NOT include todos in example
+		const todosPattern = /<todos>\s*\[\s*\]\s*Set up auth middleware/s
+		expect(descriptionOff).not.toMatch(todosPattern)
+		expect(descriptionOff).not.toContain("<todos>")
+
+		// When experiment is on, should include todos in example
+		expect(descriptionOn).toMatch(todosPattern)
+		expect(descriptionOn).toContain("<todos>")
 	})
 })

src/core/prompts/tools/new-task.ts

@@ -2,15 +2,38 @@ import { ToolArgs } from "./types"
 
 export function getNewTaskDescription(args: ToolArgs): string {
 	const todosRequired = args.experiments?.newTaskRequireTodos === true
-	const todosStatus = todosRequired ? "(required)" : "(optional)"
 
+	// When experiment is disabled, don't show todos parameter at all
+	if (!todosRequired) {
+		return `## new_task
+Description: This will let you create a new task instance in the chosen mode using your provided message.
+
+Parameters:
+- mode: (required) The slug of the mode to start the new task in (e.g., "code", "debug", "architect").
+- message: (required) The initial user message or instructions for this new task.
+
+Usage:
+<new_task>
+<mode>your-mode-slug-here</mode>
+<message>Your initial instructions here</message>
+</new_task>
+
+Example:
+<new_task>
+<mode>code</mode>
+<message>Implement a new feature for the application.</message>
+</new_task>
+`
+	}
+
+	// When experiment is enabled, show todos as required
 	return `## new_task
-Description: This will let you create a new task instance in the chosen mode using your provided message${todosRequired ? " and initial todo list" : " and optional initial todo list"}.
+Description: This will let you create a new task instance in the chosen mode using your provided message and initial todo list.
 
 Parameters:
 - mode: (required) The slug of the mode to start the new task in (e.g., "code", "debug", "architect").
 - message: (required) The initial user message or instructions for this new task.
-- todos: ${todosStatus} The initial todo list in markdown checklist format for the new task.
+- todos: (required) The initial todo list in markdown checklist format for the new task.
 
 Usage:
 <new_task>